diff options
| author | Santiago Fernandez Madero <safern@microsoft.com> | 2020-08-25 23:04:25 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-25 23:04:25 +0300 |
| commit | 954ca9c98b4a5fede505bfabffbdd76ec01461ac (patch) | |
| tree | 40efe2e76fa3bdebd01fb68c9de6e8537cfcb3d9 /eng/Signing.props | |
| parent | bad8645dce89991ffa011c59a147d5ab4c5c63fe (diff) | |
Fix signing in official build with 3rd party libraries (#41346)
* Fix signing in official build with 3rd party libraries
* Update eng/Signing.props
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Diffstat (limited to 'eng/Signing.props')
| -rw-r--r-- | eng/Signing.props | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/eng/Signing.props b/eng/Signing.props index 5b7461f9609..1ca34c107da 100644 --- a/eng/Signing.props +++ b/eng/Signing.props @@ -28,6 +28,13 @@ <!-- apphost and comhost template files are not signed, by design. --> <FileSignInfo Include="apphost.exe;singlefilehost.exe;comhost.dll" CertificateName="None" /> + + <!-- Third-party components which should be signed. --> + <FileSignInfo Include="Newtonsoft.Json.dll" CertificateName="3PartySHA2" /> + <FileSignInfo Include="Mono.Cecil.dll" CertificateName="3PartySHA2" /> + <FileSignInfo Include="Mono.Cecil.Mdb.dll" CertificateName="3PartySHA2" /> + <FileSignInfo Include="Mono.Cecil.Pdb.dll" CertificateName="3PartySHA2" /> + <FileSignInfo Include="Mono.Cecil.Rocks.dll" CertificateName="3PartySHA2" /> </ItemGroup> <ItemGroup Condition="'$(CrossTargetComponentFolder)' != ''"> @@ -109,14 +116,6 @@ </ItemGroup> <ItemGroup> - <!-- External files --> - <ItemsToSign Remove="@(ItemsToSign->WithMetadataValue('Filename', 'Newtonsoft.Json'))" /> - <ItemsToSign Remove="@(ItemsToSign->WithMetadataValue('Filename', 'Mono.Cecil'))" /> - <ItemsToSign Remove="@(ItemsToSign->WithMetadataValue('Filename', 'Mono.Cecil.Pdb'))" /> - <ItemsToSign Remove="@(ItemsToSign->WithMetadataValue('Filename', 'Mono.Cecil.Rocks'))" /> - </ItemGroup> - - <ItemGroup> <ItemsToSign Update="@(ItemsToSign)" Authenticode="$(CertificateId)" /> </ItemGroup> |