diff options
| author | Viktor Hofer <viktor.hofer@microsoft.com> | 2022-04-26 09:18:08 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-26 09:18:08 +0300 |
| commit | 6387a2dc3de16e2f22c8e49678bee33506260c46 (patch) | |
| tree | ba8d8605b3f320278fe600550e376d4d01a8ce41 /eng/illink.targets | |
| parent | b42adaddff9047e32c9d7f4145746dbb579758f2 (diff) | |
Run illink before ApiCompat (#66706)
* Run illink before ApiCompat and GenAPI
As observed in https://github.com/dotnet/runtime/issues/66634#issuecomment-1068556981, illink currently runs after APICompat. This happens because nuget imports the ApiCompat targets earlier than the illink.targets is imported.
* Update illink.targets
* Use ApiCompatDependsOn
Diffstat (limited to 'eng/illink.targets')
| -rw-r--r-- | eng/illink.targets | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/eng/illink.targets b/eng/illink.targets index ce06abbf10e..33d7dd9a186 100644 --- a/eng/illink.targets +++ b/eng/illink.targets @@ -1,17 +1,10 @@ <Project> <PropertyGroup> <IsTrimmable Condition="'$(IsTrimmable)' == ''">true</IsTrimmable> - <PrepareResourcesDependsOn> - _EmbedILLinkXmls; - $(PrepareResourcesDependsOn) - </PrepareResourcesDependsOn> - </PropertyGroup> - - <PropertyGroup> - <TargetsTriggeredByCompilation Condition="'$(DesignTimeBuild)' != 'true'"> - $(TargetsTriggeredByCompilation); - ILLinkTrimAssembly - </TargetsTriggeredByCompilation> + <PrepareResourcesDependsOn>_EmbedILLinkXmls;$(PrepareResourcesDependsOn)</PrepareResourcesDependsOn> + <TargetsTriggeredByCompilation Condition="'$(DesignTimeBuild)' != 'true'">$(TargetsTriggeredByCompilation);ILLinkTrimAssembly</TargetsTriggeredByCompilation> + <!-- ApiCompat should perform compatibility checks on the trimmed assemblies. --> + <ApiCompatDependsOn>$(ApiCompatDependsOn);ILLinkTrimAssembly</ApiCompatDependsOn> </PropertyGroup> <!-- Inputs and outputs of ILLinkTrimAssembly --> |