diff options
author | Eric StJohn <ericstj@microsoft.com> | 2021-01-19 02:17:06 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-01-19 02:17:06 +0300 |
commit | 91d7e25733f8b15568b58eb9f33c0d0b45ea6bb4 (patch) | |
tree | 5c4d25ed4255357e3908d4c3c19659313251222b /eng/resolveContract.targets | |
parent | 3946369dd6e42cc59e09651ce3e9d09751d44131 (diff) |
Make changes to reference assembly rerun compile (#46999)
* Make changes to reference assembly rerun compile
* Make sure src project will build ref project
This ensures we'll catch incremental changes to reference assemblies
* Allow a project to specify its reference assembly
Diffstat (limited to 'eng/resolveContract.targets')
-rw-r--r-- | eng/resolveContract.targets | 24 |
1 files changed, 7 insertions, 17 deletions
diff --git a/eng/resolveContract.targets b/eng/resolveContract.targets index 06084755937..f41be687441 100644 --- a/eng/resolveContract.targets +++ b/eng/resolveContract.targets @@ -1,32 +1,22 @@ <Project> <PropertyGroup> - <ContractDependencyPaths Condition="'$(DisableImplicitFrameworkReferences)' == 'true' and - '$(TargetFrameworkIdentifier)' == '.NETCoreApp'">$(MicrosoftNetCoreAppRefPackRefDir)</ContractDependencyPaths> - <!-- Use implementation referencepath if no contract tfm is set. --> - <ContractDependencyPaths Condition="'$(ContractDependencyPaths)' == ''">$(ContractDependencyPaths);@(ReferencePath->'%(RelativeDir)'->Distinct())</ContractDependencyPaths> + <!-- Use implementation referencepath if no contract dependency path is set. + This item transform is executed at the time this property is evaluated in the API Compat targets. --> + <ContractDependencyPaths Condition="'$(ContractDependencyPaths)' == ''">@(ReferencePath->'%(RelativeDir)'->Distinct())</ContractDependencyPaths> </PropertyGroup> <PropertyGroup Condition="'$(IsSourceProject)' == 'true'"> <ContractProject Condition="'$(ContractProject)' == ''">$(LibrariesProjectRoot)$(MSBuildProjectName)\ref\$(MSBuildProjectName).csproj</ContractProject> <HasMatchingContract Condition="'$(HasMatchingContract)' == '' and Exists('$(ContractProject)')">true</HasMatchingContract> - <ContractAssemblyPath Condition="'$(ContractAssemblyPath)' == '' and - '$(TargetFrameworkIdentifier)' == '.NETCoreApp' and - $([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), '$(NETCoreAppCurrentVersion)'))">$(NetCoreAppCurrentRefPath)$(TargetFileName)</ContractAssemblyPath> - <_TargetFrameworkWithoutPlatform>$([System.Text.RegularExpressions.Regex]::Replace('$(TargetFramework)', '(-[^;]+)', ''))</_TargetFrameworkWithoutPlatform> - <ContractAssemblyPath Condition="'$(ContractAssemblyPath)' == ''">$([MSBuild]::NormalizePath('$(BaseOutputPath)', 'ref', '$(_TargetFrameworkWithoutPlatform)-$(Configuration)', '$(TargetFileName)'))</ContractAssemblyPath> <!-- Disable API compat if the project doesn't have reference assembly --> <RunApiCompat Condition="'$(HasMatchingContract)' != 'true'">false</RunApiCompat> </PropertyGroup> - <ItemGroup Condition="'$(HasMatchingContract)' == 'true'"> - <ResolvedMatchingContract Condition="Exists('$(ContractAssemblyPath)')" Include="$(ContractAssemblyPath)" /> - <!-- If the contract doesn't exist in the default contract output path add a project reference to the contract project to resolve --> - <ProjectReference Condition="'@(ResolvedMatchingContract)' == ''" Include="$(ContractProject)"> - <ReferenceOutputAssembly>false</ReferenceOutputAssembly> - <OutputItemType>ResolvedMatchingContract</OutputItemType> - </ProjectReference> + <ItemGroup Condition="'$(HasMatchingContract)' == 'true' and '$(ContractProject)' != '' and '@(ResolvedMatchingContract)' == ''"> + <ProjectReference Include="$(ContractProject)" ReferenceOutputAssembly="false" OutputItemType="ResolvedMatchingContract" /> + <!-- We aren't referencing the contract, but make sure it's considered as an input to Compile so that if it changes we rebuild and rerun API compat --> + <ProjectReference Include="$(ContractProject)" ReferenceOutputAssembly="false" OutputItemType="CustomAdditionalCompileInputs" /> </ItemGroup> - <!-- intentionally empty since we no longer need a target --> <Target Name="ResolveMatchingContract" /> |