diff options
| author | Viktor Hofer <viktor.hofer@microsoft.com> | 2022-02-11 10:10:13 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-02-11 10:10:13 +0300 |
| commit | 9293aab2379d6a122d0cf5ed350356cb23e4d698 (patch) | |
| tree | c6f0ff3630cb6e807816adeb936a222367bae01a /eng/resolveContract.targets | |
| parent | 49fea677298585e729f993e12a18f6188c6a6043 (diff) | |
Subtract instead of building the cartesian product in targets (#65123)
* Subtract instead of cartesian product in targets
See https://github.com/dotnet/runtime/pull/64000#issuecomment-1030460532. These targets were quite expensive and noticeable in no-op builds. Instead of building the cartesian product via item batching, using subtraction which avoids unnecessary items to be computed.
* Update resolveContract.targets
* Update targetingpacks.targets
* Update resolveContract.targets
* Update resolveContract.targets
Diffstat (limited to 'eng/resolveContract.targets')
| -rw-r--r-- | eng/resolveContract.targets | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/eng/resolveContract.targets b/eng/resolveContract.targets index cff60b79eb2..327273a100e 100644 --- a/eng/resolveContract.targets +++ b/eng/resolveContract.targets @@ -42,12 +42,10 @@ </PropertyGroup> <!-- Clear the ReferenceAssembly attribute on resolved P2Ps that set SkipUseReferenceAssembly to true. --> <ItemGroup> - <_resolvedP2PFiltered Include="@(ProjectReference)"> - <ProjectReferenceItemSpec>$([System.IO.Path]::GetFullPath('%(ProjectReference.Identity)'))</ProjectReferenceItemSpec> - <SkipUseReferenceAssembly>%(ProjectReference.SkipUseReferenceAssembly)</SkipUseReferenceAssembly> - </_resolvedP2PFiltered> - <_ResolvedProjectReferencePaths Update="@(_resolvedP2PFiltered)" - Condition="'%(_resolvedP2PFiltered.ProjectReferenceItemSpec)' == '%(_resolvedP2PFiltered.MSBuildSourceProjectFile)' and + <_resolvedP2PFiltered Include="@(ProjectReference)" + ProjectReferenceItemSpec="$([System.IO.Path]::GetFullPath('%(ProjectReference.Identity)'))" + SkipUseReferenceAssembly="%(ProjectReference.SkipUseReferenceAssembly)" /> + <_ResolvedProjectReferencePaths Condition="'%(_resolvedP2PFiltered.ProjectReferenceItemSpec)' == '%(_resolvedP2PFiltered.MSBuildSourceProjectFile)' and '%(_resolvedP2PFiltered.SkipUseReferenceAssembly)' == 'true'" ReferenceAssembly="" /> </ItemGroup> |