`runtime-staging`: Enable failed tests on stable jobs to fail the job (#73400)

* xplat-setup.yml: Add support for setting `shouldContinueOnError` to

.. `false`.

Currently, xplat-setup.yml passes on `shouldContinueOnError` to the
template with `true` if the parameter was `true`, else it sets the value
based on whether this is for runtime-staging, on a PR.

Which essentially means that runtime-staging defaults to
`shouldContinueOnError: true` for PRs, or we can set it explcitly to
`true` which would affect the rolling builds.

But this does not allow making a runtime-staging job *fail* when *tests
fail*. To support that this change adds a check for a special value
`forceFalse`, which causes the param to explicitly set to `false`. Thus
allowing `runtime-staging` builds to be marked as such.

* [wasm] Add more paths to trigger running tests on CI

* fix comment

4 files changed, 20 insertions, 4 deletions

diff --git a/eng/pipelines/common/evaluate-default-paths.yml b/eng/pipelines/common/evaluate-default-paths.yml
index 9eaf4c45e0a..3fcfcbd5133 100644
--- a/eng/pipelines/common/evaluate-default-paths.yml
+++ b/eng/pipelines/common/evaluate-default-paths.yml
@@ -109,6 +109,7 @@ jobs:
       - src/tests/BuildWasmApps/Directory.Build*
       - src/tests/BuildWasmApps/Wasm.Build.Tests/*
       - src/mono/wasm/build/*
+      - src/mono/wasm/host/*
       - src/mono/wasm/runtime/*
       - src/mono/wasm/templates/*
       - src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/*
@@ -135,7 +136,17 @@ jobs:
     - subset: allwasm
       include:
       - eng/Version.Details.xml
+      - src/mono/*.proj
+      - src/mono/Directory.Build*
+      - src/mono/CMakeLists.txt
+      - src/mono/System.Private.CoreLib/*
+      - src/mono/mono/*
       - src/mono/wasm/emscripten-version.txt
+      - src/mono/wasm/build/*
+      - src/mono/wasm/data/aot-tests/*
+      - src/mono/wasm/runtime/*
+      - src/mono/wasm/test-main.js
+      - src/mono/wasm/wasm.proj
 
     - ${{ if ne(parameters.extraSubsets, '') }}:
       - ${{ parameters.extraSubsets }}
diff --git a/eng/pipelines/common/templates/wasm-build-tests.yml b/eng/pipelines/common/templates/wasm-build-tests.yml
index 54926c5da25..369624c0adc 100644
--- a/eng/pipelines/common/templates/wasm-build-tests.yml
+++ b/eng/pipelines/common/templates/wasm-build-tests.yml
@@ -2,6 +2,7 @@ parameters:
   alwaysRun: false
   isExtraPlatformsBuild: false
   platforms: []
+  shouldContinueOnError: false
 
 jobs:
 
@@ -15,6 +16,7 @@ jobs:
     buildConfig: Release
     runtimeFlavor: mono
     platforms: ${{ parameters.platforms }}
+    shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
     variables:
       # map dependencies variables to local variables
       - name: wasmbuildtestsContainsChange
diff --git a/eng/pipelines/common/xplat-setup.yml b/eng/pipelines/common/xplat-setup.yml
index 84fd99e3e04..25314635d9b 100644
--- a/eng/pipelines/common/xplat-setup.yml
+++ b/eng/pipelines/common/xplat-setup.yml
@@ -9,13 +9,13 @@ parameters:
   platform: ''
   targetRid: ''
   jobParameters: {}
-  shouldContinueOnError: false
+  shouldContinueOnError: false # set `shouldContinueOnError: forceFalse` to not use the defaults, and set specifically to `false`
   variables: []
 
 jobs:
 - template: ${{ coalesce(parameters.helixQueuesTemplate, parameters.jobTemplate) }}
   parameters:
-    shouldContinueOnError: ${{ or(eq(parameters.shouldContinueOnError, true), and(endsWith(variables['Build.DefinitionName'], 'staging'), eq(variables['Build.Reason'], 'PullRequest'))) }}
+    shouldContinueOnError: ${{ or(eq(parameters.shouldContinueOnError, true), and(ne(parameters.shouldContinueOnError, 'forceFalse'), endsWith(variables['Build.DefinitionName'], 'staging'), eq(variables['Build.Reason'], 'PullRequest'))) }}
 
     # keep in sync with /eng/pipelines/common/variables.yml
     dependOnEvaluatePaths: ${{ and(eq(variables['Build.Reason'], 'PullRequest'), in(variables['Build.DefinitionName'], 'runtime', 'runtime-staging', 'runtime-community', 'runtime-extra-platforms')) }}
diff --git a/eng/pipelines/runtime-staging.yml b/eng/pipelines/runtime-staging.yml
index d6c24860e62..b5ce3e8bf43 100644
--- a/eng/pipelines/runtime-staging.yml
+++ b/eng/pipelines/runtime-staging.yml
@@ -59,13 +59,13 @@ jobs:
   - template: /eng/pipelines/common/evaluate-default-paths.yml
 
 #
-# WebAssembly legs - run windows builds. Also, debugger tests which are currently
-# unstable
+# WebAssembly legs - library tests, Wasm.Build.Tests, and debugger tests
 #
 - template: /eng/pipelines/common/templates/wasm-library-tests.yml
   parameters:
     platforms:
       - Browser_wasm_win
+    shouldContinueOnError: forceFalse
     alwaysRun: ${{ variables.isRollingBuild }}
     scenarios:
       - WasmTestOnBrowser
@@ -78,12 +78,14 @@ jobs:
     nameSuffix: _AOT
     runSmokeOnlyArg: $(_runSmokeTestsOnlyArg)
     runAOT: true
+    shouldContinueOnError: forceFalse
     alwaysRun: ${{ variables.isRollingBuild }}
 
 - template: /eng/pipelines/common/templates/wasm-build-tests.yml
   parameters:
     platforms:
       - Browser_wasm_win
+    shouldContinueOnError: forceFalse
     alwaysRun: ${{ variables.isRollingBuild }}
 
 - template: /eng/pipelines/common/templates/wasm-debugger-tests.yml
@@ -91,6 +93,7 @@ jobs:
     platforms:
       - Browser_wasm
       - Browser_wasm_win
+    shouldContinueOnError: forceFalse
     alwaysRun: ${{ variables.isRollingBuild }}
 
 - template: /eng/pipelines/common/templates/wasm-debugger-tests.yml