diff options
author | Michal Strehovský <MichalStrehovsky@users.noreply.github.com> | 2022-09-28 03:34:15 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-09-28 03:34:15 +0300 |
commit | 6c2cfa4ae26ab71ea42a2cf12b3ae37bb6d134c5 (patch) | |
tree | f608240ff982fdfe2775e2501e52fc80dbd59026 /src/libraries | |
parent | 15dd63f2ec4c098a9744055d511cdb15dc235b5a (diff) |
Remove IlcTrimMetadata=false from a couple tests (#76234)
Contributes to https://github.com/dotnet/runtime/issues/71506.
Diffstat (limited to 'src/libraries')
5 files changed, 4 insertions, 8 deletions
diff --git a/src/libraries/System.Collections.NonGeneric/tests/QueueTests.cs b/src/libraries/System.Collections.NonGeneric/tests/QueueTests.cs index e98bb736fd1..2ff12cec242 100644 --- a/src/libraries/System.Collections.NonGeneric/tests/QueueTests.cs +++ b/src/libraries/System.Collections.NonGeneric/tests/QueueTests.cs @@ -91,7 +91,7 @@ namespace System.Collections.Tests AssertExtensions.Throws<ArgumentNullException>("col", () => new Queue(null)); // Collection is null } - [Fact] + [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))] public static void DebuggerAttribute() { DebuggerAttributes.ValidateDebuggerDisplayReferences(new Queue()); diff --git a/src/libraries/System.Collections.NonGeneric/tests/SortedListTests.cs b/src/libraries/System.Collections.NonGeneric/tests/SortedListTests.cs index 63959915e02..d2e2865590b 100644 --- a/src/libraries/System.Collections.NonGeneric/tests/SortedListTests.cs +++ b/src/libraries/System.Collections.NonGeneric/tests/SortedListTests.cs @@ -212,7 +212,7 @@ namespace System.Collections.Tests AssertExtensions.Throws<ArgumentNullException>("d", () => new SortedList(null, new CustomComparer())); // Dictionary is null } - [Fact] + [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))] public void DebuggerAttribute_Empty() { Assert.Equal("Count = 0", DebuggerAttributes.ValidateDebuggerDisplayReferences(new SortedList())); @@ -266,7 +266,7 @@ namespace System.Collections.Tests const int MinCapacity = InitialCapacity * 2 + 1; var sortedList = new SortedList(InitialCapacity); - MethodInfo ensureCapacity = sortedList.GetType().GetMethod("EnsureCapacity", BindingFlags.NonPublic | BindingFlags.Instance); + MethodInfo ensureCapacity = typeof(SortedList).GetMethod("EnsureCapacity", BindingFlags.NonPublic | BindingFlags.Instance); ensureCapacity.Invoke(sortedList, new object[] { MinCapacity }); Assert.Equal(MinCapacity, sortedList.Capacity); diff --git a/src/libraries/System.Collections.NonGeneric/tests/StackTests.cs b/src/libraries/System.Collections.NonGeneric/tests/StackTests.cs index a9ecc5d37b0..85380c7b733 100644 --- a/src/libraries/System.Collections.NonGeneric/tests/StackTests.cs +++ b/src/libraries/System.Collections.NonGeneric/tests/StackTests.cs @@ -69,7 +69,7 @@ namespace System.Collections.Tests AssertExtensions.Throws<ArgumentNullException>("col", () => new Stack(null)); // Collection is null } - [Fact] + [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsDebuggerTypeProxyAttributeSupported))] public static void DebuggerAttribute() { DebuggerAttributes.ValidateDebuggerDisplayReferences(new Stack()); diff --git a/src/libraries/System.Collections.NonGeneric/tests/System.Collections.NonGeneric.Tests.csproj b/src/libraries/System.Collections.NonGeneric/tests/System.Collections.NonGeneric.Tests.csproj index 892b48394c0..9527a6f551a 100644 --- a/src/libraries/System.Collections.NonGeneric/tests/System.Collections.NonGeneric.Tests.csproj +++ b/src/libraries/System.Collections.NonGeneric/tests/System.Collections.NonGeneric.Tests.csproj @@ -3,8 +3,6 @@ <IncludeRemoteExecutor>true</IncludeRemoteExecutor> <TargetFramework>$(NetCoreAppCurrent)</TargetFramework> <DebuggerSupport Condition="'$(DebuggerSupport)' == '' and '$(TargetOS)' == 'Browser'">true</DebuggerSupport> - <!--Remove once this is fixed, https://github.com/dotnet/runtime/issues/71506 --> - <IlcTrimMetadata>false</IlcTrimMetadata> </PropertyGroup> <ItemGroup> <!-- Common Collections tests --> diff --git a/src/libraries/System.Net.Security/tests/UnitTests/System.Net.Security.Unit.Tests.csproj b/src/libraries/System.Net.Security/tests/UnitTests/System.Net.Security.Unit.Tests.csproj index 1dd366e72a0..1d7184003da 100644 --- a/src/libraries/System.Net.Security/tests/UnitTests/System.Net.Security.Unit.Tests.csproj +++ b/src/libraries/System.Net.Security/tests/UnitTests/System.Net.Security.Unit.Tests.csproj @@ -13,8 +13,6 @@ <TargetFrameworks>$(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-Unix;$(NetCoreAppCurrent)-Browser;$(NetCoreAppCurrent)-OSX;$(NetCoreAppCurrent)-iOS;$(NetCoreAppCurrent)-Android</TargetFrameworks> <IgnoreForCI Condition="'$(TargetOS)' == 'Browser'">true</IgnoreForCI> <EnableLibraryImportGenerator>true</EnableLibraryImportGenerator> - <!--Remove once this is fixed, https://github.com/dotnet/runtime/issues/71506 --> - <IlcTrimMetadata>false</IlcTrimMetadata> </PropertyGroup> <ItemGroup> <Compile Include="AssemblyInfo.cs" /> |