| Age | Commit message (Collapse) | Author |
|---|
|
classification (#64279)
|
|
Microsoft.Interop.SourceGeneration (#59683)
|
|
|
|
* Make sure rid specific libs projs get packaged
RID specific runtime.*.runtime.native.System.IO.Ports projects weren't
packaged because the GeneratePackageOnBuild property wasn't set to true
for them. The property was only true during an allconfigurations build.
As these projects are only built outside of an allconfigurations build,
the GeneratePackageOnBuild property needs to account for such as well.
Also updating the NoTargets Sdk to clean the rid specific package up.
Moving the GeneratePackageOnBuild logic into a props file and set it to
false during servicing (or runtimelab) so that devs can set the property
during servicing directly in the project file if a project should be
packaged.
* Remove the GeneratePackage property
That property was intended to enabled incremental servicing but with
now using the NuGet Pack task we can just make use of the publicl
available GeneratePackageOnBuild property.
* Fix IsPackable setting
|
|
* Automatically generate .NETStandard compat errors
Before this change, a project had to explicitly add a
NETStandardCompatError item to declare that a given tfm range
shouldn't be supported when packaging.
Automate this logic so that projects don't need to specify the item
themselves anymore. Instead condition the NETStandardCompatError target
calcuation logic on the existence of both a .NETStandard and a
.NETCoreApp tfm.
* Update Directory.Build.targets
* Update packaging.targets
* Update eng/packaging.targets
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
|
|
* Move corehost.proj to corehost directory
* Simplify host version overriding
|
|
It appears when we added the workloads subset, the msi projects
contained a step to add a License.txt file to the packages it creates.
This resulted in a conflict as runtime will also add one.
To fix, we'll skip adding the extra License.txt file when the project is
'msi.csproj'.
Fixes https://github.com/dotnet/runtime/issues/56516
|
|
* Clean-up pkgproj leftovers in libs and apply fixes
Remove any pkgproj infrastructure that was only used by src/libraries
(which is the majority). Delete the packageindex *YAY*.
Update the documentation that covered the packageindex and the pkgprojs.
Avoid any incremental builds during packaging by removing
libraries-packages.proj and use src.proj for packaging instead. Make use
of the `GeneratePackageOnBuild` property to build package during the
allconfigurations without requiring a different entry target.
Fix the addition of the DocumentationFile during packaging when
`GeneratePackageOnBuid` is used by hooking onto the
`DocumentationProjectOutputGroup` that NuGet uses and replacing the
generated documentation file with the one that comes via the
intellisense package.
Also introduce a property to choose the generated documentation file
over the one from the intellisense package:
<UseIntellisenseDocumentationFile>false</UseIntellisenseDocumentationFile>
Removing a few leftover PackageDescription properties from the projects'
Directory.Build.props file.
Cleaning up properties in Directory.Build.props & Directory.Build.targets
files.
* Actually run packaging during the allconfigurations build
* Update docs
* make runtime specific pkgs non packable
* io.ports native pkg fixes
|
|
feature/use-dllimport-generator
|
|
* port system.diagnostics.performanceCounter
* remvoing custom and private targets hook and remove unused package rferences
|
|
|
|
tfms (#53244)
* Generate targets files that throw for unsupported NS tfm
For S.D.Common, S.Speech and S.Sec.Crypto.Pkcs we manually added a
targets file to mark the .NETStandard asset as not applicable.
This was done to allow defining a minimum supported .NETCoreApp
version, even though a compatible .NETStandard asset is available.
This commit automatically generates that targets file based on
items.
|
|
|
|
* Glob include files based on project extension (VS)
* Update Directory.Build.targets
* Update Directory.Build.targets
* Update Directory.Build.targets
|
|
(#46447)
* More packaging cleanup
* Add incremental package servicing throughout the repo
* Update dependencies to 6.0.0-beta.20630.3
|
|
* General cleanup and mono import Arcade in root
* More cleanup and coreclr import Arcade root
* Import Arcade root from libraries
* Set informationversion for corelib
* BuildArchitecture cleanup
* Fix property name
* Fix default target invocation of runtime.proj
* specify tfm correctly
* Remove unnecessary TestStrongNameKeyId
* Revert TestStrongNameKeyId removal
* Fix entrypoint target by using M.B.NoTargets
* Fix reference assembly paths
* PR feedback
* Set Platform correctly
* PR feedback and more cleanup
* Move BaselineMicrosoftNetCoreAppPackageVersion
* Fix reference to CoreLib
* Fix OS calculation
* Fix targets importing
* Remove *TargetOS
* Add RuntimeConfiguration doc
* Change conditions in root msbuild files
* installer test fixes
* Cleanup
* More cleanup because of well defined entrypoint
* Don't import D.B.* from installer tests at all
* Rename fix
* Include explicit reference to mscorlib in ilproj
* Update eng/restore/docs.targets
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Revert some installer test changes
* Installer test fix again
* Disable EOL tfm check for installer tests
* Set platform later for installer
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
|
* Consolidate packaging properties
* Remove versions.txt file from packages
The versions.txt file was added to packages to know which SHA a package
was built against. As the nuspec now contains the SHA, the versions file
isn't necessary anymore.
|
|
* Set IsPackable and validate PackageDescription
|
|
repo (#46306)
* Support runtime package descriptions
* Update arcade Packaging pkg
* Inline pkg descriptions for coreclr
* Inline pkg descriptions for mono
* Inline pkg descriptions for installer
* Inline pkg descriptions for libraries
|
|
AOT can now be triggered through the libraries tests as well as the wasm samples.
Passing /p:RunAOTCompilation=true is all that is needed for the libraries test run. The property will be false (for now) by default.
|
|
* automatic version updates
* coreclr projects retargets to net5.0
* Removing manual addition of knownFrameworkReference
* disavling implicit references for sfx projects
* mono changes
* enable package testing
* installer changes
* installer tests ref pack changes
* remove the known framework reference for unit tests
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
* TestInfraTargetFramework -> to net5.0
* set netcoremaxversion property for test utils
* retargeting mono sample apps to net5.0
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
|
|
|
|
* upgrade to net6.0
* add comment and update package version
* address feedback and fix failures
* address feedbacl
* address feedback
|
|
(#40796)
* Disable net analyzers from the SDK and use them from package reference instead
* Fix build with new SDK and bump net analyzer version
* PR Feedback
|
|
Setting LangVersion in a .targets file makes it hard to override LangVersion in individual projects. Instead, move the default project setting back to the .props file and condition VB based on $(MSBuildProjectExtension), which is available in the .props file.
ILCompiler.Reflection.ReadyToRun needs to set LangVersion to 7.3 so it doesn't break ILSpy.
Fix #37498
|
|
* Enable dotnet test
* Update docs
* Use vstest in F5 scenarios
* Make dotnet test without framework switch work
* Code cleanup
* Only run code coverage conditionally
* Fix F5 condition for netcoreapp
* Downgrade sdk to check for helix submission failures
* Fix wrong conditions
* Add blame data collector
|
|
* Remove GeneratedAssemblyInfoFile workaround
The underlying issue is fixed in the SDK.
|
|
|
|
* fixing sourcelink
* enable sourcelink on official build
* addressing feedback
* removing extra space
* reverting eng common change
* adding comment
* moving comment to correct place
* not embedding files for test assemblies
|
|
* Move coreclr managed tools that don't need to be published and System.Private.CoreLib into their own subsets in Subsets.props and drive their builds via Arcade instead of the coreclr scripts.
* Remove building System.Private.CoreLib from build scripts. Eventing sources TBD.
* Build packages via an Arcade subset instead of within build.cmd/build.sh
* Remove packages and test build from build.cmd. Clean up options on build.cmd and build.sh
* Generate eventing sources for System.Private.CoreLib within MSBuild instead of in the build.cmd/sh scripts. Clean up the build.sh usage documentation (lots of copy-paste errors).
* Remove check-definitions.py script and supporting goo.
* Fix eventing generation.
* Wire up TargetArchitecture and OSGroup to coreclr's BuildArch and BuildOS to enable building System.Private.CoreLib for the correct output given the script parameters.
* Stop passing down now non-existent skiptests parameter.
* Fix coreclr .nuget rid parsing to account for linux-musl correctly.
* Update build scripts to use Arcade to build packages.
* Convert from Properties to AdditionalProperties.
* Build crossgen as part of Arcade (self-contained publish TBD).
* Pull down .NET runtime CLI for helix runs with crossgen2.
* Output crossgen2 to the BinDir/crossgen when built from the project file. Enable the test shell scripts to either resolve the dotnet CLI from the path or from relative to Core_Root if the __DotNet variable is undefined.
* Generate distro rid during windows build.
* Various fixes to get files binplaced correctly and builds to work on Linux.
* Fix search for dotnet in repo on bash.
* Remove __BuildTest variable and fix up the script.
* Fix steps in build-job to build S.P.CL before the runtime and build managed tools after the runtime.
* Fix casing typo.
* Refactor detecting system OS and Architecture.
* Fix wasm rid calculation.
* Run crossgen2 on corerun so we run it on the runtime we're going to ship it with.
* Assemble a live self-contained publish in the crossgen2 package.
* Fix init-os-and-arch resolution.
* Ensure that the runtime files we package in crossgen2 are the crossgened ones.
* Remove extraneous /bl
* Build R2RDump to a subfolder instead of the product dir.
* Seperate out the crosssgening corelib step into a separate script.
* Fix permissions on crossgen-corelib.sh
* Rename build.cmd/sh to build-runtime.cmd/sh
* Fix parameters in crossgen2determinism test.
* Run crossgen on System.Private.CoreLib in CI.
* Restore original build.cmd/sh scripts with a deprecation warning and update instructions.
* Initialize developer prompt in crossgen-corelib.cmd script so we can find DIA on CI machines.
* Make sure vs tools are enabled so we can resolve DiaSymReader.
* Call build-native instead of build.
* Fix build-native -> build-runtime.
* Fix permissions.
* Remove dead MSBuild code.
* Factor out python locating targets to make them available to the whole repo.
* PR Feedback/simplification.
* Create a self-contained deps.json for crossgen2 and add it to the package.
* Pass runtimeconfiguration as configuration for crossgen2 deps file generation.
* Try specifying rids directly in crossgen2 project to get the restore correct for the live-build pipeline.
* Run crossgen2 via corerun in R2R.SuperILC.
* Add binlogs to build-runtime.cmd
* Combine non build-runtime steps into a single step so we get one binlog that doesn't get overwritten.
* Add reference to issue describing new workflow.
* Quote python path
* Set arch default.
* PR Feedback and clean up crossgen-corelib's argument list.
* Fix subset name matching to work when one subset name is a substring of another.
* Pass the official build id as an msbuild arg at all times.
Additional cleanup for crossgen-corelib step.
* PR Feedback.
* Fix default subset list construction.
* Add deprecation warnings at beginning and end of build.cmd and build.sh.
* Setup dirs in crossgen-corelib.sh
* Move enforcepgo argument to before the official build arg so that it gets consumed correctly.
* Add cross-os DAC builds as subsets.
Clean up build-runtime parameters and passing the official build ID from runtime.proj.
* Update script usage docs.
* Skip the cross-os dac on x86.
* Build windows->linux cross dac on PR and CI.
* Don't build the cross-OS linux dac on Windows x86.
|
|
* Convert libraries and installer to use a live CoreCLR.
* Installer uses a live libraries build for DLLs.
* Remove newline in path.
* Enable live-live builds to build required live dependencies when the dependencies are in the building subset/subset category.
* Update path to coreclr output.
* Fix typo in coreclr.proj.
* Remove last usage of CoreCLRPDBOverridePath.
* Update path of binplaced runtime to include OS and Arch.
* Fix typo in coreclr/tests/src/Common/Directory.Build.targets.
* Restore CoreFX shared framework from live build for CoreCLR test dependencies.
* Remove dependency on Microsoft.NETCore.CoreCLR.TestDependencies package.
* Enable referencing live builds of the OOB libraries by temporarily adding a new BinplaceConfiguration. Update test_dependencies in the CoreCLR tree to use that to restore OOB libraries.
* Remove reference to System.Drawing.Common from NETClientPrimitives (the reference is only needed at runtime and Core_Root already has System.Drawing.Common).
* Remove package-based checked CoreCLR + CoreFX test runs. In the live-live world, we'll run this test configuration by pointing the CoreFX test host build step at the artifacts from a checked CoreCLR build (possible in both local and CI builds).
* Only copy the UCRT on Windows.
* CoreCLR test build now builds against a live libraries sfx+oob ref assembly set.
* Override GetCorePackagePaths target to not reference unused packages (breaks the live-live build on a clean system).
* Remove live references to Microsoft.NETCore.Platforms now that it seems to be unneeded since the SDK now packages a RID graph. Use the live RID graph in test_runtime.csproj where we may actually be looking for the live RID graph.
* Fix coreclr build arg generation bug that was causing build failures.
* Remove references to Microsoft.NETCore.Platforms outside of package references from the installers.
* Fix problems in installer build in live-live that were found from a clean build.
* Remove unused dependency on Microsoft.NETCore.Targets.
* Fix Microsoft.NETCore.App -> Microsoft.NETCore.Platforms dependency.
* Remove Microsoft.NETCore.Targets version from Versions.props.
* Remove unused deps.csproj file that was the last dependency on the packaged Microsoft.NETCore.Platforms package.
* Fix OSGroup calculation for dependent projects off-Windows.
* Fix construction of Microsoft.NETCore.App.Internal package.
* Remove unneeded CoreRun copying.
* Serialize subsets that have dependencies across subset groups. Don't use `<MSBuild />` tasks to rebuild subsets since we don't want to rebuild projects multiple times (coreclr was being built multiple times).
* Cleanup from PR feedback.
* Only copy libraries outputs to artifacts/bin/runtime.
* Use the netcoreapp output directories for OOB-included references to libraries outputs.
* Remove references to deleted old corefx override setup.
* First pass to get new runtime pipeline using the local live-live infra (coreclr+libraries only for now).
* Don't generate layout during test native build.
* Fix ref assembly default binplacing for netcoreapp.
* Remove msbuild goo around importing Subsets.props and Directory.Build.props only once each. This goo isn't needed anymore.
* Fix disabling of binplacing for the target vertical to exclude only runtime.depproj and not exclude winrt.depproj.
* Fix libraries test build.
* Copy all paths used by the "ResolveLibrariesFromLocalBuild" target to publish from libraries build.
* For shims, reference the System.Private.CoreLib directly from CoreCLR outputs instead of through runtime.depproj.
* Hard-code the libraries configuration to release in coreclr test builds.
* Resolve ReferenceFromRuntime items directly from the CoreCLR output instead of via the runtime.depproj project.
* Fix test host generation. Fix running the XML Serialization generator as part of libraries test build.
* Fix XmlSerializer.Generator.Tests again.
* Don't look for CoreCLR files when using ReferenceFromRuntime and not using netcoreapp.
* Crossgen-comparison should depend on a libraries build so we can populate Core_Root.
* Add job dependency on libraries build from run-test-job to ensure we wait correctly. Otherwise we might have a race since the managed test build might depend on one libraries build while the test run depends on another.
* Only resolve coreclr files from local build when targetting netcoreapp.
* Add steps to download libraries build for crossgen-comparison.
* Revive old method of resolving references to the runtime for building against old netcoreapp (ie netcoreapp 3.0). Fix correctly passing along aliases info.
* Fix failing AllConfigurations leg that was due to the netcoreapp runtime.depproj getting binplaced in the runtime output folder.
* Update eng/liveBuilds.targets
Co-Authored-By: Davis Goodin <dagood@users.noreply.github.com>
* HostArch->BuildArchitecture and share with installer.
* Fix format nits.
* Update YAML variable name.
* Remove setting property to import liveBuilds.targets.
* Upload docs and packages folders from libraries build
* Inclue doc files in the Microsoft.NETCore.App.Internal package
* Try making the runtime-installer pipeline live-live using the build-coreclr-and-libraries-job template.
* Update artifacts download paths and msbuild properties for installer build.
* Mark cross-component files as native.
* Remove FrameworkPackageName to remove error about missing $(FrameworkPackageName).versions.txt file that other shared frameworks also don't generate.
* Restore GetFilesFromPackageResolve override.
* Don't clean the unpack folder for the libraries download. It wipes out the CoreCLR download.
* Make sure that we restore the WinRT targetting pack during the installer build.
* Add libraries package directory to RestoreSources for the case where the LibrariesConfiguration is different from the installer build configuration.
* Don't pass OfficialBuildId unless it is an official build. We want to be consistent with the libraries build so our package versions match.
* Give default value for OfficialBuildArg variable
* Ensure installer tests can see the libraries-generated packages. Fix typo in TargetPath for CoreCLR assets (runtime instead of runtimes).
Fix paths for CoreCLR cross-target files as well as crossgen to place them in the correct directories.
* Add back FrameworkPackageName to get the partial platform manifest to generate.
|
|
* Converge common msbuild properties and targets
Moving common msbuild properties and targets into the repo root.
* Consolidate analyzers logic into the repo root
Consolidating msbuild analyzers logic centrally in the repo root and
adding a property switch `EnableAnalyzers` to enable analyzers. We
still need to import the Analyzers.props file unconditionally as
libraries currently doesn't use the PackageReference logic in ref and
src projects and instead uses a depproj to create a props file
dynamically.
* More cleanup to fix CoreLib build
|
|
|
