Age | Commit message (Collapse) | Author |
|
|
|
* Enable CA1727: Use PascalCase for named placeholders
Also CA2253: Named placeholders should not be numeric values
* Fix MonoProxy logging placeholder names
|
|
lambda expression) (#71011)
As part of updating the config file with recently added rules, also turn on a few of them.
|
|
|
|
|
|
Brings in support for required members
|
|
|
|
|
|
|
|
* Enable IDE0020 (Use pattern matching)
* Update src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationWriter.cs
Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
* Update variable naming
Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
|
|
* Enable IDE0054 (Use compound assignment)
* Update src/libraries/System.Data.Common/src/System/Data/Common/StringStorage.cs
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
Co-authored-by: Tanner Gooding <tagoo@outlook.com>
|
|
|
|
* Enable IDE0029 (Use coalesce expression)
* Address PR feedback and a few missed cases
|
|
|
|
|
|
|
|
|
|
- Delete some now unnecessary pragmas
- Enable the new Dictionary.ContainsKey guard rule
- Address on violation of the new rule
|
|
types) rules (#68268)
* Enable new CA1311 (ToLower/Upper culture) and CA1852 (seal internal/private types)
CA1311 flagged a few issues, all addressed by using ToLowerInvariant/ToUpperInvariant.
CA1852 flagged a bunch that previous cleanups around sealing types missed or that are new since. Sealing types then highlighted places where protected or virtual members were being exposed unnecessarily, so those were fixed, too. Adding sealed to things also highlighted some discrepancies in the order of "unsafe sealed" keywords, where the vast majority in the repo were "sealed unsafe", so I fixed the few that weren't.
* Address PR feedback and fix more CI failures
* Fix unit test build error
|
|
* Remove usage of !! from dotnet/runtime
- Use ArgumentNullException.ThrowIfNull instead where possible. It's only usable for projects that only target .NET 6+, and it can't be used in places like this(...) or base(...).
- In other cases, if the project already has a ThrowHelper, augment it for null as needed and use that.
- For most of the extensions projects, add a ThrowHelper.ThrowIfNull that replicates ArgumentNullException.ThrowIfNull.
- For everything else, just use "throw new".
* Address PR feedback
* Address PR feedback
* Remove false positives from searches
* Address PR feedback
|
|
* Uncomment the user-defined checked operators for generic math
* Change SA1000 to be a suggestion until https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3478 can be resolved
* Regenerating the System.Runtime ref assembly
* Adding tests covering user-defined checked operators in generic math
* Remove the checked() context from integer division, since there is no behavioral difference on .NET
* Ensure the doc comments around user-defined checked operators are uncommented
* Fix some doc comments that shouldn't have been uncommented yet
|
|
|
|
|
|
|
|
* Bump version of C# compiler
This should be reverted when arcade brings in a new enough compiler.
* Fix a few new warnings from updating compiler
* Enable IDE0190 to employ parameter null checking
* Initial roll out of !!
* Fix more compiler warnings from upgrade, plus some test fixes / reverts
* Fix a few more tests
* Disable profiling test
|
|
CA1066/1077) (#63690)
|
|
|
|
* Enable new analyzers in global configs
* Address PR feedback
|
|
|
|
|
|
* Turn on DetectPreviewFeaturesAnalyzer and runtime changes
* Missed decimal
* Add comments and update S.Runtime.csproj
* sq
* sq
|
|
(#57144)
|