| Age | Commit message (Collapse) | Author |
|---|
|
* Update dependencies from https://github.com/dotnet/linker build 20220804.4
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22404.4
* Update dependencies from https://github.com/dotnet/linker build 20220804.5
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22404.5
* Update dependencies from https://github.com/dotnet/linker build 20220805.1
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22405.1
* Update dependencies from https://github.com/dotnet/linker build 20220808.3
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22408.3
* Update dependencies from https://github.com/dotnet/linker build 20220809.9
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22409.9
* Added and modified suppressions
* Disable IL2121 everywhere for now
* Disable IL2121 in trimming tests
* Disable IL2121 in wam samples
* Disable IL2121 in libraries tests
* Update dependencies from https://github.com/dotnet/linker build 20220811.2
Microsoft.NET.ILLink.Tasks
From Version 7.0.100-1.22377.1 -> To Version 7.0.100-1.22411.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Jeremi Kurdek <jkurdek@gmail.com>
Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com>
Co-authored-by: Sven Boemer <sbomer@gmail.com>
|
|
* Remove hardcoded non trimmable assemblies in oob.proj
Fixes https://github.com/dotnet/runtime/issues/72166
Use the `TargetPathWithTargetPlatformMoniker` to flow through the IsTrimmable property that is set by projects and use that for illink validation assembly selection.
* Update oob.proj
* Update illink.targets
|
|
* Run illink before ApiCompat and GenAPI
As observed in https://github.com/dotnet/runtime/issues/66634#issuecomment-1068556981, illink currently runs after APICompat. This happens because nuget imports the ApiCompat targets earlier than the illink.targets is imported.
* Update illink.targets
* Use ApiCompatDependsOn
|
|
* Use SDK logic for IsTrimmable
* Address some analyzer warnings
* Disable analyzer when baseline suppressions exist
* Don't mark unannotated test project as trimmable
* Add nativeaot annotations
* Add suppression in windows-only code
* Import illink.targets only when trimming mobile tests
* Don't run analyzer on unannotated windows OOBs
* PR feedback
Use pragma instead of UnconditionalSuppressMessage
|
|
Split the build of shared framework and out-of-band projects so that
it's possible to just build the shard framework projects, which was
requested by the CLR teams. In the next infrastructure rollout, the
current "libs.ref+libs.src" subsets should be removed. Generate the
targeting pack with an incomplete (without shims) frameworklist as part
of the "libs.sfx" subset.
Build the shim projects after the shared framework and oob projects and
re-generate the targeting pack's frameworklist to include the shims.
Refactor the shims so that they aren't grouped anymore by generated &
manual. Instead group them by "ref" and "src" same as other libraries
in the tree which allows to reference the source project shims and read
from the ReferenceAssembly metadata.
Use ProjectReferences in traversal projects and shim projects instead
of named references that point to binplace directories (see graph below)
This allows to build parts of the product dynamically, i.e. the shim
projects, apicompat.proj, sfx.proj and oob.proj.
|
|
That target still gets executed but as `ILLinkTrimAssembly` doesn't get set anymore by binplacing and instead in the libs's Directory.Build.targets file, it doesn't serve a purpose anymore.
|
|
* Consume renamed TargetFramework package
* Rename CoreLibs generator parent dir
Projects under src/libraries/ which are located under a "gen" directory
are automatically treated as source generator projects. Because the
CoreLib generator was placed under a different directory "generators",
it was treated as a RuntimeAssembly which gets binplaced into the
runtime path. The runtime tests then take the assemblies from there and
copy them into their CORE_ROOT directory.
Renaming the CoreLib source generators parent directory fixes that so
that it is treated as source generator and it brings consistency into
src/libraries.
|
|
System.Linq.Expressions currently offers multiple build time definitions to build different flavors of the library:
* `FEATURE_COMPILE` (defined everywhere except iOS/tvOS/Catalyst, and NativeAOT) - enables Reflection.Emit-based expression tree compiler.
* `FEATURE_INTERPRET` (always defined and not actually possible to build without) - enables the expression interpreter
* `FEATURE_DLG_INVOKE` (defined everywhere except NativeAOT, but we likely need to be able to run without it on iOS too because there's uninvestigated bugs around it ActiveIssue'd in #54970) - in the interpreter, use a delegate to invoke `CallInstructions` instead of `MethodInfo.Invoke`. The delegate might have to be Reflection.Emitted if it's not supportable with `Func`/`Action` (that's the uninvestigated iOS/tvOS/Catalyst bug).
For #61231, we need to be able to build a single System.Linq.Expression library that can switch between these build-time configurations _at publish time_ since we don't want to build a separate S.L.Expressions library for NativeAOT. There are advantages in having this setup for non-NativeAOT scenarios too. This pull request accomplishes that by mechanically changing the `#define`s into feature switches.
The feature switch is placed in the last proposed location for https://github.com/dotnet/runtime/issues/17973. I expect we'll want such API to be public at some point; now that Xamarin and NativeAOT use this formerly .NET Native-only thing the API request became relevant again.
This pull request is focused on the mechanical replacement of `#defines` with feature switches and it's already a lot bigger than I'm comfortable with.
There's some obvious "`!FEATURE_COMPILE` means this is .NET Native with everything what that meant" that I did not touch because this is meant to be a mechanical change. Some cleanup will be needed at some point. Right now this just mostly means we're running fewer tests than we could.
Validation:
* Verified that we're still running the same number of tests with CoreCLR as we previously were and they're all passing.
* Verified we're getting mostly the same size of the S.L.Expressions library on iOS (433 kB grew to 436 kB, the diffs are expected).
* Verified things work on the NativeAOT side as well.
|
|
* Stop reading TargetFramework prop in props files
The TargetFramework property isn't expected to be set in props files
before a project's body is evaluated.
Don't let BuildTargetFramework property fallback to TargetFramework as
BTF's sole intent is to convey the TargetFramework to filter to and not
the current selected TargetFramework. Reduce usage of BTF so that it is
only used in places where code is actually conditioned on filtering.
In addition to that, specify BuildTargetFramework as a global property for
all traversal builds so when invoking one of the traversal projects directly
(src.proj, ref.proj, etc.), BuildTargetFramework doesn't need to specified
manually to get the default behavior (filter on compatible to net6.0).
Remove the inferred BuildingNetCoreAppVertical because of that and
inline its meaning.
Make sendtohelix a normal NoTargets proj so that it has access to the
properties which were moved into the Directory.Build.targets file as
otherwise it wouldn't import that file.
|
|
the Linker (#52272)
* Adding infrastructure to run the linker on OOB Assemblies manually
* Refactoring to abstract shared infrastructure
* Add OOB ignore list
* Address PR comments
* Rename properties so they don't intentionally get reused
* Addressing PR Feedback
* Addressing PR Feedback
|
|
* Rename ILLinkTrim files to ILLink.Descriptors.
Fix #37651
|
|
This suppression is necessary because we don't have access to the Xamarin and Mono libraries that are used by System.Net.Http.
Contributes to #45623
|
|
[master] Update dependencies from mono/linker
- Update linker arguments
- Remove non needed arguments
|
|
SDK to 6.0 (#48462)
* Remove duplicated ILLink PackageReference
The Arcade.SDK already package refrences the ILLink package. The
duplicate reference in illink.targets caused SDK errors as the Arcade
reference has IsImplicitlyDefined set which doesn't allow an additional
reference with the same identity.
Also, as the ILLink package already exposes the path to the assembly via
its props file, using that instead of manually constructing the path to
the assembly.
The SDK target version update is required as the sequencing of the
ILLink.props file was wrong and is required for this change. This isn't
considered a breaking change, as the SDK's minimum required version
isn't changed.
* Update arcade dependencies
* Remove NuGet pack tasks pkgref
* Add mega hack workaround
* Remove KnownFrameworkReference items
* Don't hardcode SDK value in helix submission...
* Update runtimeConfiguration.targets
* Fix double publishing error in mobile tests
* Set DotNetCliVersion to right version for aspnetcoreruntime
* Update sendtohelixhelp.proj
* Update sendtohelixhelp.proj
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
|
|
* Resolve ILLink warnings in System.Linq.Queryable
Contributes to #45623
* Respond to PR feedback.
Annotate public AsQueryable() method as RequiresUnreferencedCode.
|
|
|
|
|
|
[master] Update dependencies from mono/linker
- Reflect linker changes
- Reflect linker changes
- Reflect linker changes
- Merge branch 'darc-master-cda9432a-2250-4c6f-822a-6016b38faef1' of github.com:dotnet/runtime into darc-master-cda9432a-2250-4c6f-822a-6016b38faef1
- fix msbuild logic
|
|
* Update dependencies from https://github.com/mono/linker build 20201105.1
Microsoft.NET.ILLink.Tasks
From Version 6.0.0-alpha.1.20527.2 -> To Version 6.0.0-alpha.1.20555.1
* Update dependencies from https://github.com/mono/linker build 20201105.2
Microsoft.NET.ILLink.Tasks
From Version 6.0.0-alpha.1.20527.2 -> To Version 6.0.0-alpha.1.20555.2
* Disable new optimization for libraries mode (it cannot work in this mode)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Marek Safar <marek.safar@gmail.com>
|
|
of the sdk for platform specific tfms. (#43651)
* eng change
* coreclr change
* libraries change
* tests change
* installer & mono change
* py files changed
* .md change
* .yml change
* remove redundant targetos property
* Windows_NT -> windows after ninja change
* fixing runtime build failure
|
|
* Add granular suppressions for linker warnings
* Add suppressions for mono SPC
* Misc additions
* Add suppressions for Debug config
* Fix Android xml file
* Include System.ComponentModel.Annotations suppressions
* Add suppressions for System.Security.Cryptography.X509Certificates on Linux
* Fix TargetOs exists check
* Add IL2077 to System.Security.Cryptography.X509Certificates on Android
* Generalize some System.Security.Cryptography.X509Certificates suppressions to 'NonWindows'
* Remove ref to catch-all System.Security.Cryptography.X509Certificates file
* Misc clean up and some feedback
* Use ILLinkDirectory in CreateRuntimeRootILLinkDescriptorFile.targets
* Update paths for directories
* Set TargetPath as part of include
* Delete bin-placing TODO
* Include more xml files during per-library run
* Include more xml files during per-library run, pt 2
* Include more xml files during per-library run, pt 3
* Try including System.ComponentModel.Annotations based on BuildingNETCoreAppVertical
* Switch to BuildAllConfigurations
* Include xml extension in file paths
* Remove version number from assembly suppression files
* Delete ILLink.Suppressions.xml
* Try removing IL2035 nowarn
* Remove version from Microsoft.VisualBasic.Core assemly name
|
|
* Fix illink invocation inside VS
Fixes https://github.com/dotnet/runtime/issues/42676
* Update illink-sharedframework.targets
|
|
Microsoft/vstest dotnet/llvm-project dotnet/icu (#42201)
[master] Update dependencies from dotnet/xharness mono/linker dotnet/arcade Microsoft/vstest dotnet/llvm-project dotnet/icu
- Merge branch 'master' into darc-master-c2f56120-c0a9-49ac-83ec-d0550f2e6a36
- Fix merge conflict
- Revert override of local changes to send-to-helix.yml
- Fix path to ILLink.Tasks.dll
- Revert override of local changes to send-to-helix.yml
- Revert override of local changes to send-to-helix.yml
- Fix path to ILLink.Tasks.dll
- Fix another path to ILLink.Tasks.dll
|
|
* Update linker warning numbers
In response to https://github.com/mono/linker/pull/1385.
This replaces the global suppressions for IL2006 with the warnings that it was split into.
* Add suppressions for linker tests
|
|
|
|
* Add step to run linker on entire runtime pack during libraries build
* Address feedback
* Only run for NetCoreAppCurrent
* Include appropriate S.P.CoreLib
* Address review feedback
* Add common property group for shared linker args; remove unneeded changes from PR
* Rename illink-sharedframeworks.targets to illink-sharedframework.targets
* Address review feedback
|
|
* Enable verbose linker output and bulk-suppress warnings
* Suppress ILLinker warnings for now, so ILLinker can enable warnings by default
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
|
|
- Remove depprojs which currently binplace external references into the RefPath folders in favor of PackageReference and PackageDownload items.
- Build all configurations by default when building an individual project (either on the CLI or inside VS) same as with the official SDK. This enables .NETFramework Test Explorer support.
- Centrally define libraries that compose the shared framework instead of in each Directory.Build.props file to be able to build the targeting pack first and consume it in the OOB libraries.
- Use ProjectReferences to reference OOB projects. Compile against the reference assembly but use the implementation assembly app-local during runtime.
- Remove OOBs from the testhost and remove the testhost folder for .NETFramework as it isn't required anymore.
- Only binplace for $(NetCoreAppCurrent) to compose a) the targeting pack, b) the runtime pack, c) the testhost, d) a full closure for the shims.
- Use Targeting Packs for OOB projects (with their implicit assembly references) but still explicitly define granular references for .NETCoreApp configurations (DisableImplicitAssemblyReferences switch). Use the implicit targeting pack references in some Microsoft.Extensions.* cases.
- Remove placeholder configurations as they aren't needed anymore with explicit P2Ps vs Targeting Pack references.
- Remove implicit assembly references (ie for .NETFramework, mscorlib)
- Remove AssemblySearchPath hacks that were introduced with b7c4cb7 as the targeting pack is now used by default.
- Reduce unnecessary .NETFramework configurations that were added to run tests in favor of the already existing ref&src configurations.
- Stop hardcoding the paths for wasm assemblies and use the returned TargetPath of the ProjectReferences.
- Addressed formatting (ItemGroups, References at the bottom of the project file, ordering of references, use LibrariesProjectRoot instead of a relative path, unnecessary AssemblyName and RootNamespace properties which are identical to the project name, ordering of tfms)
- Revert "fix clean (#33758)"
|
|
* WASM: fix System.Runtime.Tests
* Enable System.Runtime.Tests
* Disable test and don't strip link attributes on all product assemblies
* PR feedback
|
|
dotnet/icu (#39158)
* Update dependencies from https://github.com/mono/linker build 20200711.1
Microsoft.NET.ILLink.Tasks
From Version 5.0.0-preview.3.20360.3 -> To Version 5.0.0-preview.3.20361.1
* Update dependencies from https://github.com/dotnet/runtime-assets build 20200710.1
System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
From Version 5.0.0-beta.20319.2 -> To Version 5.0.0-beta.20360.1
* Update dependencies from https://github.com/dotnet/icu build 20200709.7
Microsoft.NETCore.Runtime.ICU.Transport
From Version 5.0.0-preview.8.20359.5 -> To Version 5.0.0-preview.8.20359.7
* Remove unsupported option
* Bump SDK dependency to bring updated ILLink task
* Update trimmer configuration property names
* Keep debug symbols as they are needed for the tests
* Disable trimming tests on Windows due to weird pdbs handling
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Marek Safar <marek.safar@gmail.com>
|
|
* Add always trimmed attributes list for browser config
Example of size reduction on SPC with the most minimalistic Hello
World sample.
| System.Private.CoreLib | Size (kB) | Delta |
|-|-|-|
| Original | 1358 kB | - |
| Trimmed | 1271 kB | - 87 kB |
* Review feedback
* Combine and embed the ILLink.LinkAttributes.xml file into the assembly.
* Update linker command line to ignore attributes file.
Add ExcludeFromCodeCoverageAttribute.
* PR feedback.
Add note about Obsolete.
Only use assembly fullname="*" for compiler generated attributes.
* Update ILLink.LinkAttributes.wasm.xml
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
|
|
feature switch is present (#38397)
* Adding generation of substitution files for trimming out resources when feature switch is present
* Adding support for CoreLib as well and fix issue with SR returning empty string
* Cache result of AppContext Switch lookup
* Fixing allConfigurations leg and addressing feedback
* Fixing thread safety issue by removing caching
* Addressing feedback
* Apply suggestions from code review
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Addressing feedback and adding tests
* Fix typo
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
|
This reduces the duplication between these libraries, and allows for easier maintenance going forward.
Fix #37255
|
|
* Use DynamicDependencyAttribute
* PR feedback
- Use typeof in more places
- Add comments about DynamicallyAccessedMembers
- Add comments about cases where we work around linker limitations
- Also move AssemblyBuilder`s DynamicDependency closer to where it
is actually needed.
* Add issue links
* Include internal attribute for OOB packages
On down-level platforms where DynamicDependencyAttribute doesn't exist
in corelib, this includes it in the OOB assemblies.
|
|
* Use [SkipLocalsInit] & remove code for ILLink to strip locals init
* Address review feedback
* Simply condition
* Clean up
* Fix condition
|
|
* Add build support for ILLink.Substitutions.xml files
These files enable the ILLinker to dynamically replace method bodies at link-time.
There are two ways of embedding the file:
- By making a single ILLink.Substitutions.xml file next to the .csproj
- By adding one or more files to the @(ILLinkSubstitutionsXmls) MSBuild item. This allows for libraries, like CoreLib, to have a shared substitutions file and also separate substitutions files for each RID - x64, wasm, etc - which all get combined into a single file during the build.
|
|
See https://github.com/mono/linker/pull/1237.
Setting the boolean ClearInitLocals is sufficient here because we are
only linking the target assembly. If in the future we need to control
it per-assembly, we can use metadata on AssemblyPaths:
https://github.com/mono/linker/blob/master/src/ILLink.Tasks/LinkTask.cs#L23
|
|
* Strip the ILLinkTrim.xml file from System.Private.Xml
The two methods being preserved in System.Private.Xml (CreateSqlReader and GenerateSerializer) are large, and are not necessary when linking a mobile app. These methods only need to be preserved when linking the shared framework. When a normal app is linked, the linker is able to figure out if the two methods are necessary.
Contributes to #35199
Fix #30912
* Respond to PR feedback
- Add PreserveDependencyAttribute to SqlXml to be explicit.
- Rename ILLinkTrim.xml to ILLinkTrim_LibraryBuild.xml when it shouldn't be embedded in the resulting assembly.
|
|
|
|
|
|
- Use RestoreUseStaticGraphEvaluation which improves no-op restore by 10-15x down to 10-20 seconds.
- .builds msbuild files renamed to .proj as RestoreUseStaticGraphEvaluation throws for non .proj files without an env var set.
- Introducing subsets for libraries and mono and replacing -buildtests switch which was only working for libraries in favor of the subset switch -subset tests which works consistently.
- Fixing the Microsoft.DotNet.CodeAnalysis analyzer which wasn't running and adding missing exclusions.
- Separating restore and build phases in different parts in the repo (ie for installer.tasks) as generated props and targets need to be imported which requires a reevaluation in the build phase.
- Fix eng/docker/build-docker-sdk.ps1 by using the official build entrypoints (cc @alnikola)
- Remove a few depprojs in favor of project restore (faster restore :))
- Fix root code coverage measurement not working correctly
- Traversal support instead of dir.traversal.targets or manual build target defines.
- Introduce a root Build.proj entrypoint which is responsible for building and restoring the repository. This is necessary to enable the new NuGet fast restore which works best and fastest with a single entrypoint.
- Avoid binclashes in libraries and between libraries and installer (netstandard.depproj vs netstandard.csproj)
- Upgrading the SDK to 5.0 latest
- Code cleanup
|
|
|
|
* build config and update docs
* remove configurationGroup and update docs
* addressing feedback
* viktor comments
|
|
* Revert "Revert "Update ILLinkTasksVersion dependency (#2334)" (#31807)"
This reverts commit 334391bdc9d4e9e20ea8b8a19ec5788da680b850.
* Update ILLink version
* Update ILLink task netcore execution version
* Another version update
|
|
* libraries -restore for vertical build without test restore
* Automatic test change and regex to remove the addition of an extra line at eof
* manual test restore fixed (restore completely done for vertical build)
* build native done
* Automatic ref change and regex to remove the last line
* manual reference assebly change and generated shims build
* automatic src change and regex
* native bin place and src build manual change
* apicompat and pretest.csproj done
* fixing the package build
* fixing all config
* packaging and feedback
* adding back placeholder configuration
* fixing the shims
* delete configuration.props
* making the build work in master
* Test Change
* fixing the packageing, test restore replacing TargetFramework -> OriginalTargetFramework
* delete test configuraiton.props, trailing semicolon and use targetFramework
* reverting the package change
* enable apicompat and fixing configurationGroup for individual projects
* fixing the api compat
* making ilproj work
* adding the outerBuildTest
* adding the arcade package version
* fixing the merge conflicts
* minor changes
* adding additional configs and setting the runtimeOS
* making the vs stuff work
* removing the target Group to fix the apicompat
* fixing the linux build and some minor changes
* making additionalBuildTargetFramework LOcalProperty
* fixing the allConfigurations build
* fixing the netfx build
* fixing package Testing and restore
* Missing TargetFrameworks tag
* making the VSdesgin stuff work
* Remove OriginalFramework Entirely
* some minor pr feedback
* RemoveExtraSemicolon
* use boolean exclude flag
* fixing yml scripts to pass tests
* adding comments and some minor feedback
* moving packaging property to correct plave
* fixing the build for web assembly
* Fixing the live ci build
* Fixing the live build for shims
* fixing the tests
* fixing the packaging and enterprise linux
* fixing package sizes
* Fix the targetFramework
* updating the targetFramework sdl
* removing the buildOS and be able to use OSGroup as done in the old system
* Fixing the osgroup stuff for send to helix task
* Fix OSX failures
* Fixing the osx build
* uploading tmp folder to artifacts
* running restore for runtime.deproj correctly
|
|
This reverts commit a05c599e0c9ba113902ba59746e041f1513cc339.
|
|
|
|
* netcoreapp -> netcoreapp5.0 in .sln files
* netcoreapp; -> netcoreapp5.0; , netcoreapp- to netcoreapp5.0-
* netcoreapp- -> netcoreapp5.0 in .csproj
* 'netcoreapp -> 'netcoreapp5.0 in .csproj
* done with libraries sub folder
* missed semicolon
* minor changes
* netcoreapp -> netcoreapp5.0 in some extra files
* vNext target variable in configurations.props
* netcoreapp => netcoreapp5/0 in some other .props file
* netcoreapp -> vnext in .csproj
* making the netcorepap framework switch work
* fixing sendToHelix and linux build
* TargetFrameworkVNext -> netcoreappCurrent
* case correct netcoreappcurrent
* fixing send to helix zip path
* netfx -> net472 in .sln
* netfx; -> net472; in .props
* netfx- -> net472- in .props
* netfx - -> net472- in .csproj
* 'netfx-> 'net472 in .csproj
* netfx -> net472 manual change
* fixing ci build for netfx
* Not trying to change the global property
* Fixing build failure due to master changes in net https tests
* adding documentaiton and fixing filtering
* netcoreapp -> netcore5.0 in py file
* changing the path to use netcoreapp5.0 version
* feedback and override corefx path corrected in installers
* remaing netcoreapp5.0 changes done
* netcoreapp-> netcoreapp5.0 after live builds
* net472 -> netframeworkcurrent
|
|
* Converge common msbuild properties and targets
Moving common msbuild properties and targets into the repo root.
* Consolidate analyzers logic into the repo root
Consolidating msbuild analyzers logic centrally in the repo root and
adding a property switch `EnableAnalyzers` to enable analyzers. We
still need to import the Analyzers.props file unconditionally as
libraries currently doesn't use the PackageReference logic in ref and
src projects and instead uses a depproj to create a props file
dynamically.
* More cleanup to fix CoreLib build
|
|
(dotnet/corefx#42491)
Commit migrated from https://github.com/dotnet/corefx/commit/ab01852685e659a685af2ace33af5b3cefdf8430
|
