Age | Commit message (Collapse) | Author |
|
clauses (#73032)" (#73551)
This reverts commit 4c07f3dbe5a439e5c6ac66fd14c4fed51aa819ce. We believe it is causing recent CI failures.
See #73247
|
|
* Disambiguate calli thunks based on full calling conventions
Fixes dotnet/runtimelab#153
* Add smoke test
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
|
|
(#73032)
|
|
|
|
As part of Control Flow Enforcement Technology (CET) testing we need
to make sure that CET is actually active on the execution machines;
otherwise subtle infra changes could easily regress the testing by
inadvertently deactivating CET without anyone noticing. This change
introduces an initial CET availability test for this purpose.
Thanks
Tomas
|
|
|
|
* Fix typos
* Cleanup trailing whitespaces in committed files
* Revert a macro for win32 compat
* Disambiguate test data method
* Revert XMLPath test which rely on external assets
* Revert whitespace change in Xml tests
* Revert ClrEtwAl and ILLink.Shared
* Revert crossgen2 props/targets and *.wxl
|
|
Windows + CoreCLR. (#70110)
|
|
* Remove enum_flag_Unrestored usage in boxing stubs.
* Add AND instruction (21h) to x86 decoder.
* Update mono for null ref in interpreter paths.
* Disable test on llvmfullaot and wasm
* Handle null destination for intrinsics.
|
|
* Fix typos
* Fix typo: seperate -> separate
* Rename ApplicationNameSetFromArgument
* Update src/coreclr/vm/methodtablebuilder.cpp
* Update docs/coding-guidelines/clr-code-guide.md
Co-authored-by: Dan Moseley <danmose@microsoft.com>
* Update src/mono/mono/tests/verifier/make_tests.sh
Co-authored-by: Dan Moseley <danmose@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
|
|
|
|
|
(#67393)
* Move copying of merged wrapper native components to copynative step
* Move export of test exclusion file before ILLink changing CORE_ROOT
* Fix file mode for test execution bash scripts
* Add out-of-proc test folders to Helix work item payloads
* Fix Helix publishing in the presence of out-of-process tests
* Use a marker file triggered off of a project property to determine which files to skip running the Mono AOT compiler on (some tests fail at AOT time, so we need this to work around that limitation)
* Pass runtimeVariant to the Core_Root construction for the test exclusion list creation
* Don't write the output element when there's no test output. This causes issues with Helix test uploading.
* Write xunit results the way xharness expects to read them for wasm so we correctly report failures and don't report a test harness failure.
* Fix GeneratedTestRunner to build.
* Fix copying native wrappers for merged test runners.
Pre-emptively mark another test as RequiresProcessIsolation as I stumbled upon it while fixing this
* Fix copying of native test components to merged wrapper outputs
Due to Pri0 / Pri1 test grouping we may end up building the
wrapper in a different group than its components. Make sure that
we populate all native components of merged wrapper dependencies
before we copy them over to the merged wrapper output folder.
* Exclude wasm support files.
Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
|
|
|
|
* Fix some exception messages for BindHandle-like cases
- Updated `ThrowHelper.ThrowApplicationException` to get and include an error message
- Enabled the disabled tests, disabled a `BindHandle` test on Unixes where it now throws `PNSE` before `ArgumentNullException`
Fixes https://github.com/dotnet/runtime/issues/66273
Fixes https://github.com/dotnet/runtime/issues/66274
|
|
* Use CMakeProjectReference instead of ProjectReference
Changing this permits usage of "\runtime\dotnet.cmd build" as opposed
to forcing users to use "\runtime\dotnet.cmd msbuild".
|
|
Sometimes a process failing with stack overflow returns exit code
0x800703e9 (ERROR_STACK_OVERFLOW). This change updates the stack
overflow test to accept that code too.
|
|
|
|
(#62158)
* Ensure all types are loaded when methods are accessed as function pointers.
* Fix issues with Type punning with Type Equivalence.
* Add support for Generic instantiation over Canon for type punning.
|
|
Add tests for the scenario.
|
|
* Remove CLRTestExecutionArguments from OOMException01
Test entrypoint is parameterless and so it ignores the argument
* The test entrypoint for 347011 is parameterless so the property is ignored
* Remove project-driven command line arguments from the polyrec test
The test just passes a pair of integers that are used as internal
parameters for the test. Refactor the test so that the entrypoint
accepts the parameters as arguments and call it once from Main
the way we used to do based on the CLRTestExecutionArguments.
Thanks
Tomas
|
|
|
|
|
|
Previously the Directory.Build.targets script used to automatically
infer that OutputType=Library without a CLRTestKind implies
SharedLibrary. This is however hard to consolidate with the planned
test merging - as the SDK script set OutputType=Library by default,
we need the combination Library+(implicit)BuildAndRun to indicate
the "new-style" [Fact]-based tests. For this reason I propose to
remove this automatic inference and manually fix the handful of tests
that are missing an explicit CLRTestKind=SharedLibrary property.
In light of this description we can theoretically remove the
OutputType=Library specification from all test projects but even if
we decide to do that, I believe it will be easier to do that as a
separate mechanical change, not as part of this relatively small
change that has a different purpose. Additionally in the one case
of the GitHub_22583 regression test, I removed the explicit setting
of GenerateRunScript=false because that's the default.
Fix OutputType=exe in OpenDelegate.csproj
I believe this was a pre-existing bug - previously, with the
special clause regarding SharedLibrary, the test just got silently
skipped because it was considered to be a shared library.
Thanks
Tomas
|
|
|
|
(#61226)
Asserts not provided by Xunit are provided by an AssertExtensions class.
Tests that reference System.Private.Corelib directly will use a polyfill implementation based off the old CoreCLRTestLibrary asserts.
All assert methods provided by CoreCLRTestLibrary have been changed to follow Xunit conventions.
|
|
|
|
(#59073)
* Remove some redundant threading tests, move some cases to libraries tests
- Went through some of the tests. Most of them appeared to be redundant. Added a few missing tests and ported a few tests from CoreRT.
- Closes https://github.com/dotnet/runtime/issues/6372, the test is being removed
|
|
* CLRTestPriority of zero is the default, so don't specify it in test project files
* Remove default CLRTestKind of BuildAndRun from test project files
|
|
[unix x86] Fix tests build
[unix x86] Add register map for crossgen2
Fixes readytorun/coreroot_determinism/coreroot_determinism/coreroot_determinism.sh on x86 linux
[unix x86] Fix tail calls tests
[unix x86] Fix unmanaged callconv
[unix x86] Fix passing implicit args via stack
[unix x86] Pop hidden retbuff arg on cdecl callconv
[unix x86] Fix WriteBarrier call
[x86] Add calling convention name print to dump
[x86] Use ebx to pass VASigCookie to GenericPInvokeCalliHelper
It fixes stack alignment in GenericPInvokeCalliHelper on unix x86
Fix storageType overflow assertion in TinyArray
|
|
- Also enabled the test for GCStress to try it again. The test seems to take a decent amount of time on my machine, and with the machine busy it could take longer but it should finish in reasonable time.
- Closes https://github.com/dotnet/runtime/issues/13453
|
|
|
|
other threads (#57008)
* MonitorEnter test needs to handle the case of the threadpool cleaning up other threads
- On rare gcstress test occasions there can a thread freed after allocating the 1024 threads but before the highThread is allocated
* Fix comment
|
|
|
|
- take advantage of the AlwaysUseCrossGen2 flag instead of manually updating all the crossgen commands
- remove version bubbles test. We have much more complex testing for that scenario now
- remove regular crossgen logic from the script generator
|
|
Tracking: https://github.com/dotnet/runtime/issues/54203
|
|
* [interp] Fix loading of ThreadStatic value types
* Add runtime test for ThreadStatic valuetype access
|
|
* excluding crossgen from build.
* Fix cross-component build break
* Fix tests to not use crossgen
* more test fixes.
* switching R2R jobs to use cg2 by default
* switch helix runs to use crossgen2
|
|
* Fix assertion failure / crash in multi-core JIT
- When the recorder times out it doesn't actually stop profiling, but writes out the profile
- The app may later stop profiling, and then it tries to write the profile again
- PR https://github.com/dotnet/runtime/pull/48326 fairly expected that the profile is only written once (some state is mutated)
- The non-timeout stop-profile path was also not stopping the timer
- Fix for https://github.com/dotnet/runtime/issues/53014 in main
|
|
* Use OperatingSystem APIs instead of RuntimeInformation in more places
These are recommended instead of the older APIs.
* PR feedback
|
|
* Fix SYSLIB obsoletion warnings in tests
* Simplify references to assembly location
|
|
* Modify TC to compare strings before ':'
In order to avoid failure due to modification of #44013,
the TC has been modified so that the content after':' is not compared.
* Enable OOMException01
Failed TC is fixed at #51280
|
|
|
|
|
|
(#50676)
* Both referenced issues have been closed.
* Other tests that are disable with closed issue.
|
|
This test currently fails under many gcstress legs.
Tracking issue: https://github.com/dotnet/runtime/issues/46279
|
|
Co-authored-by: kronic <kronic@softland.ru>
|
|
|
|
Based on local instrumentation I introduced while investigating
issues related to the switch-over to compile System.Private.CoreLib
using Crossgen2 I'm proposing to harden fatal exception handling
against nested and concurrent fatal error occurrences.
Thanks
Tomas
|
|
* Prototype for runtime tests running with Android
* Conditionally collect app dependencies
* Switch android sample from publish to build
* Switch Android sample from publish to build
* Modify AndroidTestRunner
* Only build and test one test
* Clean up some changes
* Update new run test script path and update AndroidTestRunner to use files under CoreRoot
* Add Helix configuration for Android_x64
* Disable test which replies on coreclr System.Private.CoreLib.dll
* Fixed format and removed irrelevant parameters
* Rmoved unused parameters and fixed comment
* Revert my AndroidAppBuilder related changes to prepare for getting Egor's AndroidAppBuilder change
* Fixed rebase and merge error
* Update AndroidTestRunner
* Use the AndroidAppBuilder in the publish folder
* Update runtime test Android App creation command
* Temporarily disable all jobs except for the Android one
* Fix up job running config
* Fixed AndroidTestRunner
* Get Main function return code after running android app
* Fix for skipping building native tests
* Fix helix project path, due to recent coreclr test related files relocation.
* Fix android app running commands
* Add missing helixType
* Update HelixRuntimeRid
* Fix inconsistency
* Create Android app during build preiod.
* Adjust the way to run tests
* Temporary hack before AndroidAppBuilder could accept multiple assemblies
* Use xharness instead of adb to run tests on Androids and disable cmake for Android.
* Cleanup unnecessary changes
* Include xharness Cli
* Use the right xharness command
* Copy runtime assemblies, since the copy logic got removed from AndroidAppBuilder
* Save Android apps in CORE_ROOT dir and adjust BuildAndroidApp target due to rebase from master
* Minor cleanup
* Enable all runtime tests and disable tests caused build failure
* Copy over test helper assemblies and add failing tests to issues.targets
* Remove redundant comment
* Revert previous commit
* Only sending apk files to helix machine
* Delete OutputDir after finishing building the app
* Copy whole Core_Root dir to helix machine.
* Extend timeout threshold
* Extend timeout threshold for each test and each test collection
* Display Android app running logs when tests fail
* Android tests are required to run in sequential
* Check if log file exists before using it.
* Exclude two out-of-memory tests
* Fixed merge error
* Shorten the timeout threshold
* Enable all the lanes
* Fix indentation
* Fixed a few issues from review feedback
* Update src/tests/run.proj
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
* Only bail out from the bash script when erroring out for andriod
* Extend timeout threshold, since the run could take a long time or a short time on CI.
* Fixed merge error
* Filter out tests using more memory than allowed by helix machine
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
|