Mark fields that don't need to be reassigned as readonly.

This makes it explicit at compile-time that these fields should not be
reassigned outside the constructor.

2 files changed, 10 insertions, 10 deletions

diff --git a/Duplicati/GUI/Duplicati.GUI.TrayIcon/GtkRunner.cs b/Duplicati/GUI/Duplicati.GUI.TrayIcon/GtkRunner.cs
index 2d6295958..2ec57649f 100644
--- a/Duplicati/GUI/Duplicati.GUI.TrayIcon/GtkRunner.cs
+++ b/Duplicati/GUI/Duplicati.GUI.TrayIcon/GtkRunner.cs
@@ -25,7 +25,7 @@ namespace Duplicati.GUI.TrayIcon
 {

     public class GtkRunner : TrayIconBase

     {

-        private static string m_svgfolder;

+        private static readonly string m_svgfolder;

 

         /// <summary>

         /// Static constructor that ensures the Gtk environment is initialized

@@ -46,9 +46,9 @@ namespace Duplicati.GUI.TrayIcon
         

         private class MenuItemWrapper : IMenuItem

         {

-            private MenuItem m_item;

-            private System.Action m_callback;

-            private static Dictionary<MenuIcons, Gtk.Image> _icons = new Dictionary<MenuIcons, Gtk.Image>();

+            private readonly MenuItem m_item;

+            private readonly System.Action m_callback;

+            private static readonly Dictionary<MenuIcons, Gtk.Image> _icons = new Dictionary<MenuIcons, Gtk.Image>();

             

             public MenuItem MenuItem { get { return m_item; } }

 

@@ -164,7 +164,7 @@ namespace Duplicati.GUI.TrayIcon
         protected StatusIcon m_trayIcon;

         protected Menu m_popupMenu;

         

-        protected static Dictionary<TrayIcons, Pixbuf> _images = new Dictionary<TrayIcons, Pixbuf>();

+        protected static readonly Dictionary<TrayIcons, Pixbuf> _images = new Dictionary<TrayIcons, Pixbuf>();

 

         protected override void Exit ()

         {

diff --git a/Duplicati/GUI/Duplicati.GUI.TrayIcon/HttpServerConnection.cs b/Duplicati/GUI/Duplicati.GUI.TrayIcon/HttpServerConnection.cs
index d42af3fd0..0ca5b64fd 100644
--- a/Duplicati/GUI/Duplicati.GUI.TrayIcon/HttpServerConnection.cs
+++ b/Duplicati/GUI/Duplicati.GUI.TrayIcon/HttpServerConnection.cs
@@ -23,9 +23,9 @@ namespace Duplicati.GUI.TrayIcon
 

         private class BackgroundRequest

         {

-            public string Method;

-            public string Endpoint;

-            public Dictionary<string, string> Query;

+            public readonly string Method;

+            public readonly string Endpoint;

+            public readonly Dictionary<string, string> Query;

 

             public BackgroundRequest(string method, string endpoint, Dictionary<string, string> query)

             {

@@ -226,8 +226,8 @@ namespace Duplicati.GUI.TrayIcon
 

         private class SaltAndNonce

         {

-            public string Salt = null;

-            public string Nonce = null;

+            public readonly string Salt = null;

+            public readonly string Nonce = null;

         }

 

         private SaltAndNonce GetSaltAndNonce()