node to page: Render aliases before pages

Some sites, Hugo docs included, have faulty alias definitions that point
to itself or another real page. These will be overwritten in the next step.

This is how it behaves in Hugo 0.17, too.

Updates #2297

1 files changed, 8 insertions, 4 deletions

diff --git a/hugolib/site.go b/hugolib/site.go
index 04673ca04..7d1071ac7 100644
--- a/hugolib/site.go
+++ b/hugolib/site.go
@@ -814,15 +814,19 @@ func (s *Site) render() (err error) {
 	}
 	s.timerStep("prepare pages")
 
-	if err = s.renderPages(); err != nil {
+	// Aliases must be rendered before pages.
+	// Some sites, Hugo docs included, have faulty alias definitions that point
+	// to itself or another real page. These will be overwritten in the next
+	// step.
+	if err = s.renderAliases(); err != nil {
 		return
 	}
-	s.timerStep("render and write pages")
+	s.timerStep("render and write aliases")
 
-	if err = s.renderAliases(); err != nil {
+	if err = s.renderPages(); err != nil {
 		return
 	}
-	s.timerStep("render and write aliases")
+	s.timerStep("render and write pages")
 
 	if err = s.renderSitemap(); err != nil {
 		return