From 022c4795510306e08a4aba31504ca382d41c7fac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Erik=20Pedersen?= Date: Tue, 13 Jul 2021 11:41:02 +0200 Subject: hugofs: Make FileMeta a struct MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit started out investigating a `concurrent map read write` issue, ending by replacing the map with a struct. This is easier to reason about, and it's more effective: ``` name old time/op new time/op delta SiteNew/Regular_Deep_content_tree-16 71.5ms ± 3% 69.4ms ± 5% ~ (p=0.200 n=4+4) name old alloc/op new alloc/op delta SiteNew/Regular_Deep_content_tree-16 29.7MB ± 0% 27.9MB ± 0% -5.82% (p=0.029 n=4+4) name old allocs/op new allocs/op delta SiteNew/Regular_Deep_content_tree-16 313k ± 0% 303k ± 0% -3.35% (p=0.029 n=4+4) ``` See #8749 --- helpers/general.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'helpers') diff --git a/helpers/general.go b/helpers/general.go index c5af83b66..25decbbc1 100644 --- a/helpers/general.go +++ b/helpers/general.go @@ -497,7 +497,7 @@ func PrintFs(fs afero.Fs, path string, w io.Writer) { var filename string var meta interface{} if fim, ok := info.(hugofs.FileMetaInfo); ok { - filename = fim.Meta().Filename() + filename = fim.Meta().Filename meta = fim.Meta() } fmt.Fprintf(w, " %q %q\t\t%v\n", path, filename, meta) -- cgit v1.2.3