From f4f566edf4bd6a590cf9cdbd5cfc0026ecd93b14 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Erik=20Pedersen?= Date: Fri, 11 Oct 2019 11:09:43 +0200 Subject: Make Pages.Prev/Next work like the other Prev/Next methods Fixes #4500 --- resources/page/pages_prev_next.go | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) (limited to 'resources/page/pages_prev_next.go') diff --git a/resources/page/pages_prev_next.go b/resources/page/pages_prev_next.go index 9293c9874..dd87aa4ce 100644 --- a/resources/page/pages_prev_next.go +++ b/resources/page/pages_prev_next.go @@ -13,13 +13,12 @@ package page -// Prev returns the previous page reletive to the given -func (p Pages) Prev(cur Page) Page { +// Next returns the next page reletive to the given +func (p Pages) Next(cur Page) Page { for x, c := range p { if c.Eq(cur) { if x == 0 { - // TODO(bep) consider return nil here to get it line with the other Prevs - return p[len(p)-1] + return nil } return p[x-1] } @@ -27,15 +26,14 @@ func (p Pages) Prev(cur Page) Page { return nil } -// Next returns the next page reletive to the given -func (p Pages) Next(cur Page) Page { +// Prev returns the previous page reletive to the given +func (p Pages) Prev(cur Page) Page { for x, c := range p { if c.Eq(cur) { if x < len(p)-1 { return p[x+1] } - // TODO(bep) consider return nil here to get it line with the other Nexts - return p[0] + return nil } } return nil -- cgit v1.2.3