diff options
author | Jakub Cabak <jakubcabak@gmail.com> | 2021-04-25 14:15:22 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-04-25 14:15:22 +0300 |
commit | 19c2edb08d2c5e86b07d2d9bf5b4713735f85528 (patch) | |
tree | ba6e243cf8a297bc765121373710b6b612186c92 | |
parent | 6996894ec1025f8c23c67340fef73a4b1e906cd6 (diff) |
Accessibility and SEO improvements (#296)
Co-authored-by: JCabak <kubaczento@gmail.com>
-rw-r--r-- | layouts/_default/single.html | 2 | ||||
-rw-r--r-- | layouts/index.html | 2 | ||||
-rw-r--r-- | layouts/partials/cards/accomplishments.html | 4 | ||||
-rw-r--r-- | layouts/partials/cards/project.html | 2 | ||||
-rw-r--r-- | layouts/partials/cards/recent-post.html | 4 | ||||
-rw-r--r-- | layouts/partials/cards/skill.html | 2 | ||||
-rw-r--r-- | layouts/partials/footer.html | 4 | ||||
-rw-r--r-- | layouts/partials/navigators/navbar.html | 1 | ||||
-rw-r--r-- | layouts/partials/navigators/next-prev-navigator.html | 4 | ||||
-rw-r--r-- | layouts/partials/navigators/sidebar.html | 2 | ||||
-rw-r--r-- | layouts/partials/note-aggregator.html | 2 | ||||
-rw-r--r-- | layouts/partials/sections/about.html | 10 | ||||
-rw-r--r-- | layouts/partials/sections/education-alt.html | 8 | ||||
-rw-r--r-- | layouts/partials/sections/education.html | 4 | ||||
-rw-r--r-- | layouts/partials/sections/experiences/multiple-positions.html | 2 | ||||
-rw-r--r-- | layouts/partials/sections/experiences/single-position.html | 2 | ||||
-rw-r--r-- | layouts/partials/sections/home.html | 2 |
17 files changed, 29 insertions, 28 deletions
diff --git a/layouts/_default/single.html b/layouts/_default/single.html index cc931ef..abafcca 100644 --- a/layouts/_default/single.html +++ b/layouts/_default/single.html @@ -59,7 +59,7 @@ <!--- Improve this page button ---> {{ if site.Params.GitRepo }} <div class="btn-improve-page"> - <a href="{{ site.Params.GitRepo }}/edit/{{ site.Params.GitBranch }}/content/{{ .File.Path }}" target="_blank"> + <a href="{{ site.Params.GitRepo }}/edit/{{ site.Params.GitBranch }}/content/{{ .File.Path }}" title="{{ i18n "improve_this_page" }}" target="_blank" rel="noopener"> <i class="fas fa-code-branch"></i> {{ i18n "improve_this_page" }} </a> diff --git a/layouts/index.html b/layouts/index.html index f22e648..e960ebd 100644 --- a/layouts/index.html +++ b/layouts/index.html @@ -1,5 +1,5 @@ <!DOCTYPE html> -<html lang="en"> +<html lang="{{ .Site.Language.Lang }}"> <head> <title>{{- .Site.Title -}}</title> {{ $siteDescription := .Site.Params.description }} diff --git a/layouts/partials/cards/accomplishments.html b/layouts/partials/cards/accomplishments.html index de03a55..a62fa22 100644 --- a/layouts/partials/cards/accomplishments.html +++ b/layouts/partials/cards/accomplishments.html @@ -3,7 +3,7 @@ <div class="card-header"> <h5 class="card-title mb-0">{{ .name }}</h5> <div class="sub-title"> - <span><a href="{{ .organization.url }}" target="_blank">{{ .organization.name }}</a></span> + <span><a href="{{ .organization.url }}" title="{{ .organization.name }}" target="_blank" rel="noopener">{{ .organization.name }}</a></span> <span class="ml-2">{{ .timeline }}</span> </div> </div> @@ -12,7 +12,7 @@ </div> <div class="card-footer"> {{ if .certificateURL }} - <a class="btn btn-outline-info ml-1 pl-2 mb-2" href="{{ .certificateURL }}" target="_blank" role="button">{{ i18n "view_certificate"}}</a> + <a class="btn btn-outline-info ml-1 pl-2 mb-2" href="{{ .certificateURL }}" target="_blank" rel="noopener" role="button">{{ i18n "view_certificate"}}</a> {{ end }} </div> </div> diff --git a/layouts/partials/cards/project.html b/layouts/partials/cards/project.html index 8950fb3..93d022d 100644 --- a/layouts/partials/cards/project.html +++ b/layouts/partials/cards/project.html @@ -4,7 +4,7 @@ > <div class="card mt-1"> <div class="card"> - <a class="card-header" href="{{ if .repo }}{{ .repo }}{{ else if .url }}{{ .url }}{{ else }}javascript:void(0){{ end }}" {{ if or .repo .url }}target="_blank"{{ end }}> + <a class="card-header" href="{{ if .repo }}{{ .repo }}{{ else if .url }}{{ .url }}{{ else }}javascript:void(0){{ end }}" {{ if or .repo .url }}target="_blank" rel="noopener"{{ end }}> <div> <div class="d-flex"> {{ if .logo }} diff --git a/layouts/partials/cards/recent-post.html b/layouts/partials/cards/recent-post.html index c5db57f..4426e46 100644 --- a/layouts/partials/cards/recent-post.html +++ b/layouts/partials/cards/recent-post.html @@ -1,5 +1,5 @@ <div class="col-lg-4 col-md-6 pt-2 post-card"> - <a href="{{ .RelPermalink }}" class="post-card-link"> + <a href="{{ .RelPermalink }}" title="{{ .Title }}" class="post-card-link"> <div class="card"> <div class="card-head"> <img class="card-img-top" src='{{ partial "helpers/get-hero.html" . }}' @@ -12,7 +12,7 @@ </div> <div class="card-footer"> <span class="float-left">{{ .Date.Format "January 2, 2006" }}</span> - <a href="{{ .RelPermalink }}" class="float-right btn btn-outline-info btn-sm">{{ i18n "read" }}</a> + <a href="{{ .RelPermalink }}" title="{{ i18n "read" }}" class="float-right btn btn-outline-info btn-sm">{{ i18n "read" }}</a> </div> </div> </a> diff --git a/layouts/partials/cards/skill.html b/layouts/partials/cards/skill.html index 0dc873a..1cf229f 100644 --- a/layouts/partials/cards/skill.html +++ b/layouts/partials/cards/skill.html @@ -1,5 +1,5 @@ <div class="col-xs-12 col-sm-6 col-lg-4 pt-2"> - <a class="skill-card-link" href="{{ if .url }}{{ .url }}{{ else }}javascript:void(0){{ end }}" {{ if .url }}target="_blank"{{ end }}> + <a class="skill-card-link" {{ if .url }}href="{{ .url }}" title="{{ .name }}" target="_blank" rel="noopener"{{ end }}> <div class="card"> <div class="card-head d-flex"> {{ if .logo }} diff --git a/layouts/partials/footer.html b/layouts/partials/footer.html index ed9eb2a..1503025 100644 --- a/layouts/partials/footer.html +++ b/layouts/partials/footer.html @@ -92,14 +92,14 @@ <div class="container"> <div class="row text-left"> <div class="col-md-4"> - <a id="theme" href="https://github.com/hossainemruz/toha" target="_blank"> + <a id="theme" href="https://github.com/hossainemruz/toha" target="_blank" rel="noopener"> <img src="{{ $themeLogo }}" alt="Toha Theme Logo"> Toha </a> </div> <div class="col-md-4 text-center">{{ $copyrightNotice | markdownify }}</div> <div class="col-md-4 text-right"> - <a id="hugo" href="https://gohugo.io/" target="_blank">{{ i18n "hugoAttributionText" }} + <a id="hugo" href="https://gohugo.io/" target="_blank" rel="noopener">{{ i18n "hugoAttributionText" }} <img src="{{ $hugoLogo }}" alt="Hugo Logo" diff --git a/layouts/partials/navigators/navbar.html b/layouts/partials/navigators/navbar.html index 00db04a..2daae09 100644 --- a/layouts/partials/navigators/navbar.html +++ b/layouts/partials/navigators/navbar.html @@ -45,6 +45,7 @@ type="button" data-toggle="collapse" data-target="#top-nav-items" + aria-label="menu" > <span class="navbar-toggler-icon"></span> </button> diff --git a/layouts/partials/navigators/next-prev-navigator.html b/layouts/partials/navigators/next-prev-navigator.html index 39590cc..f87c369 100644 --- a/layouts/partials/navigators/next-prev-navigator.html +++ b/layouts/partials/navigators/next-prev-navigator.html @@ -5,7 +5,7 @@ {{ if .Next }} {{ if (in site.Params.mainSections .Next.Type) }} <div class="col-md-6 previous-article"> - <a href="{{.Next.RelPermalink}}" class="btn btn-outline-info"> + <a href="{{.Next.RelPermalink}}" title="{{ .Next.Title }}" class="btn btn-outline-info"> <div><i class="fas fa-chevron-circle-left"></i> {{ i18n "prev" }}</div> <div class="next-prev-text">{{ .Next.Title }}</div> </a> @@ -21,7 +21,7 @@ {{ end }} {{ end}} <div class="{{ $columnWidth }} next-article"> - <a href="{{ .Prev.RelPermalink }}" class="btn btn-outline-info"> + <a href="{{ .Prev.RelPermalink }}" title="{{ .Prev.Title }}" class="btn btn-outline-info"> <div>{{ i18n "next" }} <i class="fas fa-chevron-circle-right"></i></div> <div class="next-prev-text">{{ .Prev.Title }}</div> </a> diff --git a/layouts/partials/navigators/sidebar.html b/layouts/partials/navigators/sidebar.html index cc92c94..5323c9c 100644 --- a/layouts/partials/navigators/sidebar.html +++ b/layouts/partials/navigators/sidebar.html @@ -17,6 +17,6 @@ </li> {{ else }} <!-- No sub-tree. So, only add current entry --> - <li><a class="{{$class}}" href="{{ .URL }}">{{.Name}}</a></li> + <li><a class="{{$class}}" href="{{ .URL }}" title="{{ .Name }}">{{.Name}}</a></li> {{ end }} {{ end }} diff --git a/layouts/partials/note-aggregator.html b/layouts/partials/note-aggregator.html index f00996e..8d90c5c 100644 --- a/layouts/partials/note-aggregator.html +++ b/layouts/partials/note-aggregator.html @@ -5,7 +5,7 @@ {{ else }} {{$id := .Params.Menu.Notes.Identifier }} <h4 class="note-collection-title" id="{{ $id }}"> - <a href="#{{ $id }}"># {{ .Title }}</a> + <a href="#{{ $id }}" title="{{ .Title }}"># {{ .Title }}</a> {{$badges:= split .File.Dir "/"}} {{ range after 1 $badges }} <span class="badge btn-info note-badge">{{ . }}</span> diff --git a/layouts/partials/sections/about.html b/layouts/partials/sections/about.html index 07ebda3..2999b99 100644 --- a/layouts/partials/sections/about.html +++ b/layouts/partials/sections/about.html @@ -17,7 +17,7 @@ <h5 class="p-1"> {{ .designation }} {{ if .company }} - {{ i18n "at"}} <a href="{{ .company.url }}" target="_blank">{{ .company.name }}</a> + {{ i18n "at"}} <a href="{{ .company.url }}" title="{{ .company.name }}" target="_blank" rel="noopener">{{ .company.name }}</a> {{ end }} </h5> {{ end }} @@ -29,18 +29,18 @@ {{ range .socialLinks }} <li> {{ if eq .name "Email" }} - <a href="mailto:{{ .url }}" target="_blank"><i class="{{ .icon }}"></i></a> + <a href="mailto:{{ .url }}" title="{{ .name }}" target="_blank" rel="noopener"><i class="{{ .icon }}"></i></a> {{ else if eq .name "Phone" }} - <a href="tel:{{ .url }}" target="_blank"><i class="{{ .icon }}"></i></a> + <a href="tel:{{ .url }}" title="{{ .name }}" target="_blank" rel="noopener"><i class="{{ .icon }}"></i></a> {{ else }} - <a href="{{ .url }}" target="_blank"><i class="{{ .icon }}"></i></a> + <a href="{{ .url }}" title="{{ .name }}" target="_blank" rel="noopener"><i class="{{ .icon }}"></i></a> {{ end }} </li> {{ end }} </ul> </div> {{ if .resume }} - <a href="{{ .resume | relURL }}" target="#" + <a href="{{ .resume | relURL }}" title="{{ i18n "resume"}}" target="#" ><button class="btn btn-dark">{{ i18n "resume"}}</button></a > {{ end }} diff --git a/layouts/partials/sections/education-alt.html b/layouts/partials/sections/education-alt.html index 93be79c..2994fc5 100644 --- a/layouts/partials/sections/education-alt.html +++ b/layouts/partials/sections/education-alt.html @@ -27,7 +27,7 @@ <div class="row"> <div class="col-lg-10 col-md-8"> {{ if .institution.url }} - <h5><a href="{{ .institution.url }}" target="_blank">{{ .institution.name }}</a></h5> + <h5><a href="{{ .institution.url }}" title="{{ .institution.name }}" target="_blank" rel="noopener">{{ .institution.name }}</a></h5> {{ else }} <h5>{{ .institution.name }}</h5> {{ end }} @@ -44,7 +44,7 @@ <ul> {{ range .publications }} {{ if .url }} - <li><a href="{{ .url }}" target="_blank">{{ .title }}</a></li> + <li><a href="{{ .url }}" title="{{ .title }}" target="_blank" rel="noopener">{{ .title }}</a></li> {{ else }} <li>{{ .title }}</li> {{ end }} @@ -82,9 +82,9 @@ {{ end }} {{ if gt (len .takenCourses.courses) 2 }} <button type="button" class="btn btn-link show-more-btn pt-0 {{ if .takenCourses.showGrades }}ml-1{{ else }}ml-2{{ end }}" - onclick="toggleCourseVisibility(this);" id="show-more-btn">{{ i18n "show_more"}}</button> + onclick="toggleCourseVisibility(this);" id="show-more-btn" aria-label="{{ i18n "show_more"}}">{{ i18n "show_more"}}</button> <button type="button" class="btn btn-link show-more-btn hidden pt-0 {{ if .takenCourses.showGrades }}ml-1{{ else }}ml-2{{ end }}" - onclick="toggleCourseVisibility(this);" id="show-less-btn">{{ i18n "show_less"}}</button> + onclick="toggleCourseVisibility(this);" id="show-less-btn" aria-label="{{ i18n "show_less"}}">{{ i18n "show_less"}}</button> {{ end }} </div> {{ end }} diff --git a/layouts/partials/sections/education.html b/layouts/partials/sections/education.html index 7958c04..59db9a3 100644 --- a/layouts/partials/sections/education.html +++ b/layouts/partials/sections/education.html @@ -27,7 +27,7 @@ <div class="row"> <div class="col-lg-10 col-md-8"> {{ if .institution.url }} - <h5><a href="{{ .institution.url }}" target="_blank">{{ .institution.name }}</a></h5> + <h5><a href="{{ .institution.url }}" title="{{ .institution.name }}" target="_blank" rel="noopener">{{ .institution.name }}</a></h5> {{ else }} <h5>{{ .institution.name }}</h5> {{ end }} @@ -44,7 +44,7 @@ <ul> {{ range .publications }} {{ if .url }} - <li><a href="{{ .url }}" target="_blank">{{ .title }}</a></li> + <li><a href="{{ .url }}" title="{{ .title }}" target="_blank" rel="noopener">{{ .title }}</a></li> {{ else }} <li>{{ .title }}</li> {{ end }} diff --git a/layouts/partials/sections/experiences/multiple-positions.html b/layouts/partials/sections/experiences/multiple-positions.html index a7d4434..1c77f53 100644 --- a/layouts/partials/sections/experiences/multiple-positions.html +++ b/layouts/partials/sections/experiences/multiple-positions.html @@ -1,7 +1,7 @@ <div class="col-10 col-lg-8"> <div class="experience-entry-heading"> <!-- For multiple positions, give emphasis on the company name--> - <h5>{{ if .company.url }}<a href={{.company.url}} target="_blank">{{ .company.name }}</a>{{ else }}{{ .company.name }}{{ end }}</h5> + <h5>{{ if .company.url }}<a href={{.company.url}} title="{{ .company.name }}" target="_blank" rel="noopener">{{ .company.name }}</a>{{ else }}{{ .company.name }}{{ end }}</h5> <!-- Total experience duration on a company is time between the starting date of the oldest position and ending date of most recent position --> {{ $oldestPosition := index (last 1 .positions) 0}} diff --git a/layouts/partials/sections/experiences/single-position.html b/layouts/partials/sections/experiences/single-position.html index 1845c12..c19c31d 100644 --- a/layouts/partials/sections/experiences/single-position.html +++ b/layouts/partials/sections/experiences/single-position.html @@ -3,7 +3,7 @@ {{ $position:= index .positions 0 }} <!-- For single position, give emphasis on the designation--> <h5>{{ $position.designation }}</h5> - <h6>{{ if .company.url }}<a href={{.company.url}} target="_blank">{{ .company.name }}</a>{{ else }}{{ .company.name }}{{ end }}</h6> + <h6>{{ if .company.url }}<a href={{.company.url}} title="{{ .company.name }}" target="_blank" rel="noopener">{{ .company.name }}</a>{{ else }}{{ .company.name }}{{ end }}</h6> <!-- Add experience duration info --> <p class="text-muted">{{ $position.start }} - {{ if $position.end }}{{ $position.end }}{{ else }}{{ i18n "present" }}{{ end }}, {{ .company.location }} diff --git a/layouts/partials/sections/home.html b/layouts/partials/sections/home.html index 4976c09..6ab4cba 100644 --- a/layouts/partials/sections/home.html +++ b/layouts/partials/sections/home.html @@ -127,7 +127,7 @@ {{ if .section.id }} {{ $sectionID = .section.id }} {{ end }} - <a href="#{{ $sectionID }}"><i class="arrow bounce fa fa-chevron-down"></i></a> + <a href="#{{ $sectionID }}" aria-label="{{ i18n "read" }} {{ i18n "more" }} - {{ $name }}"><i class="arrow bounce fa fa-chevron-down"></i></a> {{ end }} {{ end }} </div> |