diff options
| author | Daniel Gultsch <daniel@gultsch.de> | 2022-04-21 18:01:06 +0300 |
|---|---|---|
| committer | Daniel Gultsch <daniel@gultsch.de> | 2022-04-21 18:03:26 +0300 |
| commit | d7637192e2254392cc0870c63a0a4d4515720e61 (patch) | |
| tree | 575a0f61e0ec21811cf9aa90a9817535c5639ac2 | |
| parent | e3cae4cb1d4bb72e53ca103f53cae5924c6d0aa1 (diff) | |
fix NPE during bookmark creation
closes #4312
fixes #4211
thank you @singpolyma
| -rw-r--r-- | src/main/java/eu/siacs/conversations/services/XmppConnectionService.java | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java b/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java index 42b699e46..0f121b0b3 100644 --- a/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java +++ b/src/main/java/eu/siacs/conversations/services/XmppConnectionService.java @@ -1793,7 +1793,9 @@ public class XmppConnectionService extends Service { public void createBookmark(final Account account, final Bookmark bookmark) { account.putBookmark(bookmark); final XmppConnection connection = account.getXmppConnection(); - if (connection.getFeatures().bookmarks2()) { + if (connection == null) { + Log.d(Config.LOGTAG, account.getJid().asBareJid()+": no connection. ignoring bookmark creation"); + } else if (connection.getFeatures().bookmarks2()) { final Element item = mIqGenerator.publishBookmarkItem(bookmark); pushNodeAndEnforcePublishOptions(account, Namespace.BOOKMARKS2, item, bookmark.getJid().asBareJid().toEscapedString(), PublishOptions.persistentWhitelistAccessMaxItems()); } else if (connection.getFeatures().bookmarksConversion()) { |