diff options
| author | Janek Bevendorff <janek@jbev.net> | 2017-03-14 16:34:16 +0300 |
|---|---|---|
| committer | Janek Bevendorff <janek@jbev.net> | 2017-03-15 17:23:47 +0300 |
| commit | 28ec015ef4ef2f142f56983e089dd7197d7245df (patch) | |
| tree | 68834ef3bdee66f335faa84026c7fdd0e94340c6 /.github | |
| parent | 65d4a0a8cd5c59ebdd36a20f9f70f174acf5867d (diff) | |
Add -DWITH_ASAN=ON requirement to pull request template
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c83ca4e53..b9852f3c9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,11 +3,11 @@ ## Description <!--- Describe your changes in detail --> -## Motivation and Context +## Motivation and context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> -## How Has This Been Tested? +## How has this been tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> @@ -29,5 +29,6 @@ - ✅ I have read the **CONTRIBUTING** document. **[REQUIRED]** - ✅ My code follows the code style of this project. **[REQUIRED]** - ✅ All new and existing tests passed. **[REQUIRED]** +- ✅ I have compiled and verified my code with `-DWITH_ASAN=ON`. **[REQUIRED]** - ✅ My change requires a change to the documentation and I have updated it accordingly. - ✅ I have added tests to cover my changes. |