diff options
author | Janek Bevendorff <janek@jbev.net> | 2018-09-29 20:00:47 +0300 |
---|---|---|
committer | Janek Bevendorff <janek@jbev.net> | 2018-10-19 22:49:54 +0300 |
commit | 113c8eb702dbdfefaf23a76bfe69603b54522b28 (patch) | |
tree | 32cbffa6b7368f5f69c9092cbbed2d2031b76800 /src/gui/Application.h | |
parent | 18b22834c1d9657ab98ca5160571e51837bb6366 (diff) |
Add CLI tests and improve coding style and i18n
The CLI module was lacking unit test coverage and showed some severe
coding style violations, which this patch addresses.
In addition, all uses of qCritical() with untranslatble raw char*
sequences were removed in favor of proper locale strings. These are
written to STDERR through QTextStreams and support output
redirection for testing purposes. With this change, error messages don't
depend on the global Qt logging settings and targets anymore and go
directly to the terminal or into a file if needed.
This patch also fixes a bug discovered during unit test development,
where the extract command would just dump the raw XML contents without
decrypting embedded Salsa20-protected values first, making the XML
export mostly useless, since passwords are scrambled.
Lastly, all CLI commands received a dedicated -h/--help option.
Diffstat (limited to 'src/gui/Application.h')
-rw-r--r-- | src/gui/Application.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/Application.h b/src/gui/Application.h index a6c6fdf90..3fdd8af90 100644 --- a/src/gui/Application.h +++ b/src/gui/Application.h @@ -22,8 +22,8 @@ #include <QApplication> #include <QtNetwork/QLocalServer> -class QLockFile; +class QLockFile; class QSocketNotifier; class Application : public QApplication |