diff options
| author | Gianluca Recchia <gianluca.recchia97@gmail.com> | 2019-08-24 18:53:11 +0300 |
|---|---|---|
| committer | Jonathan White <support@dmapps.us> | 2019-08-31 05:30:30 +0300 |
| commit | fccbb98b8e2e5220849cc26da188b9f8b17a18c6 (patch) | |
| tree | 056550cd69aea6ce3f0d4f2f4013a2bdb7cd76a3 /src/gui/DatabaseWidget.cpp | |
| parent | c12fd369d9ddbebb82c9c12f7105a6293cec490a (diff) | |
Improve File Dialog
* QFileDialog returns UNIX paths, even on Windows. This patch converts what QFileDialog returns to the native path format.
* Improve const correctness
* Avoid imposing file extension on Linux
* This patch improves things like unneeded passes by values, missing const qualifiers, ugly copies because of variable reuse and consistency in variable names.
Diffstat (limited to 'src/gui/DatabaseWidget.cpp')
| -rw-r--r-- | src/gui/DatabaseWidget.cpp | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/src/gui/DatabaseWidget.cpp b/src/gui/DatabaseWidget.cpp index 31badc582..d695ae2cd 100644 --- a/src/gui/DatabaseWidget.cpp +++ b/src/gui/DatabaseWidget.cpp @@ -1656,13 +1656,8 @@ bool DatabaseWidget::saveAs() oldFilePath = QDir::toNativeSeparators(config()->get("LastDir", QDir::homePath()).toString() + "/" + tr("Passwords").append(".kdbx")); } - QString newFilePath = fileDialog()->getSaveFileName(this, - tr("Save database as"), - oldFilePath, - tr("KeePass 2 Database").append(" (*.kdbx)"), - nullptr, - nullptr, - "kdbx"); + const QString newFilePath = fileDialog()->getSaveFileName( + this, tr("Save database as"), oldFilePath, tr("KeePass 2 Database").append(" (*.kdbx)"), nullptr, nullptr); if (!newFilePath.isEmpty()) { // Ensure we don't recurse back into this function |