Download all favicons (#3169)

* Selecting one or more entries to download icons always forces the download (ie, if a new URL exists the new icon will be downloaded and set)
* Instead of downloading for each entry, the web url's are scraped from the provided entries and only those urls are downloaded. The icon is set for all entries that share a URL. This is useful if a group contains many entries that point to the same url, only 1 download call will occur.
* The icon download dialog displays whether you are doing one entry, many entries, or an entire group. It is also modal so you have to dismiss it to use KeePassXC again.
* Moved DuckDuckGo fallback notice into the download dialog.

1 files changed, 5 insertions, 2 deletions

diff --git a/src/gui/DatabaseWidget.h b/src/gui/DatabaseWidget.h
index 7da6b7a40..aeb6a02e1 100644
--- a/src/gui/DatabaseWidget.h
+++ b/src/gui/DatabaseWidget.h
@@ -25,12 +25,11 @@
 #include <QTimer>
 
 #include "DatabaseOpenDialog.h"
+#include "config-keepassx.h"
 #include "gui/MessageWidget.h"
 #include "gui/csvImport/CsvImportWizard.h"
 #include "gui/entry/EntryModel.h"
 
-#include "config-keepassx.h"
-
 class DatabaseOpenWidget;
 class KeePass1OpenWidget;
 class OpVaultOpenWidget;
@@ -124,6 +123,7 @@ signals:
     void databaseModified();
     void databaseSaved();
     void databaseUnlocked();
+    void databaseLockRequested();
     void databaseLocked();
 
     // Emitted in replaceDatabase, may be caused by lock, reload, unlock, load.
@@ -169,6 +169,8 @@ public slots:
     void setupTotp();
     void performAutoType();
     void openUrl();
+    void downloadSelectedFavicons();
+    void downloadAllFavicons();
     void openUrlForEntry(Entry* entry);
     void createGroup();
     void deleteGroup();
@@ -233,6 +235,7 @@ private:
     void setClipboardTextAndMinimize(const QString& text);
     void processAutoOpen();
     bool confirmDeleteEntries(QList<Entry*> entries, bool permanent);
+    void performIconDownloads(const QList<Entry*>& entries, bool force = false);
 
     QSharedPointer<Database> m_db;