Add CLI tests and improve coding style and i18n

The CLI module was lacking unit test coverage and showed some severe
coding style violations, which this patch addresses.

In addition, all uses of qCritical() with untranslatble raw char*
sequences were removed in favor of proper locale strings. These are
written to STDERR through QTextStreams and support output
redirection for testing purposes. With this change, error messages don't
depend on the global Qt logging settings and targets anymore and go
directly to the terminal or into a file if needed.

This patch also fixes a bug discovered during unit test development,
where the extract command would just dump the raw XML contents without
decrypting embedded Salsa20-protected values first, making the XML
export mostly useless, since passwords are scrambled.

Lastly, all CLI commands received a dedicated -h/--help option.

1 files changed, 69 insertions, 0 deletions

diff --git a/tests/TestCli.h b/tests/TestCli.h
new file mode 100644
index 000000000..532d84a79
--- /dev/null
+++ b/tests/TestCli.h
@@ -0,0 +1,69 @@
+/*
+ *  Copyright (C) 2018 KeePassXC Team <team@keepassxc.org>
+ *
+ *  This program is free software: you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation, either version 2 or (at your option)
+ *  version 3 of the License.
+ *
+ *  This program is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef KEEPASSXC_TESTCLI_H
+#define KEEPASSXC_TESTCLI_H
+
+#include "core/Database.h"
+
+#include <QTest>
+#include <QTextStream>
+#include <QFile>
+#include <QScopedPointer>
+#include <QTemporaryFile>
+
+class TestCli : public QObject
+{
+    Q_OBJECT
+
+private:
+    QSharedPointer<Database> readTestDatabase() const;
+
+private slots:
+    void initTestCase();
+    void init();
+    void cleanup();
+    void cleanupTestCase();
+
+    void testCommand();
+    void testAdd();
+    void testClip();
+    void testDiceware();
+    void testEdit();
+    void testEstimate_data();
+    void testEstimate();
+    void testExtract();
+    void testGenerate_data();
+    void testGenerate();
+    void testList();
+    void testLocate();
+    void testMerge();
+    void testRemove();
+    void testShow();
+
+private:
+    QByteArray m_dbData;
+    QScopedPointer<QTemporaryFile> m_dbFile;
+    QScopedPointer<QTemporaryFile> m_stdoutFile;
+    QScopedPointer<QTemporaryFile> m_stderrFile;
+    QScopedPointer<QTemporaryFile> m_stdinFile;
+    FILE* m_stdoutHandle = stdout;
+    FILE* m_stderrHandle = stderr;
+    FILE* m_stdinHandle = stdin;
+};
+
+#endif //KEEPASSXC_TESTCLI_H