diff options
| author | Jonathan White <support@dmapps.us> | 2021-04-04 15:56:00 +0300 |
|---|---|---|
| committer | Jonathan White <support@dmapps.us> | 2021-04-06 05:56:03 +0300 |
| commit | 80809ace677a920b62be2259c1156d419adcdb97 (patch) | |
| tree | d242f1608c33cdab73f0e5a741cc91fbd03e7033 /tests/TestSSHAgent.h | |
| parent | 86ddd702fb6da4e236cc48937c5eb205aed86239 (diff) | |
Replace all crypto libraries with Botan
Selected the [Botan crypto library](https://github.com/randombit/botan) due to its feature list, maintainer support, availability across all deployment platforms, and ease of use. Also evaluated Crypto++ as a viable candidate, but the additional features of Botan (PKCS#11, TPM, etc) won out.
The random number generator received a backend upgrade. Botan prefers hardware-based RNG's and will provide one if available. This is transparent to KeePassXC and a significant improvement over gcrypt.
Replaced Argon2 library with built-in Botan implementation that supports i, d, and id. This requires Botan 2.11.0 or higher. Also simplified the parameter test across KDF's.
Aligned SymmetricCipher parameters with available modes. All encrypt and decrypt operations are done in-place instead of returning new objects. This allows use of secure vectors in the future with no additional overhead.
Took this opportunity to decouple KeeShare from SSH Agent. Removed leftover code from OpenSSHKey and consolidated the SSH Agent code into the same directory. Removed bcrypt and blowfish inserts since they are provided by Botan.
Additionally simplified KeeShare settings interface by removing raw certificate byte data from the user interface. KeeShare will be further refactored in a future PR.
NOTE: This PR breaks backwards compatibility with KeeShare certificates due to different RSA key storage with Botan. As a result, new "own" certificates will need to be generated and trust re-established.
Removed YKChallengeResponseKeyCLI in favor of just using the original implementation with signal/slots.
Removed TestRandom stub since it was just faking random numbers and not actually using the backend. TestRandomGenerator now uses the actual RNG.
Greatly simplified Secret Service plugin's use of crypto functions with Botan.
Diffstat (limited to 'tests/TestSSHAgent.h')
| -rw-r--r-- | tests/TestSSHAgent.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tests/TestSSHAgent.h b/tests/TestSSHAgent.h index 13e8076e7..bb9fa5459 100644 --- a/tests/TestSSHAgent.h +++ b/tests/TestSSHAgent.h @@ -18,10 +18,11 @@ #ifndef TESTSSHAGENT_H #define TESTSSHAGENT_H -#include "crypto/ssh/OpenSSHKey.h" +#include "sshagent/OpenSSHKey.h" #include <QObject> #include <QProcess> #include <QTemporaryFile> +#include <QUuid> class TestSSHAgent : public QObject { |