diff options
| author | asapelkin <asapelkin0x01@ya.ru> | 2019-10-31 23:44:40 +0300 |
|---|---|---|
| committer | Jonathan White <support@dmapps.us> | 2019-11-02 05:53:28 +0300 |
| commit | 98badfb4a2e69df7666839d097c577d6df13a9ed (patch) | |
| tree | 652b4ca87a0c6c998124db3e6eda0b2cd66c4093 /tests | |
| parent | ac7face247723d8c258d36e7f769f293aa9be3f2 (diff) | |
some cppcheck and clang-tidy fixies
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/TestCsvParser.cpp | 10 | ||||
| -rw-r--r-- | tests/TestEntryModel.cpp | 4 | ||||
| -rw-r--r-- | tests/TestGroup.cpp | 2 |
3 files changed, 8 insertions, 8 deletions
diff --git a/tests/TestCsvParser.cpp b/tests/TestCsvParser.cpp index 46d254098..f31e30414 100644 --- a/tests/TestCsvParser.cpp +++ b/tests/TestCsvParser.cpp @@ -111,7 +111,7 @@ void TestCsvParser::testEmptySimple() out << ""; QVERIFY(parser->parse(file.data())); t = parser->getCsvTable(); - QVERIFY(t.size() == 0); + QVERIFY(t.isEmpty()); } void TestCsvParser::testEmptyQuoted() @@ -120,7 +120,7 @@ void TestCsvParser::testEmptyQuoted() out << "\"\""; QVERIFY(parser->parse(file.data())); t = parser->getCsvTable(); - QVERIFY(t.size() == 0); + QVERIFY(t.isEmpty()); } void TestCsvParser::testEmptyNewline() @@ -129,14 +129,14 @@ void TestCsvParser::testEmptyNewline() out << "\"\n\""; QVERIFY(parser->parse(file.data())); t = parser->getCsvTable(); - QVERIFY(t.size() == 0); + QVERIFY(t.isEmpty()); } void TestCsvParser::testEmptyFile() { QVERIFY(parser->parse(file.data())); t = parser->getCsvTable(); - QVERIFY(t.size() == 0); + QVERIFY(t.isEmpty()); } void TestCsvParser::testNewline() @@ -281,7 +281,7 @@ void TestCsvParser::testEmptyReparsing() parser->parse(nullptr); QVERIFY(parser->reparse()); t = parser->getCsvTable(); - QVERIFY(t.size() == 0); + QVERIFY(t.isEmpty()); } void TestCsvParser::testReparsing() diff --git a/tests/TestEntryModel.cpp b/tests/TestEntryModel.cpp index e32de2466..670e43aab 100644 --- a/tests/TestEntryModel.cpp +++ b/tests/TestEntryModel.cpp @@ -296,7 +296,7 @@ void TestEntryModel::testProxyModel() QSignalSpy spyColumnRemove(modelProxy, SIGNAL(columnsAboutToBeRemoved(QModelIndex, int, int))); modelProxy->hideColumn(0, true); QCOMPARE(modelProxy->columnCount(), 12); - QVERIFY(spyColumnRemove.size() >= 1); + QVERIFY(!spyColumnRemove.isEmpty()); int oldSpyColumnRemoveSize = spyColumnRemove.size(); modelProxy->hideColumn(0, true); @@ -318,7 +318,7 @@ void TestEntryModel::testProxyModel() QSignalSpy spyColumnInsert(modelProxy, SIGNAL(columnsAboutToBeInserted(QModelIndex, int, int))); modelProxy->hideColumn(0, false); QCOMPARE(modelProxy->columnCount(), 13); - QVERIFY(spyColumnInsert.size() >= 1); + QVERIFY(!spyColumnInsert.isEmpty()); int oldSpyColumnInsertSize = spyColumnInsert.size(); modelProxy->hideColumn(0, false); diff --git a/tests/TestGroup.cpp b/tests/TestGroup.cpp index ae9c59894..9fc39dc64 100644 --- a/tests/TestGroup.cpp +++ b/tests/TestGroup.cpp @@ -1070,7 +1070,7 @@ void TestGroup::testHierarchy() QVERIFY(hierarchy.contains("group3")); hierarchy = group3->hierarchy(0); - QVERIFY(hierarchy.size() == 0); + QVERIFY(hierarchy.isEmpty()); hierarchy = group3->hierarchy(1); QVERIFY(hierarchy.size() == 1); |