Age | Commit message (Collapse) | Author |
|
Mostly style issues.
I used the following tools to find most of these:
- lgtm.com
- clang-tidy
- cpplint
- cppcheck
|
|
* Ran clang-tidy with "readability-braces-around-statements" to find missing braces around statements.
|
|
Many lines were not conformant with the project's formatting rules.
This patch should fix all formatting and whitespace issues in the code
base.
A clang-format directive was put around the connect() calls containing
SIGNALs and SLOTs whose signatures would be denormalized because of the
formatting rules.
|
|
The CLI module was lacking unit test coverage and showed some severe
coding style violations, which this patch addresses.
In addition, all uses of qCritical() with untranslatble raw char*
sequences were removed in favor of proper locale strings. These are
written to STDERR through QTextStreams and support output
redirection for testing purposes. With this change, error messages don't
depend on the global Qt logging settings and targets anymore and go
directly to the terminal or into a file if needed.
This patch also fixes a bug discovered during unit test development,
where the extract command would just dump the raw XML contents without
decrypting embedded Salsa20-protected values first, making the XML
export mostly useless, since passwords are scrambled.
Lastly, all CLI commands received a dedicated -h/--help option.
|
|
|
|
|
|
Fix KDBX test linker errors on Windows
|
|
* Add SHA512 support to CryptoHash
* Add ChaCha20 support
* Add HMAC support
* Add new HmacBlockStream, used in KDBX 4
* Add support for ChaCha20 protected stream
|
|
|
|
Fixed 2 memory leaks in production code and a few in testcases. As a
result leak_check_at_exit ASAN option does not need to turned off for
non-gui tests.
Smart pointers should be used elsewhere for consistency, but the sooner
this fixes are delivered, the lesser memory leaks are introduced.
|
|
Includes AES-256-CTR non-stream tests
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This is a preparation to be able to build KeePassX against Qt 5.
|
|
Qt 5.
|
|
The implementation had two issues:
- It didn't add a block full of padding when the input size was a multiple
of the block size.
- It didn't strip the padding when reading data.
|
|
|
|
This way they can be used without a running X server.
|
|
|
|
Restructure SymmetricCipher implementation to allow multiple backends.
|
|
|
|
|
|
|
|
|
|
|