From f62e0534a23c2030c9c22e6f3db25148fcb486fd Mon Sep 17 00:00:00 2001 From: Carlo Teubner Date: Sun, 24 Nov 2019 14:40:16 +0000 Subject: Fixes for minor issues found by static analysis Mostly style issues. I used the following tools to find most of these: - lgtm.com - clang-tidy - cpplint - cppcheck --- tests/TestSymmetricCipher.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tests/TestSymmetricCipher.cpp') diff --git a/tests/TestSymmetricCipher.cpp b/tests/TestSymmetricCipher.cpp index 173f328ee..bc872a510 100644 --- a/tests/TestSymmetricCipher.cpp +++ b/tests/TestSymmetricCipher.cpp @@ -279,7 +279,6 @@ void TestSymmetricCipher::testTwofish256CbcEncryption() QByteArray::fromHex("6F725C5950133F82EF021A94CADC8508")}; SymmetricCipher cipher(SymmetricCipher::Twofish, SymmetricCipher::Cbc, SymmetricCipher::Encrypt); - bool ok; for (int i = 0; i < keys.size(); ++i) { QVERIFY(cipher.init(keys[i], ivs[i])); @@ -287,6 +286,7 @@ void TestSymmetricCipher::testTwofish256CbcEncryption() QByteArray ctPrev = ivs[i]; QByteArray ctCur; QCOMPARE(cipher.blockSize(), 16); + bool ok = false; for (int j = 0; j < 5000; ++j) { ctCur = cipher.process(ptNext, &ok); if (!ok) { @@ -335,13 +335,13 @@ void TestSymmetricCipher::testTwofish256CbcDecryption() QByteArray::fromHex("4C81F5BDC1081170FF96F50B1F76A566")}; SymmetricCipher cipher(SymmetricCipher::Twofish, SymmetricCipher::Cbc, SymmetricCipher::Decrypt); - bool ok; for (int i = 0; i < keys.size(); ++i) { cipher.init(keys[i], ivs[i]); QByteArray ctNext = cipherTexts[i]; QByteArray ptCur; QCOMPARE(cipher.blockSize(), 16); + bool ok = false; for (int j = 0; j < 5000; ++j) { ptCur = cipher.process(ctNext, &ok); if (!ok) { -- cgit v1.2.3