Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/littlefs-project/littlefs.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristopher Haster <chaster@utexas.edu>2021-01-02 08:50:59 +0300
committerChristopher Haster <chaster@utexas.edu>2021-01-10 12:21:21 +0300
commitb84fb6bcc509d9a6cfd037aa5cb8700b2d28009a (patch)
tree4d4eebfdb54013f32a9ed10ee0b3c880a0cff2fc /scripts
parent887f3660ed524fbc87f237a23f94e3c01ce18784 (diff)
Added BUILDDIR, a bit of script reworking
Now littlefs's Makefile can work with a custom build directory for compilation output. Just set the BUILDDIR variable and the Makefile will take care of the rest. make BUILDDIR=build size This makes it very easy to compare builds with different compile-time configurations or different cross-compilers. This meant most of code.py's build isolation is no longer needed, so revisted the scripts and cleaned/tweaked a number of things. Also bought code.py in line with coverage.py, fixing some of the inconsistencies that were created while developing these scripts. One change to note was removing the inline measuring logic, I realized this feature is unnecessary thanks to GCC's -fkeep-static-functions and -fno-inline flags.
Diffstat (limited to 'scripts')
-rwxr-xr-xscripts/code.py373
-rwxr-xr-xscripts/coverage.py127
-rwxr-xr-xscripts/test.py55
3 files changed, 221 insertions, 334 deletions
diff --git a/scripts/code.py b/scripts/code.py
index 46459a5..b61615e 100755
--- a/scripts/code.py
+++ b/scripts/code.py
@@ -1,24 +1,12 @@
#!/usr/bin/env python3
#
-# This script finds the code size at the function level, with/without
-# static functions, and has some conveniences for comparing different
-# versions. It's basically one big wrapper around nm, and may or may
-# not have been written out of jealousy of Linux's Bloat-O-Meter.
-#
-# Here's a useful bash script to use while developing:
-# ./scripts/code_size.py -qo old.csv
-# while true ; do ./code_scripts/size.py -d old.csv ; inotifywait -rqe modify * ; done
-#
-# Or even better, to automatically update results on commit:
-# ./scripts/code_size.py -qo commit.csv
-# while true ; do ./scripts/code_size.py -d commit.csv -o current.csv ; git diff --exit-code --quiet && cp current.csv commit.csv ; inotifywait -rqe modify * ; done
-#
-# Or my personal favorite:
-# ./scripts/code_size.py -qo master.csv && cp master.csv commit.csv
-# while true ; do ( ./scripts/code_size.py -i commit.csv -d master.csv -s ; ./scripts/code_size.py -i current.csv -d master.csv -s ; ./scripts/code_size.py -d master.csv -o current.csv -s ) | awk 'BEGIN {printf "%-16s %7s %7s %7s\n","","old","new","diff"} (NR==2 && $1="commit") || (NR==4 && $1="prev") || (NR==6 && $1="current") {printf "%-16s %7s %7s %7s %s\n",$1,$2,$3,$5,$6}' ; git diff --exit-code --quiet && cp current.csv commit.csv ; inotifywait -rqe modify * ; done
+# Script to find code size at the function level. Basically just a bit wrapper
+# around nm with some extra conveniences for comparing builds. Heavily inspired
+# by Linux's Bloat-O-Meter.
#
import os
+import glob
import itertools as it
import subprocess as sp
import shlex
@@ -26,267 +14,159 @@ import re
import csv
import collections as co
-SIZEDIR = 'sizes'
-RULES = """
-define FLATTEN
-%(sizedir)s/%(build)s.$(subst /,.,$(target)): $(target)
- ( echo "#line 1 \\"$$<\\"" ; %(cat)s $$< ) > $$@
-%(sizedir)s/%(build)s.$(subst /,.,$(target:.c=.size)): \\
- %(sizedir)s/%(build)s.$(subst /,.,$(target:.c=.o))
- $(NM) --size-sort $$^ | sed 's/^/$(subst /,\\/,$(target:.c=.o)):/' > $$@
-endef
-$(foreach target,$(SRC),$(eval $(FLATTEN)))
-
--include %(sizedir)s/*.d
-.SECONDARY:
-
-%%.size: $(foreach t,$(subst /,.,$(OBJ:.o=.size)),%%.$t)
- cat $^ > $@
-"""
-CATS = {
- 'code': 'cat',
- 'code_inlined': 'sed \'s/^static\( inline\)\?//\'',
-}
-
-def build(**args):
- # mkdir -p sizedir
- os.makedirs(args['sizedir'], exist_ok=True)
- if args.get('inlined', False):
- builds = ['code', 'code_inlined']
- else:
- builds = ['code']
-
- # write makefiles for the different types of builds
- makefiles = []
- targets = []
- for build in builds:
- path = args['sizedir'] + '/' + build
- with open(path + '.mk', 'w') as mk:
- mk.write(RULES.replace(4*' ', '\t') % dict(
- sizedir=args['sizedir'],
- build=build,
- cat=CATS[build]))
- mk.write('\n')
-
- # pass on defines
- for d in args['D']:
- mk.write('%s: override CFLAGS += -D%s\n' % (
- path+'.size', d))
+OBJ_PATHS = ['*.o', 'bd/*.o']
- makefiles.append(path + '.mk')
- targets.append(path + '.size')
-
- # build in parallel
- cmd = (['make', '-f', 'Makefile'] +
- list(it.chain.from_iterable(['-f', m] for m in makefiles)) +
- [target for target in targets])
- if args.get('verbose', False):
- print(' '.join(shlex.quote(c) for c in cmd))
- proc = sp.Popen(cmd,
- stdout=sp.DEVNULL if not args.get('verbose', False) else None)
- proc.wait()
- if proc.returncode != 0:
- sys.exit(-1)
-
- # find results
- build_results = co.defaultdict(lambda: 0)
- # notes
- # - filters type
- # - discards internal/debug functions (leading __)
+def collect(paths, **args):
+ results = co.defaultdict(lambda: 0)
pattern = re.compile(
- '^(?P<file>[^:]+)' +
- ':(?P<size>[0-9a-fA-F]+)' +
+ '^(?P<size>[0-9a-fA-F]+)' +
' (?P<type>[%s])' % re.escape(args['type']) +
- ' (?!__)(?P<name>.+?)$')
- for build in builds:
- path = args['sizedir'] + '/' + build
- with open(path + '.size') as size:
- for line in size:
- match = pattern.match(line)
- if match:
- file = match.group('file')
- # discard .8449 suffixes created by optimizer
- name = re.sub('\.[0-9]+', '', match.group('name'))
- size = int(match.group('size'), 16)
- build_results[(build, file, name)] += size
-
- results = []
- for (build, file, name), size in build_results.items():
- if build == 'code':
- results.append((file, name, size, False))
- elif (build == 'code_inlined' and
- ('inlined', file, name) not in results):
- results.append((file, name, size, True))
-
- return results
+ ' (?P<func>.+?)$')
+ for path in paths:
+ # note nm-tool may contain extra args
+ cmd = args['nm_tool'] + ['--size-sort', path]
+ if args.get('verbose'):
+ print(' '.join(shlex.quote(c) for c in cmd))
+ proc = sp.Popen(cmd, stdout=sp.PIPE, universal_newlines=True)
+ for line in proc.stdout:
+ m = pattern.match(line)
+ if m:
+ results[(path, m.group('func'))] += int(m.group('size'), 16)
+
+ flat_results = []
+ for (file, func), size in results.items():
+ # map to source files
+ if args.get('build_dir'):
+ file = re.sub('%s/*' % re.escape(args['build_dir']), '', file)
+ # discard internal functions
+ if func.startswith('__'):
+ continue
+ # discard .8449 suffixes created by optimizer
+ func = re.sub('\.[0-9]+', '', func)
+ flat_results.append((file, func, size))
+
+ return flat_results
def main(**args):
- # find results
- if not args.get('input', None):
- results = build(**args)
+ # find sizes
+ if not args.get('use', None):
+ # find .o files
+ paths = []
+ for path in args['obj_paths']:
+ if os.path.isdir(path):
+ path = path + '/*.o'
+
+ for path in glob.glob(path):
+ paths.append(path)
+
+ if not paths:
+ print('no .obj files found in %r?' % args['obj_paths'])
+ sys.exit(-1)
+
+ results = collect(paths, **args)
else:
- with open(args['input']) as f:
+ with open(args['use']) as f:
r = csv.DictReader(f)
results = [
( result['file'],
- result['name'],
- int(result['size']),
- bool(int(result.get('inlined', 0))))
- for result in r
- if (not bool(int(result.get('inlined', 0))) or
- args.get('inlined', False))]
+ result['function'],
+ int(result['size']))
+ for result in r]
total = 0
- for _, _, size, inlined in results:
- if not inlined:
- total += size
+ for _, _, size in results:
+ total += size
# find previous results?
- if args.get('diff', None):
+ if args.get('diff'):
with open(args['diff']) as f:
r = csv.DictReader(f)
prev_results = [
( result['file'],
- result['name'],
- int(result['size']),
- bool(int(result.get('inlined', 0))))
- for result in r
- if (not bool(int(result.get('inlined', 0))) or
- args.get('inlined', False))]
+ result['function'],
+ int(result['size']))
+ for result in r]
prev_total = 0
- for _, _, size, inlined in prev_results:
- if not inlined:
- prev_total += size
+ for _, _, size in prev_results:
+ prev_total += size
# write results to CSV
- if args.get('output', None):
- results.sort(key=lambda x: (-x[2], x))
+ if args.get('output'):
with open(args['output'], 'w') as f:
w = csv.writer(f)
- if args.get('inlined', False):
- w.writerow(['file', 'name', 'size', 'inlined'])
- for file, name, size, inlined in results:
- w.writerow((file, name, size, int(inlined)))
- else:
- w.writerow(['file', 'name', 'size'])
- for file, name, size, inlined in results:
- w.writerow((file, name, size))
+ w.writerow(['file', 'function', 'size'])
+ for file, func, size in sorted(results):
+ w.writerow((file, func, size))
# print results
- def dedup_functions(results):
- functions = co.defaultdict(lambda: (0, True))
- for _, name, size, inlined in results:
- if not inlined:
- functions[name] = (functions[name][0] + size, False)
- for _, name, size, inlined in results:
- if inlined and functions[name][1]:
- functions[name] = (functions[name][0] + size, True)
- return functions
-
- def dedup_files(results):
- files = co.defaultdict(lambda: 0)
- for file, _, size, inlined in results:
- if not inlined:
- files[file] += size
- return files
-
- def diff_sizes(olds, news):
- diff = co.defaultdict(lambda: (None, None, None))
+ def dedup_entries(results, by='function'):
+ entries = co.defaultdict(lambda: 0)
+ for file, func, size in results:
+ entry = (file if by == 'file' else func)
+ entries[entry] += size
+ return entries
+
+ def diff_entries(olds, news):
+ diff = co.defaultdict(lambda: (0, 0, 0, 0))
for name, new in news.items():
- diff[name] = (None, new, new)
+ diff[name] = (0, new, new, 1.0)
for name, old in olds.items():
- new = diff[name][1] or 0
- diff[name] = (old, new, new-old)
+ _, new, _, _ = diff[name]
+ diff[name] = (old, new, new-old, (new-old)/old if old else 1.0)
return diff
- def print_header(name=''):
- if not args.get('diff', False):
- print('%-40s %7s' % (name, 'size'))
- else:
- print('%-40s %7s %7s %7s' % (name, 'old', 'new', 'diff'))
-
- def print_functions():
- functions = dedup_functions(results)
- functions = {
- name+' (inlined)' if inlined else name: size
- for name, (size, inlined) in functions.items()}
-
- if not args.get('diff', None):
- print_header('function')
- for name, size in sorted(functions.items(),
- key=lambda x: (-x[1], x)):
- print("%-40s %7d" % (name, size))
+ def print_header(by=''):
+ if not args.get('diff'):
+ print('%-36s %7s' % (by, 'size'))
else:
- prev_functions = dedup_functions(prev_results)
- prev_functions = {
- name+' (inlined)' if inlined else name: size
- for name, (size, inlined) in prev_functions.items()}
- diff = diff_sizes(functions, prev_functions)
- print_header('function (%d added, %d removed)' % (
- sum(1 for old, _, _ in diff.values() if not old),
- sum(1 for _, new, _ in diff.values() if not new)))
- for name, (old, new, diff) in sorted(diff.items(),
- key=lambda x: (-(x[1][2] or 0), x)):
- if diff or args.get('all', False):
- print("%-40s %7s %7s %+7d%s" % (
- name, old or "-", new or "-", diff,
- ' (%+.2f%%)' % (100*((new-old)/old))
- if old and new else
- ''))
+ print('%-36s %7s %7s %7s' % (by, 'old', 'new', 'diff'))
- def print_files():
- files = dedup_files(results)
+ def print_entries(by='function'):
+ entries = dedup_entries(results, by=by)
- if not args.get('diff', None):
- print_header('file')
- for file, size in sorted(files.items(),
- key=lambda x: (-x[1], x)):
- print("%-40s %7d" % (file, size))
+ if not args.get('diff'):
+ print_header(by=by)
+ for name, size in sorted(entries.items()):
+ print("%-36s %7d" % (name, size))
else:
- prev_files = dedup_files(prev_results)
- diff = diff_sizes(files, prev_files)
- print_header('file (%d added, %d removed)' % (
- sum(1 for old, _, _ in diff.values() if not old),
- sum(1 for _, new, _ in diff.values() if not new)))
- for name, (old, new, diff) in sorted(diff.items(),
- key=lambda x: (-(x[1][2] or 0), x)):
- if diff or args.get('all', False):
- print("%-40s %7s %7s %+7d%s" % (
- name, old or "-", new or "-", diff,
- ' (%+.2f%%)' % (100*((new-old)/old))
- if old and new else
- ''))
+ prev_entries = dedup_entries(prev_results, by=by)
+ diff = diff_entries(prev_entries, entries)
+ print_header(by='%s (%d added, %d removed)' % (by,
+ sum(1 for old, _, _, _ in diff.values() if not old),
+ sum(1 for _, new, _, _ in diff.values() if not new)))
+ for name, (old, new, diff, ratio) in sorted(diff.items(),
+ key=lambda x: (-x[1][3], x)):
+ if ratio or args.get('all'):
+ print("%-36s %7s %7s %+7d%s" % (name,
+ old or "-",
+ new or "-",
+ diff,
+ ' (%+.1f%%)' % (100*ratio) if ratio else ''))
def print_totals():
- if not args.get('diff', None):
- print("%-40s %7d" % ('TOTALS', total))
+ if not args.get('diff'):
+ print("%-36s %7d" % ('TOTAL', total))
else:
- print("%-40s %7s %7s %+7d%s" % (
- 'TOTALS', prev_total, total, total-prev_total,
- ' (%+.2f%%)' % (100*((total-prev_total)/total))
- if prev_total and total else
- ''))
-
- def print_status():
- if not args.get('diff', None):
- print(total)
- else:
- print("%d (%+.2f%%)" % (total, 100*((total-prev_total)/total)))
-
- if args.get('quiet', False):
+ ratio = (total-prev_total)/prev_total if prev_total else 1.0
+ print("%-36s %7s %7s %+7d%s" % (
+ 'TOTAL',
+ prev_total if prev_total else '-',
+ total if total else '-',
+ total-prev_total,
+ ' (%+.1f%%)' % (100*ratio) if ratio else ''))
+
+ if args.get('quiet'):
pass
- elif args.get('status', False):
- print_status()
- elif args.get('summary', False):
+ elif args.get('summary'):
print_header()
print_totals()
- elif args.get('files', False):
- print_files()
+ elif args.get('files'):
+ print_entries(by='file')
print_totals()
else:
- print_functions()
+ print_entries(by='function')
print_totals()
if __name__ == "__main__":
@@ -294,35 +174,32 @@ if __name__ == "__main__":
import sys
parser = argparse.ArgumentParser(
description="Find code size at the function level.")
- parser.add_argument('sizedir', nargs='?', default=SIZEDIR,
- help="Directory to store intermediary results. Defaults "
- "to \"%s\"." % SIZEDIR)
- parser.add_argument('-D', action='append', default=[],
- help="Specify compile-time define.")
+ parser.add_argument('obj_paths', nargs='*', default=OBJ_PATHS,
+ help="Description of where to find *.o files. May be a directory \
+ or a list of paths. Defaults to %r." % OBJ_PATHS)
parser.add_argument('-v', '--verbose', action='store_true',
help="Output commands that run behind the scenes.")
- parser.add_argument('-i', '--input',
- help="Don't compile and find code sizes, instead use this CSV file.")
parser.add_argument('-o', '--output',
help="Specify CSV file to store results.")
+ parser.add_argument('-u', '--use',
+ help="Don't compile and find code sizes, instead use this CSV file.")
parser.add_argument('-d', '--diff',
help="Specify CSV file to diff code size against.")
parser.add_argument('-a', '--all', action='store_true',
help="Show all functions, not just the ones that changed.")
- parser.add_argument('--inlined', action='store_true',
- help="Run a second compilation to find the sizes of functions normally "
- "removed by optimizations. These will be shown as \"*.inlined\" "
- "functions, and will not be included in the total.")
parser.add_argument('--files', action='store_true',
help="Show file-level code sizes. Note this does not include padding! "
"So sizes may differ from other tools.")
parser.add_argument('-s', '--summary', action='store_true',
help="Only show the total code size.")
- parser.add_argument('-S', '--status', action='store_true',
- help="Show minimum info useful for a single-line status.")
parser.add_argument('-q', '--quiet', action='store_true',
help="Don't show anything, useful with -o.")
parser.add_argument('--type', default='tTrRdDbB',
help="Type of symbols to report, this uses the same single-character "
"type-names emitted by nm. Defaults to %(default)r.")
+ parser.add_argument('--nm-tool', default=['nm'], type=lambda x: x.split(),
+ help="Path to the nm tool to use.")
+ parser.add_argument('--build-dir',
+ help="Specify the relative build directory. Used to map object files \
+ to the correct source files.")
sys.exit(main(**vars(parser.parse_args())))
diff --git a/scripts/coverage.py b/scripts/coverage.py
index 6e51372..6f1f54f 100755
--- a/scripts/coverage.py
+++ b/scripts/coverage.py
@@ -1,6 +1,7 @@
#!/usr/bin/env python3
#
-
+# Parse and report coverage info from .info files generated by lcov
+#
import os
import glob
import csv
@@ -8,8 +9,8 @@ import re
import collections as co
import bisect as b
-INFO_PATHS = 'tests/*.toml.info'
+INFO_PATHS = ['tests/*.toml.info']
def collect(paths, **args):
file = None
@@ -65,14 +66,14 @@ def collect(paths, **args):
def main(**args):
# find coverage
- if not args.get('input', None):
+ if not args.get('use'):
# find *.info files
paths = []
for path in args['info_paths']:
if os.path.isdir(path):
path = path + '/*.gcov'
- for path in glob.glob(path, recursive=True):
+ for path in glob.glob(path):
paths.append(path)
if not paths:
@@ -81,7 +82,7 @@ def main(**args):
results = collect(paths, **args)
else:
- with open(args['input']) as f:
+ with open(args['use']) as f:
r = csv.DictReader(f)
results = [
( result['file'],
@@ -96,7 +97,7 @@ def main(**args):
total_count += count
# find previous results?
- if args.get('diff', None):
+ if args.get('diff'):
with open(args['diff']) as f:
r = csv.DictReader(f)
prev_results = [
@@ -112,12 +113,11 @@ def main(**args):
prev_total_count += count
# write results to CSV
- if args.get('output', None):
- results.sort(key=lambda x: (-(x[3]-x[2]), -x[3], x))
+ if args.get('output'):
with open(args['output'], 'w') as f:
w = csv.writer(f)
w.writerow(['file', 'function', 'hits', 'count'])
- for file, func, hits, count in results:
+ for file, func, hits, count in sorted(results):
w.writerow((file, func, hits, count))
# print results
@@ -130,97 +130,95 @@ def main(**args):
return entries
def diff_entries(olds, news):
- diff = co.defaultdict(lambda: (None, None, None, None, None, None))
+ diff = co.defaultdict(lambda: (0, 0, 0, 0, 0, 0, 0))
for name, (new_hits, new_count) in news.items():
diff[name] = (
0, 0,
new_hits, new_count,
- new_hits, new_count)
+ new_hits, new_count,
+ (new_hits/new_count if new_count else 1.0) - 1.0)
for name, (old_hits, old_count) in olds.items():
- new_hits = diff[name][2] or 0
- new_count = diff[name][3] or 0
+ _, _, new_hits, new_count, _, _, _ = diff[name]
diff[name] = (
old_hits, old_count,
new_hits, new_count,
- new_hits-old_hits, new_count-old_count)
+ new_hits-old_hits, new_count-old_count,
+ ((new_hits/new_count if new_count else 1.0)
+ - (old_hits/old_count if old_count else 1.0)))
return diff
def print_header(by=''):
- if not args.get('diff', False):
- print('%-36s %11s' % (by, 'hits/count'))
+ if not args.get('diff'):
+ print('%-36s %19s' % (by, 'hits/line'))
else:
- print('%-36s %11s %11s %11s' % (by, 'old', 'new', 'diff'))
+ print('%-36s %19s %19s %11s' % (by, 'old', 'new', 'diff'))
def print_entries(by='function'):
entries = dedup_entries(results, by=by)
- if not args.get('diff', None):
+ if not args.get('diff'):
print_header(by=by)
- for name, (hits, count) in sorted(entries.items(),
- key=lambda x: (-(x[1][1]-x[1][0]), -x[1][1], x)):
- print("%-36s %11s (%.2f%%)" % (name,
- '%d/%d' % (hits, count),
- 100*(hits/count if count else 1.0)))
+ for name, (hits, count) in sorted(entries.items()):
+ print("%-36s %11s %7s" % (name,
+ '%d/%d' % (hits, count)
+ if count else '-',
+ '%.1f%%' % (100*hits/count)
+ if count else '-'))
else:
prev_entries = dedup_entries(prev_results, by=by)
diff = diff_entries(prev_entries, entries)
print_header(by='%s (%d added, %d removed)' % (by,
- sum(1 for _, old, _, _, _, _ in diff.values() if not old),
- sum(1 for _, _, _, new, _, _ in diff.values() if not new)))
+ sum(1 for _, old, _, _, _, _, _ in diff.values() if not old),
+ sum(1 for _, _, _, new, _, _, _ in diff.values() if not new)))
for name, (
old_hits, old_count,
new_hits, new_count,
- diff_hits, diff_count) in sorted(diff.items(),
- key=lambda x: (
- -(x[1][5]-x[1][4]), -x[1][5], -x[1][3], x)):
- ratio = ((new_hits/new_count if new_count else 1.0)
- - (old_hits/old_count if old_count else 1.0))
- if diff_hits or diff_count or args.get('all', False):
- print("%-36s %11s %11s %11s%s" % (name,
+ diff_hits, diff_count, ratio) in sorted(diff.items(),
+ key=lambda x: (-x[1][6], x)):
+ if ratio or args.get('all'):
+ print("%-36s %11s %7s %11s %7s %11s%s" % (name,
'%d/%d' % (old_hits, old_count)
if old_count else '-',
+ '%.1f%%' % (100*old_hits/old_count)
+ if old_count else '-',
'%d/%d' % (new_hits, new_count)
if new_count else '-',
+ '%.1f%%' % (100*new_hits/new_count)
+ if new_count else '-',
'%+d/%+d' % (diff_hits, diff_count),
- ' (%+.2f%%)' % (100*ratio) if ratio else ''))
+ ' (%+.1f%%)' % (100*ratio) if ratio else ''))
def print_totals():
- if not args.get('diff', None):
- print("%-36s %11s (%.2f%%)" % ('TOTALS',
- '%d/%d' % (total_hits, total_count),
- 100*(total_hits/total_count if total_count else 1.0)))
+ if not args.get('diff'):
+ print("%-36s %11s %7s" % ('TOTAL',
+ '%d/%d' % (total_hits, total_count)
+ if total_count else '-',
+ '%.1f%%' % (100*total_hits/total_count)
+ if total_count else '-'))
else:
ratio = ((total_hits/total_count
if total_count else 1.0)
- (prev_total_hits/prev_total_count
if prev_total_count else 1.0))
- print("%-36s %11s %11s %11s%s" % ('TOTALS',
- '%d/%d' % (prev_total_hits, prev_total_count),
- '%d/%d' % (total_hits, total_count),
+ print("%-36s %11s %7s %11s %7s %11s%s" % ('TOTAL',
+ '%d/%d' % (prev_total_hits, prev_total_count)
+ if prev_total_count else '-',
+ '%.1f%%' % (100*prev_total_hits/prev_total_count)
+ if prev_total_count else '-',
+ '%d/%d' % (total_hits, total_count)
+ if total_count else '-',
+ '%.1f%%' % (100*total_hits/total_count)
+ if total_count else '-',
'%+d/%+d' % (total_hits-prev_total_hits,
total_count-prev_total_count),
- ' (%+.2f%%)' % (100*ratio) if ratio else ''))
+ ' (%+.1f%%)' % (100*ratio) if ratio else ''))
- def print_status():
- if not args.get('diff', None):
- print("%d/%d (%.2f%%)" % (total_hits, total_count,
- 100*(total_hits/total_count if total_count else 1.0)))
- else:
- ratio = ((total_hits/total_count
- if total_count else 1.0)
- - (prev_total_hits/prev_total_count
- if prev_total_count else 1.0))
- print("%d/%d (%+.2f%%)" % (total_hits, total_count,
- (100*ratio) if ratio else ''))
-
- if args.get('quiet', False):
+ if args.get('quiet'):
pass
- elif args.get('status', False):
- print_status()
- elif args.get('summary', False):
+ elif args.get('summary'):
print_header()
print_totals()
- elif args.get('files', False):
+ elif args.get('files'):
print_entries(by='file')
print_totals()
else:
@@ -231,17 +229,18 @@ if __name__ == "__main__":
import argparse
import sys
parser = argparse.ArgumentParser(
- description="Show/manipulate coverage info")
- parser.add_argument('info_paths', nargs='*', default=[INFO_PATHS],
+ description="Parse and report coverage info from .info files \
+ generated by lcov")
+ parser.add_argument('info_paths', nargs='*', default=INFO_PATHS,
help="Description of where to find *.info files. May be a directory \
or list of paths. *.info files will be merged to show the total \
- coverage. Defaults to \"%s\"." % INFO_PATHS)
+ coverage. Defaults to %r." % INFO_PATHS)
parser.add_argument('-v', '--verbose', action='store_true',
help="Output commands that run behind the scenes.")
- parser.add_argument('-i', '--input',
- help="Don't do any work, instead use this CSV file.")
parser.add_argument('-o', '--output',
help="Specify CSV file to store results.")
+ parser.add_argument('-u', '--use',
+ help="Don't do any work, instead use this CSV file.")
parser.add_argument('-d', '--diff',
help="Specify CSV file to diff code size against.")
parser.add_argument('-a', '--all', action='store_true',
@@ -250,8 +249,6 @@ if __name__ == "__main__":
help="Show file-level coverage.")
parser.add_argument('-s', '--summary', action='store_true',
help="Only show the total coverage.")
- parser.add_argument('-S', '--status', action='store_true',
- help="Show minimum info useful for a single-line status.")
parser.add_argument('-q', '--quiet', action='store_true',
help="Don't show anything, useful with -o.")
sys.exit(main(**vars(parser.parse_args())))
diff --git a/scripts/test.py b/scripts/test.py
index 957702b..65c8104 100755
--- a/scripts/test.py
+++ b/scripts/test.py
@@ -20,7 +20,7 @@ import pty
import errno
import signal
-TESTDIR = 'tests'
+TEST_PATHS = 'tests'
RULES = """
define FLATTEN
%(path)s%%$(subst /,.,$(target)): $(target)
@@ -31,14 +31,15 @@ $(foreach target,$(SRC),$(eval $(FLATTEN)))
-include %(path)s*.d
.SECONDARY:
-%(path)s.test: %(path)s.test.o $(foreach t,$(subst /,.,$(OBJ)),%(path)s.$t)
+%(path)s.test: %(path)s.test.o \\
+ $(foreach t,$(subst /,.,$(SRC:.c=.o)),%(path)s.$t)
$(CC) $(CFLAGS) $^ $(LFLAGS) -o $@
"""
COVERAGE_RULES = """
%(path)s.test: override CFLAGS += -fprofile-arcs -ftest-coverage
# delete lingering coverage
-%(path)s.test: | %(path)s.info.clean
+%(path)s.test: | %(path)s.clean
.PHONY: %(path)s.clean
%(path)s.clean:
rm -f %(path)s*.gcda
@@ -373,12 +374,17 @@ class TestSuite:
self.name = os.path.basename(path)
if self.name.endswith('.toml'):
self.name = self.name[:-len('.toml')]
- self.path = path
+ if args.get('build_dir'):
+ self.toml = path
+ self.path = args['build_dir'] + '/' + path
+ else:
+ self.toml = path
+ self.path = path
self.classes = classes
self.defines = defines.copy()
self.filter = filter
- with open(path) as f:
+ with open(self.toml) as f:
# load tests
config = toml.load(f)
@@ -489,7 +495,7 @@ class TestSuite:
def build(self, **args):
# build test files
- tf = open(self.path + '.test.c.t', 'w')
+ tf = open(self.path + '.test.tc', 'w')
tf.write(GLOBALS)
if self.code is not None:
tf.write('#line %d "%s"\n' % (self.code_lineno, self.path))
@@ -499,7 +505,7 @@ class TestSuite:
for case in self.cases:
if case.in_ not in tfs:
tfs[case.in_] = open(self.path+'.'+
- case.in_.replace('/', '.')+'.t', 'w')
+ re.sub('(\.c)?$', '.tc', case.in_.replace('/', '.')), 'w')
tfs[case.in_].write('#line 1 "%s"\n' % case.in_)
with open(case.in_) as f:
for line in f:
@@ -556,13 +562,15 @@ class TestSuite:
if path is None:
mk.write('%s: %s | %s\n' % (
self.path+'.test.c',
- self.path,
- self.path+'.test.c.t'))
+ self.toml,
+ self.path+'.test.tc'))
else:
mk.write('%s: %s %s | %s\n' % (
self.path+'.'+path.replace('/', '.'),
- self.path, path,
- self.path+'.'+path.replace('/', '.')+'.t'))
+ self.toml,
+ path,
+ self.path+'.'+re.sub('(\.c)?$', '.tc',
+ path.replace('/', '.'))))
mk.write('\t./scripts/explode_asserts.py $| -o $@\n')
self.makefile = self.path + '.mk'
@@ -617,7 +625,7 @@ def main(**args):
classes = [TestCase]
suites = []
- for testpath in args['testpaths']:
+ for testpath in args['test_paths']:
# optionally specified test case/perm
testpath, *filter = testpath.split('#')
filter = [int(f) for f in filter]
@@ -628,9 +636,9 @@ def main(**args):
elif os.path.isfile(testpath):
testpath = testpath
elif testpath.endswith('.toml'):
- testpath = TESTDIR + '/' + testpath
+ testpath = TEST_PATHS + '/' + testpath
else:
- testpath = TESTDIR + '/' + testpath + '.toml'
+ testpath = TEST_PATHS + '/' + testpath + '.toml'
# find tests
for path in glob.glob(testpath):
@@ -695,7 +703,7 @@ def main(**args):
if not args.get('verbose', False):
for line in stdout:
sys.stdout.write(line)
- sys.exit(-3)
+ sys.exit(-1)
print('built %d test suites, %d test cases, %d permutations' % (
len(suites),
@@ -707,7 +715,7 @@ def main(**args):
for perm in suite.perms:
total += perm.shouldtest(**args)
if total != sum(len(suite.perms) for suite in suites):
- print('total down to %d permutations' % total)
+ print('filtered down to %d permutations' % total)
# only requested to build?
if args.get('build', False):
@@ -733,7 +741,7 @@ def main(**args):
else:
sys.stdout.write(
"\033[01m{path}:{lineno}:\033[01;31mfailure:\033[m "
- "{perm} failed with {returncode}\n".format(
+ "{perm} failed\n".format(
perm=perm, path=perm.suite.path, lineno=perm.lineno,
returncode=perm.result.returncode or 0))
if perm.result.stdout:
@@ -753,7 +761,8 @@ def main(**args):
if args.get('coverage', False):
# collect coverage info
- cmd = (['make', '-f', 'Makefile'] +
+ # why -j1? lcov doesn't work in parallel because of gcov issues
+ cmd = (['make', '-j1', '-f', 'Makefile'] +
list(it.chain.from_iterable(['-f', m] for m in makefiles)) +
[re.sub('\.test$', '.cumul.info', target) for target in targets])
if args.get('verbose', False):
@@ -762,7 +771,7 @@ def main(**args):
stdout=sp.DEVNULL if not args.get('verbose', False) else None)
proc.wait()
if proc.returncode != 0:
- sys.exit(-3)
+ sys.exit(-1)
if args.get('gdb', False):
failure = None
@@ -786,12 +795,12 @@ if __name__ == "__main__":
import argparse
parser = argparse.ArgumentParser(
description="Run parameterized tests in various configurations.")
- parser.add_argument('testpaths', nargs='*', default=[TESTDIR],
+ parser.add_argument('test_paths', nargs='*', default=[TEST_PATHS],
help="Description of test(s) to run. By default, this is all tests \
found in the \"{0}\" directory. Here, you can specify a different \
directory of tests, a specific file, a suite by name, and even a \
specific test case by adding brackets. For example \
- \"test_dirs[0]\" or \"{0}/test_dirs.toml[0]\".".format(TESTDIR))
+ \"test_dirs[0]\" or \"{0}/test_dirs.toml[0]\".".format(TEST_PATHS))
parser.add_argument('-D', action='append', default=[],
help="Overriding parameter definitions.")
parser.add_argument('-v', '--verbose', action='store_true',
@@ -823,4 +832,8 @@ if __name__ == "__main__":
to accumulate coverage information into *.info files. Note \
coverage is not reset between runs, allowing multiple runs to \
contribute to coverage.")
+ parser.add_argument('--build-dir',
+ help="Build relative to the specified directory instead of the \
+ current directory.")
+
sys.exit(main(**vars(parser.parse_args())))