Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/mapsme/omim.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/coding
diff options
context:
space:
mode:
authorYuri Gorshenin <y@maps.me>2016-07-22 15:04:25 +0300
committerYuri Gorshenin <y@maps.me>2016-07-22 15:36:03 +0300
commit120cddc6295b3a79455cc30c7aea6ff7f4fb99d9 (patch)
tree2f20bb9e87da942dee4d96e34ca38c2b62d952b0 /coding
parent32af6db6fd63955565a2b26533eb9015ec2f1b56 (diff)
Review fixes.
Diffstat (limited to 'coding')
-rw-r--r--coding/memory_region.hpp4
-rw-r--r--coding/reader.hpp9
2 files changed, 2 insertions, 11 deletions
diff --git a/coding/memory_region.hpp b/coding/memory_region.hpp
index b7a1994d95..29b92d7759 100644
--- a/coding/memory_region.hpp
+++ b/coding/memory_region.hpp
@@ -18,7 +18,7 @@ public:
class MappedMemoryRegion : public MemoryRegion
{
public:
- MappedMemoryRegion(FilesMappingContainer::Handle && handle) : m_handle(move(handle)) {}
+ explicit MappedMemoryRegion(FilesMappingContainer::Handle && handle) : m_handle(move(handle)) {}
// MemoryRegion overrides:
uint64_t Size() const override { return m_handle.GetSize(); }
@@ -33,7 +33,7 @@ private:
class CopiedMemoryRegion : public MemoryRegion
{
public:
- CopiedMemoryRegion(vector<uint8_t> && buffer) : m_buffer(move(buffer)) {}
+ explicit CopiedMemoryRegion(vector<uint8_t> && buffer) : m_buffer(move(buffer)) {}
// MemoryRegion overrides:
uint64_t Size() const override { return m_buffer.size(); }
diff --git a/coding/reader.hpp b/coding/reader.hpp
index 6c8ed98cb3..c96088d0ff 100644
--- a/coding/reader.hpp
+++ b/coding/reader.hpp
@@ -159,15 +159,6 @@ public:
return (m_reader.Size() - m_pos);
}
- // unique_ptr<Reader> SubReader(uint64_t size)
- // {
- // uint64_t const pos = m_pos;
- // Skip(size);
- // return m_reader.SubReader(pos, size);
- // }
-
- // unique_ptr<Reader> SubReader() { return SubReader(Size()); }
-
private:
void CheckPosition() const
{