Merge pull request #3687 from milchakov/MAPSME-1656_incorrect_email_validation

[editor] Mapsme 1656 incorrect email validation

1 files changed, 10 insertions, 5 deletions

diff --git a/indexer/editable_map_object.cpp b/indexer/editable_map_object.cpp
index e79685484e..d074f2255a 100644
--- a/indexer/editable_map_object.cpp
+++ b/indexer/editable_map_object.cpp
@@ -315,6 +315,15 @@ bool EditableMapObject::ValidateEmail(string const & email)
   if (email.empty())
     return true;
 
+  if (strings::IsASCIIString(email))
+    return regex_match(email, regex(R"([^@\s]+@[a-zA-Z0-9-]+(\.[a-zA-Z0-9-]+)+$)"));
+  
+  if ('@' == email.front() || '@' == email.back())
+    return false;
+  
+  if ('.' == email.back())
+    return false;
+  
   auto const atPos = find(begin(email), end(email), '@');
   if (atPos == end(email))
     return false;
@@ -323,14 +332,10 @@ bool EditableMapObject::ValidateEmail(string const & email)
   if (find(next(atPos), end(email), '@') != end(email))
     return false;
 
-  // There should be at least one '.' sign after '@' ...
+  // There should be at least one '.' sign after '@'
   if (find(next(atPos), end(email), '.') == end(email))
     return false;
 
-  // ... not in the end.
-  if (email.back() == '.')
-    return false;
-
   return true;
 }
 }  // namespace osm