Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/mapsme/omim.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArsentiy Milchakov <milcars@mapswithme.com>2017-06-20 14:33:28 +0300
committerArsentiy Milchakov <milcars@mapswithme.com>2017-06-20 14:33:28 +0300
commit736ececa28397c467920dbbd7b37cbdf0a644921 (patch)
treeb0ee4ba5a63a603aa092eacff9f468c1d12274f1 /partners_api
parent7471d5acb83e7dcf06783b3467607d2200de4bff (diff)
review fixes
Diffstat (limited to 'partners_api')
-rw-r--r--partners_api/partners_api_tests/viator_tests.cpp2
-rw-r--r--partners_api/viator_api.cpp14
2 files changed, 8 insertions, 8 deletions
diff --git a/partners_api/partners_api_tests/viator_tests.cpp b/partners_api/partners_api_tests/viator_tests.cpp
index 6a0bf9eed4..555483cdf7 100644
--- a/partners_api/partners_api_tests/viator_tests.cpp
+++ b/partners_api/partners_api_tests/viator_tests.cpp
@@ -57,7 +57,7 @@ UNIT_TEST(Viator_SortProducts)
{"10", 7.0, 0, "", 1.0, "", "", "", ""}
};
- for (size_t i = 0 ; i < 1000; ++i)
+ for (size_t i = 0; i < 1000; ++i)
{
std::shuffle(products.begin(), products.end(), std::minstd_rand(std::minstd_rand::default_seed));
viator::SortProducts(products);
diff --git a/partners_api/viator_api.cpp b/partners_api/viator_api.cpp
index a08fe9c275..8365b61aa9 100644
--- a/partners_api/viator_api.cpp
+++ b/partners_api/viator_api.cpp
@@ -25,7 +25,7 @@ using namespace viator;
std::string const kApiUrl = "https://viatorapi.viator.com";
std::string const kWebUrl = "https://www.partner.viator.com";
-int8_t GetLang(string const & lang)
+int8_t GetLang(std::string const & lang)
{
return StringUtf8Multilang::GetLangIndex(lang);
}
@@ -60,7 +60,7 @@ IdsMap kAccountIds =
std::string GetId(IdsMap const & from)
{
- int8_t lang = GetLang(languages::GetCurrentNorm());
+ int8_t const lang = GetLang(languages::GetCurrentNorm());
auto const it = from.find(lang);
@@ -81,7 +81,8 @@ std::string GetAccountId()
return GetId(kAccountIds);
}
-bool RunSimpleHttpRequest(string const & url, std::string const & bodyData, string & result)
+bool RunSimpleHttpRequest(std::string const & url, std::string const & bodyData,
+ std::string & result)
{
HttpClient request(url);
request.SetHttpMethod("POST");
@@ -124,10 +125,9 @@ bool CheckAnswer(my::Json const & root)
std::string errorMessage;
FromJSONObject(root.get(), "errorMessageText", errorMessage);
LOG(LWARNING, ("Viator retrieved unsuccessfull status, error message:", errorMessage));
- return false;
}
- return true;
+ return success;
}
bool CheckDataArray(json_t const * data)
@@ -175,8 +175,8 @@ void MakeProducts(std::string const & src, std::vector<Product> & products)
namespace viator
{
// static
-bool RawApi::GetTopProducts(string const & destId, string const & currency, int count,
- string & result)
+bool RawApi::GetTopProducts(std::string const & destId, std::string const & currency, int count,
+ std::string & result)
{
int dest = 0;
CHECK(strings::to_int(destId, dest), ());