From 1a20301cbdf06c0e737ef9d3ce2607179a7f00eb Mon Sep 17 00:00:00 2001 From: Dmitry Yunitsky Date: Tue, 11 Aug 2015 17:48:09 +0300 Subject: [android] Refactoring and fixes. --- android/AndroidManifest.xml | 24 +- android/MapsWithMeTest/AndroidManifest.xml | 4 +- .../com/mapswithme/test/MonkeyEventsReceiver.java | 18 +- android/jni/Android.mk | 2 +- .../mapswithme/maps/DownloadResourcesActivity.cpp | 2 +- android/jni/com/mapswithme/maps/MWMApplication.cpp | 142 -- android/jni/com/mapswithme/maps/MwmApplication.cpp | 142 ++ android/res/layout/activity_download_resources.xml | 62 + android/res/layout/download_resources.xml | 76 -- .../mapswithme/maps/DownloadResourcesActivity.java | 537 ++++---- .../src/com/mapswithme/maps/IntentProcessor.java | 4 +- android/src/com/mapswithme/maps/MWMActivity.java | 1420 -------------------- .../src/com/mapswithme/maps/MWMApplication.java | 346 ----- android/src/com/mapswithme/maps/MwmActivity.java | 1417 +++++++++++++++++++ .../src/com/mapswithme/maps/MwmApplication.java | 346 +++++ .../src/com/mapswithme/maps/ads/LikesManager.java | 14 +- .../maps/ads/RateStoreDialogFragment.java | 4 +- .../com/mapswithme/maps/background/Notifier.java | 37 +- .../maps/base/BaseMwmFragmentActivity.java | 4 +- .../maps/bookmarks/BookmarksListFragment.java | 4 +- .../maps/location/AndroidNativeProvider.java | 4 +- .../maps/location/GoogleFusedLocationProvider.java | 4 +- .../mapswithme/maps/location/LocationHelper.java | 6 +- .../maps/routing/RoutingResultCodesProcessor.java | 4 +- .../com/mapswithme/maps/search/SearchFragment.java | 4 +- .../maps/search/SearchToolbarController.java | 6 +- .../mapswithme/maps/settings/SettingsActivity.java | 10 +- .../maps/settings/StoragePathManager.java | 14 +- .../src/com/mapswithme/maps/sound/TtsPlayer.java | 4 +- .../com/mapswithme/maps/widget/RoutingLayout.java | 6 +- .../BasePlacePageAnimationController.java | 4 +- .../src/com/mapswithme/util/BottomSheetHelper.java | 4 +- .../src/com/mapswithme/util/ConnectionState.java | 4 +- android/src/com/mapswithme/util/Language.java | 4 +- .../util/MultipleTrackerReferrerReceiver.java | 4 +- android/src/com/mapswithme/util/StringUtils.java | 6 +- android/src/com/mapswithme/util/UiUtils.java | 8 +- android/src/com/mapswithme/util/Utils.java | 14 +- .../src/com/mapswithme/util/log/MemLogging.java | 6 +- .../com/mapswithme/util/sharing/SharingHelper.java | 10 +- .../com/mapswithme/util/statistics/Statistics.java | 14 +- android/tests/monkey/mapswithme.py | 2 +- .../com/mapswithme/maps/tests/MapActivityTest.java | 8 +- 43 files changed, 2345 insertions(+), 2410 deletions(-) delete mode 100644 android/jni/com/mapswithme/maps/MWMApplication.cpp create mode 100644 android/jni/com/mapswithme/maps/MwmApplication.cpp create mode 100644 android/res/layout/activity_download_resources.xml delete mode 100644 android/res/layout/download_resources.xml delete mode 100644 android/src/com/mapswithme/maps/MWMActivity.java delete mode 100644 android/src/com/mapswithme/maps/MWMApplication.java create mode 100644 android/src/com/mapswithme/maps/MwmActivity.java create mode 100644 android/src/com/mapswithme/maps/MwmApplication.java (limited to 'android') diff --git a/android/AndroidManifest.xml b/android/AndroidManifest.xml index 8cdbb0b693..ba12b0d2c8 100644 --- a/android/AndroidManifest.xml +++ b/android/AndroidManifest.xml @@ -51,7 +51,7 @@ android:xlargeScreens="true"/> @@ -179,45 +179,45 @@ android:name="com.mapswithme.country.DownloadActivity" android:configChanges="orientation|screenLayout|screenSize" android:label="@string/download_maps" - android:parentActivityName="com.mapswithme.maps.MWMActivity"> + android:parentActivityName="com.mapswithme.maps.MwmActivity"> + android:value="com.mapswithme.maps.MwmActivity"/> + android:value="com.mapswithme.maps.MwmActivity"/> + android:parentActivityName="com.mapswithme.maps.MwmActivity"> + android:value="com.mapswithme.maps.MwmActivity"/> + android:parentActivityName="com.mapswithme.maps.MwmActivity"> + android:value="com.mapswithme.maps.MwmActivity"/> + android:parentActivityName="com.mapswithme.maps.MwmActivity"> + android:value="com.mapswithme.maps.MwmActivity"/> @@ -140,7 +140,7 @@ NativeFramework()->AddBookmarksFile(jni::ToNativeString(env, path)); diff --git a/android/jni/com/mapswithme/maps/MWMApplication.cpp b/android/jni/com/mapswithme/maps/MWMApplication.cpp deleted file mode 100644 index 137ffd7ea9..0000000000 --- a/android/jni/com/mapswithme/maps/MWMApplication.cpp +++ /dev/null @@ -1,142 +0,0 @@ -/* - * MWMService.cpp - * - * Created on: May 11, 2012 - * Author: siarheirachytski - */ - -#include "Framework.hpp" - -#include "../core/jni_helper.hpp" - -#include "../platform/Platform.hpp" - -#include "map/information_display.hpp" -#include "map/location_state.hpp" - -#include "platform/settings.hpp" - - -extern "C" -{ - JNIEXPORT void JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeInit( - JNIEnv * env, jobject thiz, - jstring apkPath, jstring storagePath, jstring tmpPath, jstring obbGooglePath, - jstring flavorName, jstring buildType, jboolean isYota, jboolean isTablet) - { - android::Platform::Instance().Initialize( - env, apkPath, storagePath, tmpPath, obbGooglePath, flavorName, buildType, isYota, isTablet); - - LOG(LDEBUG, ("Creating android::Framework instance ...")); - - if (!g_framework) - g_framework = new android::Framework(); - - LOG(LDEBUG, ("android::Framework created")); - } - - JNIEXPORT jboolean JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeIsBenchmarking(JNIEnv * env, jobject thiz) - { - return static_cast(g_framework->NativeFramework()->IsBenchmarking()); - } - - JNIEXPORT jboolean JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeGetBoolean(JNIEnv * env, - jobject thiz, - jstring name, - jboolean defaultVal) - { - bool val = defaultVal; - Settings::Get(jni::ToNativeString(env, name), val); - return val; - } - - JNIEXPORT void JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeSetBoolean(JNIEnv * env, - jobject thiz, - jstring name, - jboolean val) - { - bool flag = val; - (void)Settings::Set(jni::ToNativeString(env, name), flag); - } - - JNIEXPORT jboolean JNICALL - Java_com_mapswithme_maps_MWMApplication_hasFreeSpace(JNIEnv * env, jobject thiz, jlong size) - { - return android::Platform::Instance().HasAvailableSpaceForWriting(size); - } - - JNIEXPORT void JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeAddLocalization(JNIEnv * env, jobject thiz, jstring name, jstring value) - { - g_framework->AddString(jni::ToNativeString(env, name), - jni::ToNativeString(env, value)); - } - - JNIEXPORT jint JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeGetInt(JNIEnv * env, jobject thiz, jstring name, jint defaultValue) - { - jint value; - if (Settings::Get(jni::ToNativeString(env, name), value)) - return value; - - return defaultValue; - } - - JNIEXPORT void JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeSetInt(JNIEnv * env, jobject thiz, jstring name, jint value) - { - (void)Settings::Set(jni::ToNativeString(env, name), value); - } - - JNIEXPORT jlong JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeGetLong(JNIEnv * env, jobject thiz, jstring name, jlong defaultValue) - { - jlong value; - if (Settings::Get(jni::ToNativeString(env, name), value)) - return value; - - return defaultValue; - } - - JNIEXPORT void JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeSetLong(JNIEnv * env, jobject thiz, jstring name, jlong value) - { - (void)Settings::Set(jni::ToNativeString(env, name), value); - } - - JNIEXPORT jdouble JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeGetDouble(JNIEnv * env, jobject thiz, jstring name, jdouble defaultValue) - { - jdouble value; - if (Settings::Get(jni::ToNativeString(env, name), value)) - return value; - - return defaultValue; - } - - JNIEXPORT void JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeSetDouble(JNIEnv * env, jobject thiz, jstring name, jdouble value) - { - (void)Settings::Set(jni::ToNativeString(env, name), value); - } - - JNIEXPORT void JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeSetString(JNIEnv * env, jobject thiz, jstring name, jstring value) - { - (void)Settings::Set(jni::ToNativeString(env, name), jni::ToNativeString(env, value)); - } - - JNIEXPORT jstring JNICALL - Java_com_mapswithme_maps_MWMApplication_nativeGetString(JNIEnv * env, jobject thiz, jstring name, jstring defaultValue) - { - string value; - if (Settings::Get(jni::ToNativeString(env, name), value)) - return jni::ToJavaString(env, value); - - return defaultValue; - } -} diff --git a/android/jni/com/mapswithme/maps/MwmApplication.cpp b/android/jni/com/mapswithme/maps/MwmApplication.cpp new file mode 100644 index 0000000000..ee3864c6a2 --- /dev/null +++ b/android/jni/com/mapswithme/maps/MwmApplication.cpp @@ -0,0 +1,142 @@ +/* + * MWMService.cpp + * + * Created on: May 11, 2012 + * Author: siarheirachytski + */ + +#include "Framework.hpp" + +#include "../core/jni_helper.hpp" + +#include "../platform/Platform.hpp" + +#include "map/information_display.hpp" +#include "map/location_state.hpp" + +#include "platform/settings.hpp" + + +extern "C" +{ + JNIEXPORT void JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeInit( + JNIEnv * env, jobject thiz, + jstring apkPath, jstring storagePath, jstring tmpPath, jstring obbGooglePath, + jstring flavorName, jstring buildType, jboolean isYota, jboolean isTablet) + { + android::Platform::Instance().Initialize( + env, apkPath, storagePath, tmpPath, obbGooglePath, flavorName, buildType, isYota, isTablet); + + LOG(LDEBUG, ("Creating android::Framework instance ...")); + + if (!g_framework) + g_framework = new android::Framework(); + + LOG(LDEBUG, ("android::Framework created")); + } + + JNIEXPORT jboolean JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeIsBenchmarking(JNIEnv * env, jobject thiz) + { + return static_cast(g_framework->NativeFramework()->IsBenchmarking()); + } + + JNIEXPORT jboolean JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeGetBoolean(JNIEnv * env, + jobject thiz, + jstring name, + jboolean defaultVal) + { + bool val = defaultVal; + Settings::Get(jni::ToNativeString(env, name), val); + return val; + } + + JNIEXPORT void JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeSetBoolean(JNIEnv * env, + jobject thiz, + jstring name, + jboolean val) + { + bool flag = val; + (void)Settings::Set(jni::ToNativeString(env, name), flag); + } + + JNIEXPORT jboolean JNICALL + Java_com_mapswithme_maps_MwmApplication_hasFreeSpace(JNIEnv * env, jobject thiz, jlong size) + { + return android::Platform::Instance().HasAvailableSpaceForWriting(size); + } + + JNIEXPORT void JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeAddLocalization(JNIEnv * env, jobject thiz, jstring name, jstring value) + { + g_framework->AddString(jni::ToNativeString(env, name), + jni::ToNativeString(env, value)); + } + + JNIEXPORT jint JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeGetInt(JNIEnv * env, jobject thiz, jstring name, jint defaultValue) + { + jint value; + if (Settings::Get(jni::ToNativeString(env, name), value)) + return value; + + return defaultValue; + } + + JNIEXPORT void JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeSetInt(JNIEnv * env, jobject thiz, jstring name, jint value) + { + (void)Settings::Set(jni::ToNativeString(env, name), value); + } + + JNIEXPORT jlong JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeGetLong(JNIEnv * env, jobject thiz, jstring name, jlong defaultValue) + { + jlong value; + if (Settings::Get(jni::ToNativeString(env, name), value)) + return value; + + return defaultValue; + } + + JNIEXPORT void JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeSetLong(JNIEnv * env, jobject thiz, jstring name, jlong value) + { + (void)Settings::Set(jni::ToNativeString(env, name), value); + } + + JNIEXPORT jdouble JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeGetDouble(JNIEnv * env, jobject thiz, jstring name, jdouble defaultValue) + { + jdouble value; + if (Settings::Get(jni::ToNativeString(env, name), value)) + return value; + + return defaultValue; + } + + JNIEXPORT void JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeSetDouble(JNIEnv * env, jobject thiz, jstring name, jdouble value) + { + (void)Settings::Set(jni::ToNativeString(env, name), value); + } + + JNIEXPORT void JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeSetString(JNIEnv * env, jobject thiz, jstring name, jstring value) + { + (void)Settings::Set(jni::ToNativeString(env, name), jni::ToNativeString(env, value)); + } + + JNIEXPORT jstring JNICALL + Java_com_mapswithme_maps_MwmApplication_nativeGetString(JNIEnv * env, jobject thiz, jstring name, jstring defaultValue) + { + string value; + if (Settings::Get(jni::ToNativeString(env, name), value)) + return jni::ToJavaString(env, value); + + return defaultValue; + } +} diff --git a/android/res/layout/activity_download_resources.xml b/android/res/layout/activity_download_resources.xml new file mode 100644 index 0000000000..27c37f1f1a --- /dev/null +++ b/android/res/layout/activity_download_resources.xml @@ -0,0 +1,62 @@ + + + + + + + + + +