From 1729c30fcb8bd453b7c612790a0929de61f35757 Mon Sep 17 00:00:00 2001 From: Alex Zolotarev Date: Wed, 29 Jul 2015 16:03:49 +0300 Subject: Do not store good servers list in the settings. Otherwise if servers have changed, old outdated servers will be loaded from settings and downloading will fail. --- platform/servers_list.cpp | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) (limited to 'platform/servers_list.cpp') diff --git a/platform/servers_list.cpp b/platform/servers_list.cpp index ed72ea3937..f705a6f3f2 100644 --- a/platform/servers_list.cpp +++ b/platform/servers_list.cpp @@ -8,13 +8,10 @@ #include "3party/jansson/myjansson.hpp" - -#define SETTINGS_SERVERS_KEY "LastBaseUrls" - - namespace downloader { +// Returns false if can't parse urls. Note that it also clears outUrls. bool ParseServerList(string const & jsonStr, vector & outUrls) { outUrls.clear(); @@ -37,20 +34,15 @@ bool ParseServerList(string const & jsonStr, vector & outUrls) void GetServerListFromRequest(HttpRequest const & request, vector & urls) { - if (request.Status() == HttpRequest::ECompleted && - ParseServerList(request.Data(), urls)) + if (request.Status() == HttpRequest::ECompleted && ParseServerList(request.Data(), urls)) { - Settings::Set(SETTINGS_SERVERS_KEY, request.Data()); + return; } else { - LOG(LWARNING, ("Can't get servers list from request")); - - string serverList; - if (!Settings::Get(SETTINGS_SERVERS_KEY, serverList)) - serverList = GetPlatform().DefaultUrlsJSON(); - VERIFY ( ParseServerList(serverList, urls), () ); + VERIFY(ParseServerList(GetPlatform().DefaultUrlsJSON(), urls), ()); + LOG(LWARNING, ("Can't get servers list from request, using default servers:", urls)); } } -} +} // namespace downloader -- cgit v1.2.3