diff options
| author | Jongsoo Park <jongsoo@fb.com> | 2019-01-11 21:55:17 +0300 |
|---|---|---|
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | 2019-01-11 21:58:04 +0300 |
| commit | f6e4f991351d16738ebc92ee681cb4eac83d3941 (patch) | |
| tree | 67d87194b15103b5245d98facc0500d86db83f37 | |
| parent | a7ac2769e722767dccbd132ab3d58a9b2f661252 (diff) | |
don't keep conv_param_p member as a const reference (#57)
Summary:
Pull Request resolved: https://github.com/pytorch/FBGEMM/pull/57
conv_p passed to constructors can be destroyed later (it could be allocated on stack).
Reviewed By: dskhudia
Differential Revision: D13619634
fbshipit-source-id: f9e86672b1f49db163ccedde4ab22c12dac2d0f1
| -rw-r--r-- | include/fbgemm/Fbgemm.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/fbgemm/Fbgemm.h b/include/fbgemm/Fbgemm.h index b729d56..bca5347 100644 --- a/include/fbgemm/Fbgemm.h +++ b/include/fbgemm/Fbgemm.h @@ -526,7 +526,7 @@ class FBGEMM_API PackAWithIm2Col } private: - const conv_param_t<SPATIAL_DIM>& conv_p_; + const conv_param_t<SPATIAL_DIM> conv_p_; const T* sdata_; std::int32_t zero_pt_; std::int32_t* row_offset_; @@ -906,7 +906,7 @@ class FBGEMM_API DoSConvOnInpBuffer { private: nextOPType& nextop_; const std::uint8_t* A_; - const conv_param_t<>& conv_p_; + const conv_param_t<> conv_p_; const std::int32_t A_zero_point_; const CompressedSparseColumn& B_csc_; }; |