diff options
author | Jongsoo Park <jongsoo@fb.com> | 2018-11-27 05:29:25 +0300 |
---|---|---|
committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | 2018-11-27 05:31:46 +0300 |
commit | db52c82306e7aa10e2dde706b7205c30eec31cd5 (patch) | |
tree | 621ef3980a420818bb7be328d9e8a8e340bf19bf /include/fbgemm/Fbgemm.h | |
parent | ea47a6966f1ec53eb6f4b30e3ee8160b3a4f066e (diff) |
fix group convention in B packing (#26)
Summary:
Pull Request resolved: https://github.com/pytorch/FBGEMM/pull/26
Set convention that group is the leading (slowest moving) dimension of B.
Reviewed By: dskhudia
Differential Revision: D13176477
fbshipit-source-id: 64d5f168434e7fa0f90b46b0a8559569804c844b
Diffstat (limited to 'include/fbgemm/Fbgemm.h')
-rw-r--r-- | include/fbgemm/Fbgemm.h | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/include/fbgemm/Fbgemm.h b/include/fbgemm/Fbgemm.h index 6dc7a2a..d2c2a1e 100644 --- a/include/fbgemm/Fbgemm.h +++ b/include/fbgemm/Fbgemm.h @@ -373,6 +373,16 @@ class PackBMatrix final : public PackMatrix<PackBMatrix<T, accT>, T, accT> { PackBMatrix() = delete; // no default constructor + /** + * @params groups if > 1 and trans == NoTranspose, smat is nRow x nCol with + * groups are vertically concatenated: each group is + * (nRow / groups) x nCol . + * if > 1 and trans == Transpose, smat is (nCol * groups) x + * (nRow / groups) with groups are horizontally concatenated: + * each group is nCol x (nRow / groups) . Each group is + * transposed and vertically concatenated to match with the + * NoTranspose case. + */ PackBMatrix( matrix_op_t trans, std::int32_t nRow, |