From 685b1855d739868839cd8f774d987c1a4599b138 Mon Sep 17 00:00:00 2001
From: Jianyu Huang <jianyuhuang@fb.com>
Date: Tue, 10 Sep 2019 21:00:43 -0700
Subject: Add assert to ensure the divisor is not 0 (#25960)

Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/25960

Pull Request resolved: https://github.com/pytorch/FBGEMM/pull/124

Reviewed By: dskhudia

Differential Revision: D17292372

fbshipit-source-id: 71a72f87b99c65b3b956bd8361694b1de05fc333
---
 src/FbgemmI8DepthwiseAvx2.cc | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/src/FbgemmI8DepthwiseAvx2.cc b/src/FbgemmI8DepthwiseAvx2.cc
index 4c8d71d..7454ef4 100644
--- a/src/FbgemmI8DepthwiseAvx2.cc
+++ b/src/FbgemmI8DepthwiseAvx2.cc
@@ -2538,6 +2538,14 @@ void depthwise_3x3_pad_1(
     bool fuse_relu,
     int thread_id,
     int num_threads) {
+  if (stride_h == 0 || stride_w == 0 || num_threads == 0) {
+    assert(0 && "stride_h == 0 || stride_w == 0 || num_threads == 0");
+    return;
+  }
+  if (N == 0) {
+    // In C2, batch size 0 is allowed, so we should just early return.
+    return;
+  }
   if (fuse_relu) {
     if (7 == H && 7 == W && 1 == stride_h && 1 == stride_w) {
       depthwise_3x3_pad_1_<true /* FUSE_RELU */>(
@@ -2958,6 +2966,16 @@ void depthwise_3x3x3_pad_1(
     bool fuse_relu,
     int thread_id,
     int num_threads) {
+  if (stride_t == 0 || stride_h == 0 || stride_w == 0 || num_threads == 0) {
+    assert(
+        0 &&
+        "stride_t == 0 || stride_h == 0 || stride_w == 0 || num_threads == 0");
+    return;
+  }
+  if (N == 0) {
+    // In C2, batch size 0 is allowed, so we should just early return.
+    return;
+  }
   if (fuse_relu) {
     depthwise_3x3x3_pad_1_<true /*FUSE_RELU*/>(
         N,
@@ -3158,6 +3176,14 @@ void depthwise_3x3_per_channel_quantization_pad_1(
     bool fuse_relu,
     int thread_id,
     int num_threads) {
+  if (stride_h == 0 || stride_w == 0 || num_threads == 0) {
+    assert(0 && "stride_h == 0 || stride_w == 0 || num_threads == 0");
+    return;
+  }
+  if (N == 0) {
+    // In C2, batch size 0 is allowed, so we should just early return.
+    return;
+  }
   if (fuse_relu) {
     if (7 == H && 7 == W && 1 == stride_h && 1 == stride_w) {
       depthwise_3x3_per_channel_quantization_pad_1_<true /* FUSE_RELU */>(
@@ -3524,6 +3550,16 @@ void depthwise_3x3x3_per_channel_quantization_pad_1(
     bool fuse_relu,
     int thread_id,
     int num_threads) {
+  if (stride_t == 0 || stride_h == 0 || stride_w == 0 || num_threads == 0) {
+    assert(
+        0 &&
+        "stride_t == 0 || stride_h == 0 || stride_w == 0 || num_threads == 0");
+    return;
+  }
+  if (N == 0) {
+    // In C2, batch size 0 is allowed, so we should just early return.
+    return;
+  }
   if (fuse_relu) {
     depthwise_3x3x3_per_channel_quantization_pad_1_<true /* FUSE_RELU */>(
         N,
-- 
cgit v1.2.3