Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/matomo-org/matomo.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Steur <thomas.steur@gmail.com>2015-03-31 01:26:28 +0300
committerThomas Steur <thomas.steur@gmail.com>2015-03-31 05:27:07 +0300
commitbcf12baf6307283e9895b8bf0567d5bc21a08c9f (patch)
tree406d970f69fb0c08e6347b4479646b6a5a3580aa
parentbe9dc8ecb9c74d515a1d510fddf09bbbb455fe5a (diff)
fix broken tests
-rw-r--r--core/DataTable.php4
-rwxr-xr-xtests/PHPUnit/System/OneVisitorOneWebsiteSeveralDaysDateRangeArchivingTestsTest.php7
-rwxr-xr-xtests/PHPUnit/System/TwoVisitsWithCustomVariablesSegmentMatchVisitorTypeTest.php15
-rw-r--r--tests/PHPUnit/Unit/Archive/ChunkTest.php2
4 files changed, 14 insertions, 14 deletions
diff --git a/core/DataTable.php b/core/DataTable.php
index efe05a4d7c..c4cfb95730 100644
--- a/core/DataTable.php
+++ b/core/DataTable.php
@@ -1322,14 +1322,14 @@ class DataTable implements DataTableInterface, \IteratorAggregate, \ArrayAccess
if (is_array($rows[self::ID_SUMMARY_ROW])) {
$this->summaryRow = new Row($rows[self::ID_SUMMARY_ROW]);
} elseif (isset($rows[self::ID_SUMMARY_ROW]->c)) {
- $this->summaryRow = new Row($rows[self::ID_SUMMARY_ROW]->c);
+ $this->summaryRow = new Row($rows[self::ID_SUMMARY_ROW]->c); // Pre Piwik 2.13
}
unset($rows[self::ID_SUMMARY_ROW]);
}
foreach ($rows as $id => $row) {
if (isset($row->c)) {
- $this->addRow(new Row($row->c));
+ $this->addRow(new Row($row->c)); // Pre Piwik 2.13
} else {
$this->addRow(new Row($row));
}
diff --git a/tests/PHPUnit/System/OneVisitorOneWebsiteSeveralDaysDateRangeArchivingTestsTest.php b/tests/PHPUnit/System/OneVisitorOneWebsiteSeveralDaysDateRangeArchivingTestsTest.php
index d879c07fb7..83110d149a 100755
--- a/tests/PHPUnit/System/OneVisitorOneWebsiteSeveralDaysDateRangeArchivingTestsTest.php
+++ b/tests/PHPUnit/System/OneVisitorOneWebsiteSeveralDaysDateRangeArchivingTestsTest.php
@@ -182,15 +182,16 @@ class OneVisitorOneWebsiteSeveralDaysDateRangeArchivingTest extends SystemTestCa
'archive_blob_2011_01' => 3,
);
$chunk = new Chunk();
+ $chunkName = $chunk->getRecordNameForTableId('Actions_actions_url', 0);
+
foreach ($tests as $table => $expectedNumSubtables) {
- $chunkAppendix = $chunk->getRecordNameForTableId(0);
- $sql = "SELECT value FROM " . Common::prefixTable($table) . " WHERE period = " . Piwik::$idPeriods['range'] . " and `name` ='Actions_actions_url_$chunkAppendix'";
+ $sql = "SELECT value FROM " . Common::prefixTable($table) . " WHERE period = " . Piwik::$idPeriods['range'] . " and `name` ='$chunkName'";
$blob = Db::get()->fetchOne($sql);
$blob = gzuncompress($blob);
$blob = unserialize($blob);
$countSubtables = count($blob);
- $this->assertEquals($expectedNumSubtables, $countSubtables, "Actions_actions_url_subtables in $table expected to contain $expectedNumSubtables subtables, got $countSubtables");
+ $this->assertEquals($expectedNumSubtables, $countSubtables, "Actions_actions_url_chunk_0_99 in $table expected to contain $expectedNumSubtables subtables, got $countSubtables");
}
}
diff --git a/tests/PHPUnit/System/TwoVisitsWithCustomVariablesSegmentMatchVisitorTypeTest.php b/tests/PHPUnit/System/TwoVisitsWithCustomVariablesSegmentMatchVisitorTypeTest.php
index a2c1d06672..05f6ef79d9 100755
--- a/tests/PHPUnit/System/TwoVisitsWithCustomVariablesSegmentMatchVisitorTypeTest.php
+++ b/tests/PHPUnit/System/TwoVisitsWithCustomVariablesSegmentMatchVisitorTypeTest.php
@@ -117,24 +117,23 @@ class TwoVisitsWithCustomVariablesSegmentMatchVisitorTypeTest extends SystemTest
public function test_checkArchiveRecords_shouldMergeSubtablesIntoOneRow()
{
$chunk = new Chunk();
- $chunkBlobId = $chunk->getRecordNameForTableId(0);
$tests = array(
'archive_blob_2010_01' => array(
- 'CustomVariables_valueByName_' . $chunkBlobId => 6,
- 'Referrers_keywordBySearchEngine_' . $chunkBlobId => 1,
- 'Referrers_searchEngineByKeyword_' . $chunkBlobId => 1,
+ $chunk->getRecordNameForTableId('CustomVariables_valueByName', 0) => 6,
+ $chunk->getRecordNameForTableId('Referrers_keywordBySearchEngine', 0) => 1,
+ $chunk->getRecordNameForTableId('Referrers_searchEngineByKeyword', 0) => 1
),
'archive_blob_2009_12' => array(
- 'CustomVariables_valueByName_' . $chunkBlobId => 6,
- 'Referrers_keywordBySearchEngine_' . $chunkBlobId => 1,
- 'Referrers_searchEngineByKeyword_' . $chunkBlobId => 1,
+ $chunk->getRecordNameForTableId('CustomVariables_valueByName', 0) => 6,
+ $chunk->getRecordNameForTableId('Referrers_keywordBySearchEngine', 0) => 1,
+ $chunk->getRecordNameForTableId('Referrers_searchEngineByKeyword', 0) => 1,
)
);
$numTests = 0;
foreach ($tests as $table => $expectedSubtables) {
foreach ($expectedSubtables as $name => $expectedNumSubtables) {
- $sql = "SELECT `value` FROM " . Common::prefixTable($table) . " WHERE `name` ='$name'";
+ $sql = "SELECT `value` FROM " . Common::prefixTable($table) . " WHERE `name` ='$name'";
$blobs = Db::get()->fetchAll($sql);
foreach ($blobs as $blob) {
diff --git a/tests/PHPUnit/Unit/Archive/ChunkTest.php b/tests/PHPUnit/Unit/Archive/ChunkTest.php
index dcab94c267..3518d5d87f 100644
--- a/tests/PHPUnit/Unit/Archive/ChunkTest.php
+++ b/tests/PHPUnit/Unit/Archive/ChunkTest.php
@@ -40,7 +40,7 @@ class ChunkTest extends UnitTestCase
$this->assertEquals($this->recordName . '_chunk_' . $expectedChunk, $this->chunk->getRecordNameForTableId($this->recordName, $tableId));
}
- public function getRecordNameForTableId()
+ public function getRecordNameForTableIdDataProvider()
{
return array(
array($expectedChunk = '0_99', $tableId = 0),