diff options
author | Thomas Steur <thomas.steur@googlemail.com> | 2014-08-22 12:16:09 +0400 |
---|---|---|
committer | Thomas Steur <thomas.steur@googlemail.com> | 2014-08-22 12:16:09 +0400 |
commit | 1236b19f5640d0bfab931fb5ca28a8c1d5e6ccc2 (patch) | |
tree | 1eec29b540c0b3c0778c97f21611850425c819b9 | |
parent | d079edfc7eaf000e9e9d1f71cf0b7cc12dff6e8c (diff) |
refs #4996 just read in the specs only the name is required
-rw-r--r-- | misc/internal-docs/content-tracking.md | 2 | ||||
-rw-r--r-- | plugins/Contents/Actions/ActionContent.php | 3 |
2 files changed, 2 insertions, 3 deletions
diff --git a/misc/internal-docs/content-tracking.md b/misc/internal-docs/content-tracking.md index 63dc1762ee..fb11ac732d 100644 --- a/misc/internal-docs/content-tracking.md +++ b/misc/internal-docs/content-tracking.md @@ -28,7 +28,7 @@ Impressions are logically not really events and I don't think it makes sense to * or would we create an action entry for each piece of content? --> yes I think! * New Action class that handles type content * New url parameters like `c_p`, `c_n` and `c_u` for piece of content, name and url. Maybe instead of `c_u` would be better `c_t` for target which is more generic. Sending a JSON array would not work since we cannot log multiple actions in one tracking request. They have to be sent using bulk tracking instead. - * `c_c` and `c_n` would be required, `c_t` not as for instance a piece of content does not necessarily have a target (hard to measure a click ratio in this case?) +* Only `c_n` would be required, `c_p` and `c_t` not as for instance a piece of content does not necessarily have a target (hard to measure a click ratio in this case?) ## Tracking the clicks diff --git a/plugins/Contents/Actions/ActionContent.php b/plugins/Contents/Actions/ActionContent.php index 0fba02a698..e018bff3ec 100644 --- a/plugins/Contents/Actions/ActionContent.php +++ b/plugins/Contents/Actions/ActionContent.php @@ -28,10 +28,9 @@ class ActionContent extends Action public static function shouldHandle(Request $request) { - $piece = $request->getParam('c_p'); $name = $request->getParam('c_n'); - return !empty($piece) && !empty($name); + return !empty($name); } protected function getActionsToLookup() |