ignore invalid segment when computing hash in SegmentEditor.getAll (#17241)

1 files changed, 6 insertions, 2 deletions

diff --git a/plugins/SegmentEditor/API.php b/plugins/SegmentEditor/API.php
index 0565f29cdc..99f6585039 100644
--- a/plugins/SegmentEditor/API.php
+++ b/plugins/SegmentEditor/API.php
@@ -394,8 +394,12 @@ class API extends \Piwik\Plugin\API
         $allIdSites = $model->getSitesId();
         foreach ($segments as &$segmentInfo) {
             $idSites = !empty($segmentInfo['enable_only_idsite']) ? [(int) $segmentInfo['enable_only_idsite']] : $allIdSites;
-            $segmentObj = new Segment(urlencode($segmentInfo['definition']), $idSites);
-            $segmentInfo['hash'] = $segmentObj->getHash();
+            try {
+                $segmentObj = new Segment(urlencode($segmentInfo['definition']), $idSites);
+                $segmentInfo['hash'] = $segmentObj->getHash();
+            } catch (\Exception $ex) {
+                $segmentInfo['hash'] = 'INVALID SEGMENT';
+            }
         }
 
         return $segments;