Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/matomo-org/matomo.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorsgiehl <stefan@piwik.org>2014-11-21 21:21:58 +0300
committersgiehl <stefan@piwik.org>2014-11-21 21:21:58 +0300
commit6c620042b50c6004af140c48cb284d069fa66039 (patch)
treeb3005b6ff2397d7cf482dfcc515169304994b3b5
parent6dd9a9298933cd6aa7c8a3b442a4ddc8a680c521 (diff)
parent45d93549932aba2b6891f91d1be84c3b7572cf0c (diff)
Merge branch 'master' into deprecate_usersettings
-rw-r--r--CHANGELOG.md5
-rw-r--r--LEGALNOTICE8
-rw-r--r--core/SettingsPiwik.php12
-rw-r--r--core/Tracker/Visitor.php13
-rw-r--r--core/Translate/Filter/ByParameterCount.php3
-rw-r--r--core/Updates/2.9.0-b7.php3
-rw-r--r--core/Version.php2
-rw-r--r--lang/fr.json2
-rw-r--r--lang/tl.json2
-rw-r--r--plugins/Actions/Reports/Base.php4
-rw-r--r--plugins/CoreConsole/Commands/GitCommit.php3
-rw-r--r--plugins/CoreConsole/Commands/GitPull.php3
-rw-r--r--plugins/CoreConsole/Commands/GitPush.php3
-rw-r--r--plugins/CorePluginsAdmin/Controller.php11
-rw-r--r--plugins/CorePluginsAdmin/Menu.php2
-rw-r--r--plugins/CorePluginsAdmin/javascripts/pluginExtend.js2
-rw-r--r--plugins/CorePluginsAdmin/lang/de.json1
-rw-r--r--plugins/CorePluginsAdmin/lang/en.json14
-rw-r--r--plugins/CorePluginsAdmin/lang/it.json1
-rw-r--r--plugins/CorePluginsAdmin/stylesheets/marketplace.less8
-rw-r--r--plugins/CorePluginsAdmin/templates/browsePlugins.twig10
-rw-r--r--plugins/CorePluginsAdmin/templates/browsePluginsActions.twig15
-rw-r--r--plugins/CorePluginsAdmin/templates/browseThemes.twig3
-rw-r--r--plugins/CorePluginsAdmin/templates/extend.twig70
-rw-r--r--plugins/CorePluginsAdmin/templates/plugins.twig3
-rw-r--r--plugins/CoreUpdater/lang/fr.json2
-rw-r--r--plugins/Feedback/lang/fr.json2
-rw-r--r--plugins/Installation/lang/fr.json56
-rwxr-xr-xplugins/LanguagesManager/tests/Integration/LanguagesManagerTest.php7
-rw-r--r--plugins/ScheduledReports/API.php1
-rw-r--r--plugins/SitesManager/lang/fr.json2
-rw-r--r--plugins/TestRunner/Commands/TestsRunOnAws.php3
-rwxr-xr-xtests/PHPUnit/Framework/TestCase/SystemTestCase.php7
-rw-r--r--tests/PHPUnit/Framework/TestRequest/Collection.php2
m---------tests/PHPUnit/UI0
-rw-r--r--tests/PHPUnit/Unit/Translate/Filter/ByParameterCountTest.php15
36 files changed, 134 insertions, 166 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index ca06a6b99f..cd16152b51 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,7 +2,7 @@
This is a changelog for Piwik platform developers. All changes for our HTTP API's, Plugins, Themes, etc will be listed here.
-## Piwik 2.10.0
+## Piwik 2.9.1
### Breaking Changes
* The HTTP Tracker API does now respond with a HTTP 400 instead of a HTTP 500 in case an invalid `idsite` or `forcedVisitorId` is used.
@@ -10,6 +10,9 @@ This is a changelog for Piwik platform developers. All changes for our HTTP API'
### New APIs
* New URL parameter `send_image=0` in the [HTTP Tracking API](http://developer.piwik.org/api-reference/tracking-api) to receive a HTTP 204 response code instead of a GIF image. This improves performance and can fix errors if images are not allowed to be obtained directly (eg Chrome Apps).
+### New commands
+* `core:plugin list` lists all plugins currently activated in Piwik.
+
## Piwik 2.9.0
### Breaking Changes
diff --git a/LEGALNOTICE b/LEGALNOTICE
index 041aea3089..e6c5a1e9c0 100644
--- a/LEGALNOTICE
+++ b/LEGALNOTICE
@@ -255,10 +255,6 @@ THIRD-PARTY CONTENT
Notes:
- used in ImageGraph plugin
- Name: plugins/CorePluginsAdmin/images/themes.png
- Link: https://www.iconfinder.com/icons/17022/colors_draw_paint_icon
- License: Free for commercial use
-
Name: plugins/Feedback/angularjs/ratefeature/thumbs-down.png
Link: https://www.iconfinder.com/icons/216428/down_thumbs_icon
License: Creative Commons (Attribution-Share Alike 3.0 Unported)
@@ -267,10 +263,6 @@ THIRD-PARTY CONTENT
Link: https://www.iconfinder.com/icons/216429/thumbs_up_icon
License: Creative Commons (Attribution-Share Alike 3.0 Unported)
- Name: plugins/CorePluginsAdmin/images/plugins.png
- Link: http://findicons.com/icon/94051/tools_wizard?id=396912
- License: GNU/GPL
-
Name: plugins/Insights/images/idea.png
Link: https://www.iconfinder.com/icons/6074/brainstorm_bulb_idea_jabber_light_icon
License: GPL
diff --git a/core/SettingsPiwik.php b/core/SettingsPiwik.php
index 26949c560a..23780a0701 100644
--- a/core/SettingsPiwik.php
+++ b/core/SettingsPiwik.php
@@ -336,6 +336,17 @@ class SettingsPiwik
}
}
+ /**
+ * Returns true if Piwik is deployed using git
+ * FAQ: http://piwik.org/faq/how-to-install/faq_18271/
+ *
+ * @return bool
+ */
+ public static function isGitDeployment()
+ {
+ return file_exists(PIWIK_INCLUDE_PATH . '/.git/HEAD');
+ }
+
public static function getCurrentGitBranch()
{
$file = PIWIK_INCLUDE_PATH . '/.git/HEAD';
@@ -422,4 +433,5 @@ class SettingsPiwik
{
return Config::getInstance()->General['force_ssl'] == 1;
}
+
}
diff --git a/core/Tracker/Visitor.php b/core/Tracker/Visitor.php
index afec61849e..d9aadb640e 100644
--- a/core/Tracker/Visitor.php
+++ b/core/Tracker/Visitor.php
@@ -204,20 +204,17 @@ class Visitor
$fields[] = $dimension->getColumnName();
}
- /**
- * This event collects a list of [visit entity]() properties that should be loaded when reading
- * the existing visit. Properties that appear in this list will be available in other tracking
- * events such as 'onExistingVisit'.
- *
- * Plugins can use this event to load additional visit entity properties for later use during tracking.
- */
foreach ($dimension->getRequiredVisitFields() as $field) {
$fields[] = $field;
}
}
/**
- * @ignore
+ * This event collects a list of [visit entity](/guides/persistence-and-the-mysql-backend#visits) properties that should be loaded when reading
+ * the existing visit. Properties that appear in this list will be available in other tracking
+ * events such as 'onExistingVisit'.
+ *
+ * Plugins can use this event to load additional visit entity properties for later use during tracking.
*/
Piwik::postEvent('Tracker.getVisitFieldsToPersist', array(&$fields));
diff --git a/core/Translate/Filter/ByParameterCount.php b/core/Translate/Filter/ByParameterCount.php
index 74be50d26d..357ab5ba33 100644
--- a/core/Translate/Filter/ByParameterCount.php
+++ b/core/Translate/Filter/ByParameterCount.php
@@ -43,7 +43,8 @@ class ByParameterCount extends FilterAbstract
if (isset($this->baseTranslations[$pluginName][$key])) {
$baseTranslation = $this->baseTranslations[$pluginName][$key];
} else {
- $baseTranslation = '';
+ // english string was deleted, do not error
+ continue;
}
// ensure that translated strings have the same number of %s as the english source strings
diff --git a/core/Updates/2.9.0-b7.php b/core/Updates/2.9.0-b7.php
index 1efcf8360c..110545aaa8 100644
--- a/core/Updates/2.9.0-b7.php
+++ b/core/Updates/2.9.0-b7.php
@@ -47,7 +47,8 @@ class Updates_2_9_0_b7 extends Updates
}
$query = self::getQueryToCreateSequence($table, $maxId);
- $sql[$query] = false;
+ // refs #6696, ignores Integrity constraint violation: 1062 Duplicate entry 'piwik_archive_numeric_2010_01' for key 'PRIMARY'
+ $sql[$query] = '1062';
}
}
diff --git a/core/Version.php b/core/Version.php
index 488428843c..80614277c5 100644
--- a/core/Version.php
+++ b/core/Version.php
@@ -20,5 +20,5 @@ final class Version
* The current Piwik version.
* @var string
*/
- const VERSION = '2.9.1-b1';
+ const VERSION = '2.9.1';
}
diff --git a/lang/fr.json b/lang/fr.json
index f2361a2504..982d7d02b1 100644
--- a/lang/fr.json
+++ b/lang/fr.json
@@ -128,7 +128,7 @@
"DisplayTableWithMoreMetrics": "Afficher un tableau avec plus d'unités",
"Documentation": "Documentation",
"Donate": "Donner",
- "Done": "Fait",
+ "Done": "Effectué",
"Download": "Télécharger",
"DownloadFail_FileExists": "Le fichier %s existe déjà!",
"DownloadFail_FileExistsContinue": "Téléchargement partiel en cours pour %s, mais un téléchargement terminé existe déjà!",
diff --git a/lang/tl.json b/lang/tl.json
index 4be4cdb74e..fffcf0e8d3 100644
--- a/lang/tl.json
+++ b/lang/tl.json
@@ -447,4 +447,4 @@
"PickAnotherRow": "Pumili ng isa pang row upang ihambing",
"PickARow": "Pumili ng row upang ihambing"
}
-}
+} \ No newline at end of file
diff --git a/plugins/Actions/Reports/Base.php b/plugins/Actions/Reports/Base.php
index fb1158e6a9..36fd1d67c6 100644
--- a/plugins/Actions/Reports/Base.php
+++ b/plugins/Actions/Reports/Base.php
@@ -66,7 +66,9 @@ abstract class Base extends \Piwik\Plugin\Report
));
// prettify avg_time_on_page column
- $getPrettyTimeFromSeconds = '\Piwik\MetricsFormatter::getPrettyTimeFromSeconds';
+ $getPrettyTimeFromSeconds = function ($time) {
+ return MetricsFormatter::getPrettyTimeFromSeconds($time, $timeAsSentence = false);
+ };
$view->config->filters[] = array('ColumnCallbackReplace', array('avg_time_on_page', $getPrettyTimeFromSeconds));
// prettify avg_time_generation column
diff --git a/plugins/CoreConsole/Commands/GitCommit.php b/plugins/CoreConsole/Commands/GitCommit.php
index 5b3dc4ca30..451ecb72ff 100644
--- a/plugins/CoreConsole/Commands/GitCommit.php
+++ b/plugins/CoreConsole/Commands/GitCommit.php
@@ -11,6 +11,7 @@ namespace Piwik\Plugins\CoreConsole\Commands;
use Piwik\Development;
use Piwik\Plugin\ConsoleCommand;
+use Piwik\SettingsPiwik;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
@@ -21,7 +22,7 @@ class GitCommit extends ConsoleCommand
{
public function isEnabled()
{
- return Development::isEnabled();
+ return Development::isEnabled() && SettingsPiwik::isGitDeployment();
}
protected function configure()
diff --git a/plugins/CoreConsole/Commands/GitPull.php b/plugins/CoreConsole/Commands/GitPull.php
index 65151e2e3c..e69c13bf10 100644
--- a/plugins/CoreConsole/Commands/GitPull.php
+++ b/plugins/CoreConsole/Commands/GitPull.php
@@ -11,6 +11,7 @@ namespace Piwik\Plugins\CoreConsole\Commands;
use Piwik\Development;
use Piwik\Plugin\ConsoleCommand;
+use Piwik\SettingsPiwik;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
@@ -20,7 +21,7 @@ class GitPull extends ConsoleCommand
{
public function isEnabled()
{
- return Development::isEnabled();
+ return SettingsPiwik::isGitDeployment();
}
protected function configure()
diff --git a/plugins/CoreConsole/Commands/GitPush.php b/plugins/CoreConsole/Commands/GitPush.php
index 25c838e08c..006becaa5c 100644
--- a/plugins/CoreConsole/Commands/GitPush.php
+++ b/plugins/CoreConsole/Commands/GitPush.php
@@ -11,6 +11,7 @@ namespace Piwik\Plugins\CoreConsole\Commands;
use Piwik\Development;
use Piwik\Plugin\ConsoleCommand;
+use Piwik\SettingsPiwik;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
@@ -20,7 +21,7 @@ class GitPush extends ConsoleCommand
{
public function isEnabled()
{
- return Development::isEnabled();
+ return Development::isEnabled() && SettingsPiwik::isGitDeployment();
}
protected function configure()
diff --git a/plugins/CorePluginsAdmin/Controller.php b/plugins/CorePluginsAdmin/Controller.php
index 02020c710d..0a7a497d46 100644
--- a/plugins/CorePluginsAdmin/Controller.php
+++ b/plugins/CorePluginsAdmin/Controller.php
@@ -205,17 +205,6 @@ class Controller extends Plugin\ControllerAdmin
return $view->render();
}
- public function extend()
- {
- static::dieIfMarketplaceIsDisabled();
-
- $view = $this->configureView('@CorePluginsAdmin/extend');
- $view->installNonce = Nonce::getNonce(static::INSTALL_NONCE);
- $view->isSuperUser = Piwik::hasUserSuperUserAccess();
-
- return $view->render();
- }
-
private function createPluginsOrThemesView($template, $themesOnly)
{
Piwik::checkUserHasSuperUserAccess();
diff --git a/plugins/CorePluginsAdmin/Menu.php b/plugins/CorePluginsAdmin/Menu.php
index 8279afcc73..bda9caa9db 100644
--- a/plugins/CorePluginsAdmin/Menu.php
+++ b/plugins/CorePluginsAdmin/Menu.php
@@ -55,7 +55,7 @@ class Menu extends \Piwik\Plugin\Menu
if ($this->isAllowedToSeeMarketPlace()) {
$menu->addPlatformItem('CorePluginsAdmin_Marketplace',
- $this->urlForAction('extend', array('activated' => '')),
+ $this->urlForAction('browsePlugins', array('activated' => '')),
$order = 5);
}
diff --git a/plugins/CorePluginsAdmin/javascripts/pluginExtend.js b/plugins/CorePluginsAdmin/javascripts/pluginExtend.js
index 5c93452dee..ecaf872504 100644
--- a/plugins/CorePluginsAdmin/javascripts/pluginExtend.js
+++ b/plugins/CorePluginsAdmin/javascripts/pluginExtend.js
@@ -7,7 +7,7 @@
$(document).ready(function () {
- $('.extendPlatform .uploadPlugin').click(function (event) {
+ $('.pluginslistActionBar .uploadPlugin').click(function (event) {
event.preventDefault();
piwikHelper.modalConfirm('#installPluginByUpload', {
diff --git a/plugins/CorePluginsAdmin/lang/de.json b/plugins/CorePluginsAdmin/lang/de.json
index 64e34bd3fc..b4ac6ac8e4 100644
--- a/plugins/CorePluginsAdmin/lang/de.json
+++ b/plugins/CorePluginsAdmin/lang/de.json
@@ -47,6 +47,7 @@
"MarketplaceSellPluginSubject": "Marketplace - Plugin verkaufen",
"MenuPlatform": "Plattform",
"MissingRequirementsNotice": "Bitte aktualisieren Sie %1$s %2$s auf eine neuere Version, %1$s %3$s wird benötigt.",
+ "MissingRequirementsPleaseInstallNotice": "Bitte installiere %1$s %2$s da es von %3$s benötigt wird.",
"NoPluginsFound": "Keine Plugins gefunden",
"NotAllowedToBrowseMarketplacePlugins": "Sie können die Liste der installierbaren Plugins durchforsten, um sie für Ihre Plattform anzupassen oder zu erweitern. Bitte kontaktieren Sie Ihren Administrator, wenn Sie eines dieser Plugins installiert haben möchten.",
"NotAllowedToBrowseMarketplaceThemes": "Sie können die Liste der installierbaren Themes durchforsten, um das Erscheinungsbild Ihrer Plattform anzupassen. Bitte kontaktieren Sie Ihren Administrator wenn Sie eines dieser Themes installiert haben möchten.",
diff --git a/plugins/CorePluginsAdmin/lang/en.json b/plugins/CorePluginsAdmin/lang/en.json
index dc13e89f8d..6ce90f0e0f 100644
--- a/plugins/CorePluginsAdmin/lang/en.json
+++ b/plugins/CorePluginsAdmin/lang/en.json
@@ -14,23 +14,17 @@
"BackToExtendPiwik": "Back to Marketplace",
"BeCarefulUsingPlugins": "Plugins that are not authored by Piwik team must be used with care: we did not review them.",
"BeCarefulUsingThemes": "Themes that are not authored by Piwik team must be used with care: we did not review them.",
- "ByDesigningOwnTheme": "by %sdesigning your own theme%s",
- "ByInstallingNewPluginFromMarketplace": "by %sinstalling a new plugin from the Marketplace%s",
- "ByInstallingNewThemeFromMarketplace": "by %sinstalling a new theme from the Marketplace%s",
- "ByWritingOwnPlugin": "by %swriting your own plugin%s",
"ByXDevelopers": "by %s developers",
"Changelog": "Changelog",
"ChangeSettingsPossible": "You can change %ssettings%s for this plugin.",
"CorePluginTooltip": "Core plugins have no version since they are distributed with Piwik.",
"Deactivate": "Deactivate",
"Developer": "Developer",
+ "DevelopersLearnHowToDevelopPlugins": "Developers: Learn how you can extend and customize Piwik by %sdeveloping plugins or themes%s.",
"DoMoreContactPiwikAdmins": "To install a new plugin or a new theme, please get in touch with your Piwik admins.",
- "DownloadAndInstallPluginsFromMarketplace": "You may automatically download and install new Plugins from the %sMarketplace%s.",
"EmailToEnquireUpdatedVersion": "Please email %1$s and enquire an updated version of %2$s.",
- "EnjoyAnotherLookAndFeelOfThemes": "Enjoy another look & feel",
"FeaturedPlugin": "Featured plugin",
"GetEarlyAccessForPaidPlugins": "Note: all plugins are available for free at present; in the future we will enable Paid Plugins in the Marketplace (%scontact us%s for early access).",
- "GetNewFunctionality": "Get new functionality",
"History": "History",
"Inactive": "Inactive",
"InfoPluginUpdateIsRecommended": "Update your plugins now to benefit from the latest improvements.",
@@ -42,7 +36,8 @@
"LastCommitTime": "(last commit %s)",
"LastUpdated": "Last Updated",
"LicenseHomepage": "License Homepage",
- "MainDescription": "Plugins extend and expand the functionality of Piwik. Once a plugin is installed, you may activate it or deactivate it here.",
+ "PluginsExtendPiwik": "Plugins extend and expand the functionality of Piwik.",
+ "OncePluginIsInstalledYouMayActivateHere": "Once a plugin is installed, you may activate it or deactivate it here.",
"Marketplace": "Marketplace",
"MarketplaceSellPluginSubject": "Marketplace - Sell Plugin",
"MenuPlatform": "Platform",
@@ -55,8 +50,6 @@
"NoZipFileSelected": "Please select a ZIP file.",
"NumDownloadsLatestVersion": "Latest version: %s Downloads",
"NumUpdatesAvailable": "%s Update(s) available",
- "OrByUploadingAPlugin": "or by %suploading a plugin%s",
- "OrByUploadingATheme": "or by %suploading a theme%s",
"Origin": "Origin",
"OriginCore": "Core",
"OriginThirdParty": "Third-party",
@@ -91,6 +84,7 @@
"TeaserExtendPiwikByPlugin": "Extend Piwik by installing a new plugin",
"TeaserExtendPiwikByTheme": "Enjoy another look & feel by installing a new theme",
"TeaserExtendPiwikByUpload": "Extend Piwik by uploading a ZIP file",
+ "InstallingNewPluginViaMarketplaceOrUpload": "You may automatically install plugins from the Marketplace or %supload a plugin%s in .zip format.",
"Theme": "Theme",
"Themes": "Themes",
"ThemesDescription": "Themes can change the appearance of Piwik user interface, and provide a completely new visual experience to enjoy your analytics reports.",
diff --git a/plugins/CorePluginsAdmin/lang/it.json b/plugins/CorePluginsAdmin/lang/it.json
index 566a3753ad..46cab54bf5 100644
--- a/plugins/CorePluginsAdmin/lang/it.json
+++ b/plugins/CorePluginsAdmin/lang/it.json
@@ -47,6 +47,7 @@
"MarketplaceSellPluginSubject": "Marketplace - Vendita Plugin",
"MenuPlatform": "Piattaforma",
"MissingRequirementsNotice": "Aggiorna %1$s %2$s a una versione più recente, è richiesto %1$s %3$s.",
+ "MissingRequirementsPleaseInstallNotice": "Si prega di installare %1$s %2$s come richiesto da %3$s.",
"NoPluginsFound": "Non sono stati trovati plugin",
"NotAllowedToBrowseMarketplacePlugins": "Puoi esplorare la lista dei plugin che possono essere installati per personalizzare o espandere la tua piattaforma Piwik. Contatta il tuo amministratore se desideri installarne qualcuno.",
"NotAllowedToBrowseMarketplaceThemes": "Puoi esplorare la lista dei temi che possono essere installati per personalizzare l'aspetto della tua piattaforma Piwik. Contatta il tuo amministratore se desideri che ne installi qualcuno.",
diff --git a/plugins/CorePluginsAdmin/stylesheets/marketplace.less b/plugins/CorePluginsAdmin/stylesheets/marketplace.less
index 7146c84217..119634da9d 100644
--- a/plugins/CorePluginsAdmin/stylesheets/marketplace.less
+++ b/plugins/CorePluginsAdmin/stylesheets/marketplace.less
@@ -214,6 +214,13 @@
}
}
+.pluginFooterMessage {
+ float:left;
+ margin-top:30px;
+ line-height: 2em;
+ font-style: italic;
+}
+
.pluginslistNonSuperUserHint {
margin-top: 30px;
margin-bottom: 30px;
@@ -239,6 +246,7 @@
.infoBox {
margin: 0px 0px 20px 0px;
+ line-height: 1.5em;
}
}
diff --git a/plugins/CorePluginsAdmin/templates/browsePlugins.twig b/plugins/CorePluginsAdmin/templates/browsePlugins.twig
index 63845bf73d..9259081a0c 100644
--- a/plugins/CorePluginsAdmin/templates/browsePlugins.twig
+++ b/plugins/CorePluginsAdmin/templates/browsePlugins.twig
@@ -10,6 +10,9 @@
>{{ 'CorePluginsAdmin_TeaserExtendPiwikByPlugin'|translate }}</h2>
<div class="infoBox">
+ {{ 'CorePluginsAdmin_PluginsExtendPiwik'|translate }}
+ {{ 'CorePluginsAdmin_InstallingNewPluginViaMarketplaceOrUpload'|translate('<a href="#" class="uploadPlugin">','</a>')|raw }}
+ <br/>
{{ 'CorePluginsAdmin_BeCarefulUsingPlugins'|translate }}
</div>
@@ -47,4 +50,11 @@
{{ 'CorePluginsAdmin_NoPluginsFound'|translate }}
{% endif %}
</div>
+
+ <div class="pluginFooterMessage">
+ {% set marketplaceSellPluginSubject = 'CorePluginsAdmin_MarketplaceSellPluginSubject'|translate %}
+ {{ 'CorePluginsAdmin_GetEarlyAccessForPaidPlugins'|translate("<a href='mailto:hello@piwik.org?subject=" ~ marketplaceSellPluginSubject ~ "'>", "</a>")|raw }}
+ <br/>
+ {{ 'CorePluginsAdmin_DevelopersLearnHowToDevelopPlugins'|translate('<a href="?module=Proxy&action=redirect&url=http://developer.piwik.org/plugins" target="_blank">', '</a>')|raw }}
+ </div>
{% endblock %}
diff --git a/plugins/CorePluginsAdmin/templates/browsePluginsActions.twig b/plugins/CorePluginsAdmin/templates/browsePluginsActions.twig
index be1a69c798..1ccbafb057 100644
--- a/plugins/CorePluginsAdmin/templates/browsePluginsActions.twig
+++ b/plugins/CorePluginsAdmin/templates/browsePluginsActions.twig
@@ -1,3 +1,18 @@
+<div class="ui-confirm" id="installPluginByUpload">
+ <h2>{{ 'CorePluginsAdmin_TeaserExtendPiwikByUpload'|translate }}</h2>
+
+ <p class="description"> {{ 'CorePluginsAdmin_AllowedUploadFormats'|translate }} </p>
+
+ <form enctype="multipart/form-data"
+ method="post"
+ id="uploadPluginForm"
+ action="{{ linkTo({'action':'uploadPlugin', 'nonce': installNonce}) }}">
+ <input type="file" name="pluginZip">
+ <br />
+ <input class="startUpload" type="submit" value="{{ 'CorePluginsAdmin_UploadZipFile'|translate }}">
+ </form>
+</div>
+
<div class="sort">
<a href="{{ linkTo({'sort': 'popular', 'query': ''}) }}" {% if 'popular' == sort %}class="active"{% endif %}>{{ 'CorePluginsAdmin_SortByPopular'|translate }}</a>
|
diff --git a/plugins/CorePluginsAdmin/templates/browseThemes.twig b/plugins/CorePluginsAdmin/templates/browseThemes.twig
index 2f834247a0..685ef4ebb3 100644
--- a/plugins/CorePluginsAdmin/templates/browseThemes.twig
+++ b/plugins/CorePluginsAdmin/templates/browseThemes.twig
@@ -9,6 +9,9 @@
>{{ 'CorePluginsAdmin_TeaserExtendPiwikByTheme'|translate }}</h2>
<div class="infoBox">
+ {{ 'CorePluginsAdmin_ThemesDescription'|translate }}
+ {{ 'CorePluginsAdmin_InstallingNewPluginViaMarketplaceOrUpload'|translate('<a href="#" class="uploadPlugin">','</a>')|raw }}
+ <br/>
{{ 'CorePluginsAdmin_BeCarefulUsingThemes'|translate }}
</div>
diff --git a/plugins/CorePluginsAdmin/templates/extend.twig b/plugins/CorePluginsAdmin/templates/extend.twig
deleted file mode 100644
index b95b6018c8..0000000000
--- a/plugins/CorePluginsAdmin/templates/extend.twig
+++ /dev/null
@@ -1,70 +0,0 @@
-{% extends 'admin.twig' %}
-
-{% import '@CorePluginsAdmin/macros.twig' as plugins %}
-
-{% block content %}
- <div class="extendPlatform">
-
- <div class="ui-confirm" id="installPluginByUpload">
- <h2>{{ 'CorePluginsAdmin_TeaserExtendPiwikByUpload'|translate }}</h2>
-
- <p class="description"> {{ 'CorePluginsAdmin_AllowedUploadFormats'|translate }} </p>
-
- <form enctype="multipart/form-data"
- method="post"
- id="uploadPluginForm"
- action="{{ linkTo({'action':'uploadPlugin', 'nonce': installNonce}) }}">
- <input type="file" name="pluginZip">
- <br />
- <input class="startUpload" type="submit" value="{{ 'CorePluginsAdmin_UploadZipFile'|translate }}">
- </form>
- </div>
-
- <div class="introduction">
-
- <h2 piwik-enriched-headline
- feature-name="{{ 'CorePluginsAdmin_Marketplace'|translate }}"
- >{{ 'CorePluginsAdmin_TeaserExtendPiwik'|translate }}</h2>
-
- <p>{{ 'CorePluginsAdmin_DownloadAndInstallPluginsFromMarketplace'|translate("<a href='?module=Proxy&action=redirect&url=http://plugins.piwik.org/' target='_blank'>", "</a>")|raw }}</p>
-
- {% set marketplaceSellPluginSubject = 'CorePluginsAdmin_MarketplaceSellPluginSubject'|translate %}
- <em>{{ 'CorePluginsAdmin_GetEarlyAccessForPaidPlugins'|translate("<a href='mailto:hello@piwik.org?subject=" ~ marketplaceSellPluginSubject ~ "'>", "</a>")|raw }}</em>
- </div>
-
- <div>
- <div class="byPlugins">
- <h3 class="header">{{ 'CorePluginsAdmin_GetNewFunctionality'|translate }}</h3>
- <span class="callToAction">{{ 'CorePluginsAdmin_ByInstallingNewPluginFromMarketplace'|translate("<a href=" ~ linkTo({'action':'browsePlugins', 'sort': ''}) ~ ">", "</a>")|raw }}</span>
-
- <p>
- <a href="{{ linkTo({'action':'browsePlugins', 'sort': ''}) }}"><img class="teaserImage" title="{{ 'CorePluginsAdmin_InstallNewPlugins'|translate }}" alt="{{ 'CorePluginsAdmin_InstallNewPlugins'|translate }}" src="plugins/CorePluginsAdmin/images/plugins.png"/></a>
- </p>
-
- <span class="callToAction">
- {{ 'CorePluginsAdmin_ByWritingOwnPlugin'|translate('<a href="http://developer.piwik.org/guides/getting-started-part-1" target="_blank">', '</a>')|raw }}
- {% if isSuperUser %}
- <br/>{{ 'CorePluginsAdmin_OrByUploadingAPlugin'|translate('<a href="#" class="uploadPlugin">', '</a>')|raw }}
- {% endif %}
- </span>
-
- </div>
-
- <div class="byThemes">
- <h3 class="header">{{ 'CorePluginsAdmin_EnjoyAnotherLookAndFeelOfThemes'|translate }}</h3>
- <span class="callToAction">{{ 'CorePluginsAdmin_ByInstallingNewThemeFromMarketplace'|translate("<a href=" ~ linkTo({'action':'browseThemes', 'sort': ''}) ~ ">", "</a>")|raw }}</span>
-
- <p>
- <a href="{{ linkTo({'action':'browseThemes', 'sort': ''}) }}"><img class="teaserImage" alt="{{ 'CorePluginsAdmin_InstallNewThemes'|translate }}" title="{{ 'CorePluginsAdmin_InstallNewThemes'|translate }}" src="plugins/CorePluginsAdmin/images/themes.png"/></a>
- </p>
-
- <span class="callToAction">
- {{ 'CorePluginsAdmin_ByDesigningOwnTheme'|translate('<a href="http://developer.piwik.org/guides/theming" target="_blank">', '</a>')|raw }}
- {% if isSuperUser %}
- <br />{{ 'CorePluginsAdmin_OrByUploadingATheme'|translate('<a href="#" class="uploadPlugin">', '</a>')|raw }}
- {% endif %}
- </span>
- </div>
- </div>
- </div>
-{% endblock %}
diff --git a/plugins/CorePluginsAdmin/templates/plugins.twig b/plugins/CorePluginsAdmin/templates/plugins.twig
index 4eeb7ee032..4c4b6b1192 100644
--- a/plugins/CorePluginsAdmin/templates/plugins.twig
+++ b/plugins/CorePluginsAdmin/templates/plugins.twig
@@ -15,7 +15,8 @@
<h2 piwik-enriched-headline>{{ 'CorePluginsAdmin_PluginsManagement'|translate }}</h2>
- <p>{{ 'CorePluginsAdmin_MainDescription'|translate }}
+ <p>{{ 'CorePluginsAdmin_PluginsExtendPiwik'|translate }}
+ {{ 'CorePluginsAdmin_OncePluginIsInstalledYouMayActivateHere'|translate }}
{% if not isPluginsAdminEnabled %}
<br/>{{ 'CorePluginsAdmin_DoMoreContactPiwikAdmins'|translate }}
diff --git a/plugins/CoreUpdater/lang/fr.json b/plugins/CoreUpdater/lang/fr.json
index b616864f19..f69376aab3 100644
--- a/plugins/CoreUpdater/lang/fr.json
+++ b/plugins/CoreUpdater/lang/fr.json
@@ -34,7 +34,7 @@
"NotificationSubjectAvailableCoreUpdate": "Piwik %s est maintenant disponible",
"NotificationSubjectAvailablePluginUpdate": "Mises à jour disponibles pour vos plugins Piwik",
"PiwikHasBeenSuccessfullyUpgraded": "Piwik a été mis à jour avec succès !",
- "PiwikUpdatedSuccessfully": "Piwik a été mis à jour avec succès!",
+ "PiwikUpdatedSuccessfully": "Piwik a été mis à jour avec succès !",
"PiwikWillBeUpgradedFromVersionXToVersionY": "La base de données de Piwik sera mise à jour depuis la version %1$s vers la version %2$s.",
"PluginDescription": "Mécanisme de mise à jour Piwik",
"ReadyToGo": "Prêt à démarrer?",
diff --git a/plugins/Feedback/lang/fr.json b/plugins/Feedback/lang/fr.json
index 2136a366e2..ab06a7ad79 100644
--- a/plugins/Feedback/lang/fr.json
+++ b/plugins/Feedback/lang/fr.json
@@ -2,7 +2,7 @@
"Feedback": {
"ContactThePiwikTeam": "Contactez l’Équipe Piwik!",
"DoYouHaveBugReportOrFeatureRequest": "Avez-vous un bug à rapporter ou une fonctionnalité à demander ?",
- "GetInTouch": "Nous apprécions vos commentaires et lisons tous les messages. Peut-être voudriez vous nous informer d'une opportunité commerciale, employer un consultant, nous raconter un succès ou simplement dire bonjour!",
+ "GetInTouch": "Nous apprécions vos commentaires et lisons tous les messages. Peut-être voudriez vous nous informer d'une opportunité commerciale, employer un consultant, nous raconter un succès ou simplement dire bonjour !",
"HowToCreateTicket": "Veuillez consulter les recommandations sur la rédaction d'un bon %1$srapport de bug%2$s ou %3$sdemande de fonctionnalité%4$s. Puis s'enregistrer ou se connecter sur %5$snotre système de suivit des incidents%6$s et créer un %7$snouvel incident%8$s.",
"IWantTo": "Je veux:",
"LearnWaysToParticipate": "Renseignez vous sur les manières dont vous pouvez %s participer%s",
diff --git a/plugins/Installation/lang/fr.json b/plugins/Installation/lang/fr.json
index fcf10917c5..797aca29f8 100644
--- a/plugins/Installation/lang/fr.json
+++ b/plugins/Installation/lang/fr.json
@@ -6,25 +6,25 @@
"ConfigurationHelp": "Votre configuration de Piwik semble être erronée. Vous pouvez ou bien supprimer config\/config.inc.php et reprendre l'installation ou corriger les paramètres de connexion.",
"ConfirmDeleteExistingTables": "Êtes vous sûr de vouloir supprimer les tables %s de votre base de données ? ATTENTION : LES DONNÉES SERONT DÉFINITIVEMENT PERDUES !",
"Congratulations": "Félicitations",
- "CongratulationsHelp": "<p>Félicitations! Votre installation de Piwik est terminée.<\/p><p>Assurez-vous que le code JavaScript est présent sur toutes vos pages et attendez vos premiers visiteurs!<\/p>",
+ "CongratulationsHelp": "<p>Félicitations ! Votre installation de Piwik est terminée.<\/p><p>Assurez-vous que le code JavaScript est présent sur toutes vos pages et attendez vos premiers visiteurs !<\/p>",
"DatabaseAbilities": "Capacités de la base de données",
"DatabaseCreation": "Création de la base de données",
"DatabaseErrorConnect": "Erreur lors de la tentative de connexion au serveur de base de données",
"DatabaseServerVersion": "Version du serveur de base de données",
"DatabaseSetup": "Installation de la base de données",
- "DatabaseSetupAdapter": "adaptateur",
- "DatabaseSetupDatabaseName": "nom de la base",
- "DatabaseSetupLogin": "compte",
- "DatabaseSetupServer": "serveur de la base de données",
- "DatabaseSetupTablePrefix": "préfixe des tables",
+ "DatabaseSetupAdapter": "Adaptateur",
+ "DatabaseSetupDatabaseName": "Nom de la base",
+ "DatabaseSetupLogin": "Compte utilisateur",
+ "DatabaseSetupServer": "Serveur de base de données",
+ "DatabaseSetupTablePrefix": "Préfixe des tables",
"DefaultSettings": "Paramétrage par défaut",
"DefaultSettingsHelp": "Piwik est installé avec un paramétrage par défaut. Vous pouvez personnaliser ces réglages maintenant ou le faire plus tard dans l'espace d'administration.",
- "Email": "courriel",
- "Extension": "extension",
+ "Email": "Courriel",
+ "Extension": "Extension",
"Filesystem": "Système de fichiers",
"GetInvolved": "Si vous aimez ce que vous voyez, vous pouvez %1$svous impliquer%2$s.",
"GoBackAndDefinePrefix": "Retournez à la page précédente et définissez le préfixe pour les tables Piwik",
- "HappyAnalysing": "Bonne analyse!",
+ "HappyAnalysing": "Bonne analyse !",
"Installation": "Installation",
"InstallationStatus": "Statut de l'installation",
"InsufficientPrivilegesHelp": "Vous pouvez donner ces droits en utilisant un outils tel que phpMyAdmin ou en exécutant les requêtes SQL appropriées. Si vous ne savez pas comment effectuer cela veuillez demander à votre administrateur système de donner ces droits pour vous.",
@@ -42,11 +42,11 @@
"NoConfigFound": "Le fichier de configuration de Piwik ne peut être trouvé et vous essayez d'accéder à une page de Piwik.<br> <b>  » Vous pouvez <a href='index.php'>installer Piwik maintenant<\/a><\/b><br><small>Si vous avez déjà installé Piwik ne vous inquiétez pas Piwik réutilisera ces tables et leurs données.<\/small>",
"NotSupported": "non supporté",
"Optional": "Optionnel",
- "Password": "mot de passe",
+ "Password": "Mot de passe",
"PasswordDoNotMatch": "Le mot de passe ne concorde pas",
- "PasswordRepeat": "mot de passe (à nouveau)",
- "PercentDone": "%s %% Fait",
- "PiwikOrgNewsletter": "envoyez moi des courriels pour les mises à jour importantes de Piwik",
+ "PasswordRepeat": "Mot de passe (à nouveau)",
+ "PercentDone": "%s %% complété",
+ "PiwikOrgNewsletter": "Envoyez moi des courriels pour les mises à jour importantes de Piwik",
"PiwikProNewsletter": "Je suis intéressé par les services %sPiwik PRO%s (pas plus d'un courriel par mois)",
"PleaseFixTheFollowingErrors": "Merci de corriger les erreurs suivantes",
"PluginDescription": "Procédé d'installation de Piwik. L'installation est effectuée une unique fois. Si le fichier de configuration config\/config.inc.php est supprimé, l'installation recommencera.",
@@ -56,20 +56,20 @@
"SeeBelowForMoreInfo": "Voir ci-dessous pour plus d'informations.",
"SetupWebsite": "Paramétrer un site",
"SetupWebsiteError": "Une erreur a été rencontrée pendant l'ajout du site",
- "SetupWebSiteName": "nom du site web",
- "SetupWebsiteSetupSuccess": "Site %s créé avec succès!",
+ "SetupWebSiteName": "Nom du site web",
+ "SetupWebsiteSetupSuccess": "Site %s créé avec succès !",
"SetupWebSiteURL": "URL du site web",
"SiteSetup": "Veuillez configurer le premier site web que vous voulez suivre et analyser avc Piwik :",
- "SiteSetupFootnote": "Note : une fois que l'installation de Piwik est terminée, vous pourrez ajouter d'autres sites web à suivre!",
+ "SiteSetupFootnote": "Note : une fois que l'installation de Piwik est terminée, vous pourrez ajouter d'autres sites web à suivre !",
"SuperUser": "Super Utilisateur",
- "SuperUserLogin": "login du super user",
+ "SuperUserLogin": "Login du super utilisateur",
"SuperUserSetupError": "Erreur lors de l'ajout du super utilisateur.",
- "SuperUserSetupSuccess": "Super Utilisateur créé avec succès!",
+ "SuperUserSetupSuccess": "Super utilisateur créé avec succès !",
"SystemCheck": "Vérification du système",
"SystemCheckAutoUpdateHelp": "Note : La mise à jour de Piwik en un clic requiert une permission en écriture sur le dossier de Piwik et son contenu.",
"SystemCheckCreateFunctionHelp": "Piwik utilise des fonctions anonymes pour les callbacks.",
"SystemCheckCronArchiveProcess": "Tâche Cron d'archivage",
- "SystemCheckCronArchiveProcessCLI": "Gestion des processus via ligne de commande",
+ "SystemCheckCronArchiveProcessCLI": "Gestion des processus la via ligne de commande",
"SystemCheckDatabaseHelp": "Piwik requiert ou l'extension mysqli ou les extensions pdo et pdo_mysql.",
"SystemCheckDebugBacktraceHelp": "View::factory ne pourra pas créer des vues pour le module appelé.",
"SystemCheckError": "Une erreur s'est produite — elle doit être corrigée avant de pouvoir continuer",
@@ -100,8 +100,8 @@
"SystemCheckPhpPdoAndMysqli": "Plus d'informations sur: %1$sPHP PDO%2$s et %3$sMYSQLI%4$s.",
"SystemCheckSessionAutostart": "Pour éviter certains problèmes veuillez définir le paramètre suivant dans votre fichier php.ini : session.auto_start=0",
"SystemCheckSplHelp": "Vous devez configurer et recompiler PHP avec la librairie standard (par défaut).",
- "SystemCheckSummaryNoProblems": "Génial! Il n'y a aucun problème avec votre installation de Piwik. Donnez vous une tape dans le dos.",
- "SystemCheckSummaryThereWereErrors": "Oh-oh! Piwik a détecté des %1$sproblèmes critiques%2$s avec votre installation de Piwik. %3$sCes problèmes critiques doivent être fixés immédiatement.%4$s",
+ "SystemCheckSummaryNoProblems": "Génial ! Il n'y a aucun problème avec votre installation de Piwik. Donnez-vous une tape dans le dos.",
+ "SystemCheckSummaryThereWereErrors": "Oh-oh ! Piwik a détecté des %1$sproblèmes critiques%2$s avec votre installation de Piwik. %3$sCes problèmes critiques doivent être fixés immédiatement.%4$s",
"SystemCheckSummaryThereWereWarnings": "Il y a des problèmes avec votre système. Piwik va fonctionner, mais vous pourriez rencontrer des problèmes mineurs.",
"SystemCheckTimeLimitHelp": "Sur un site à trafic important, le processus d'archivage peut prendre plus de temps qu'il n'est déjà autorisé.<br \/> Référez-vous à la configuration max_execution_time de votre php.ini si nécessaire.",
"SystemCheckTracker": "Statut du traqueur",
@@ -116,18 +116,18 @@
"SystemCheckWriteDirsHelp": "Pour corriger les erreurs sur votre système Linux essayez de taper les commandes suivantes",
"SystemCheckZlibHelp": "Vous devez reconfigurer et recompiler PHP avec le support zlib, --with-zlib.",
"Tables": "Création des tables",
- "TablesCreatedSuccess": "Tables créées avec succès!",
+ "TablesCreatedSuccess": "Tables créées avec succès !",
"TablesDelete": "Supprimer les tables détectées",
- "TablesDeletedSuccess": "Tables Piwik existantes supprimées avec succès",
+ "TablesDeletedSuccess": "Les tables Piwik existantes ont été supprimées avec succès",
"TablesFound": "Les tables suivantes ont été trouvées dans la base de données",
"TablesReuse": "Réutiliser les tables existantes",
- "TablesUpdatedSuccess": "La base de données a été mise à jour avec succès de la version %1$s à %2$s!",
+ "TablesUpdatedSuccess": "La base de données a été mise à jour avec succès de la version %1$s à %2$s !",
"TablesWarningHelp": "Vous pouvez choisir de réutiliser les tables de la base de données existante ou sélectionner une nouvelle installation pour effacer toutes les données existantes dans la base de données.",
- "TablesWithSameNamesFound": "Environ %1$s tables dans votre base de données %2$s ont le même nom que celles que Piwik essaie de créer.",
- "Timezone": "fuseau horaire du site web",
+ "TablesWithSameNamesFound": "Des %1$s tables dans votre base de données %2$s ont le même nom que celles que Piwik essaie de créer.",
+ "Timezone": "Fuseau horaire du site web",
"WeHopeYouWillEnjoyPiwik": "Nous espérons que vous allez aimer utiliser Piwik autant que nous aimons le concevoir.",
- "Welcome": "Bienvenue!",
+ "Welcome": "Bienvenue !",
"WelcomeHelp": "<p>Piwik est une application d'analyse du web Open Source qui vous permet d'obtenir facilement les informations que vous désirez sur vos visiteurs.<\/p>\t<p>Ce procédé est divisé en %s étapes faciles et vous prendra 5 minutes environ.<\/p>",
- "WelcomeToCommunity": "Bienvenue dans la communauté Piwik!"
+ "WelcomeToCommunity": "Bienvenue dans la communauté Piwik !"
}
} \ No newline at end of file
diff --git a/plugins/LanguagesManager/tests/Integration/LanguagesManagerTest.php b/plugins/LanguagesManager/tests/Integration/LanguagesManagerTest.php
index 3ed219acf4..7b41c3f55e 100755
--- a/plugins/LanguagesManager/tests/Integration/LanguagesManagerTest.php
+++ b/plugins/LanguagesManager/tests/Integration/LanguagesManagerTest.php
@@ -99,10 +99,11 @@ class LanguagesManagerTest extends \PHPUnit_Framework_TestCase
if ($translationWriter->wasFiltered()) {
$translationWriter->saveTemporary();
- $this->fail(implode("\n", $translationWriter->getFilterMessages()) . "\n"
+ $this->markTestSkipped(implode("\n", $translationWriter->getFilterMessages()) . "\n"
. 'Translation file errors detected in ' . $language . "...\n"
- . "To overwrite you could manually fix the language files, or run the following command may work if you have access to oTrance: \n"
- . "$ ./console translations:update [--plugin=XYZ] \n");
+ . "To synchronise the language files with the english strings, you can manually edit the language files or run the following command may work if you have access to oTrance: \n"
+ . "$ ./console translations:update [--plugin=XYZ] \n"
+ );
}
}
diff --git a/plugins/ScheduledReports/API.php b/plugins/ScheduledReports/API.php
index e8a105114b..3798c166da 100644
--- a/plugins/ScheduledReports/API.php
+++ b/plugins/ScheduledReports/API.php
@@ -335,6 +335,7 @@ class API extends \Piwik\Plugin\API
if ($apiAction == 'getAll') {
$_GET['filter_truncate'] = false;
+ $_GET['filter_limit'] = -1; // show all websites in all websites report
// when a view/admin user created a report, workaround the fact that "Super User"
// is enforced in Scheduled tasks, and ensure Multisites.getAll only return the websites that this user can access
diff --git a/plugins/SitesManager/lang/fr.json b/plugins/SitesManager/lang/fr.json
index 31a8192778..c7b0f04d6f 100644
--- a/plugins/SitesManager/lang/fr.json
+++ b/plugins/SitesManager/lang/fr.json
@@ -67,7 +67,7 @@
"SuperUserAccessCan": "Un utilisateur avec un accès super utilisateur peut aussi %sconfigurer les paramètres globaux%s pour les nouveaux sites web.",
"Timezone": "Fuseau horaire",
"TrackingSiteSearch": "Suivi de la recherche interne sur le site",
- "TrackingTags": "Tags de suivi pour %s",
+ "TrackingTags": "Code de suivi pour %s",
"Urls": "URLs",
"UTCTimeIs": "L'heure UTC est %s.",
"WebsitesManagement": "Gestion des sites",
diff --git a/plugins/TestRunner/Commands/TestsRunOnAws.php b/plugins/TestRunner/Commands/TestsRunOnAws.php
index 3e99e05a6b..495ecfa461 100644
--- a/plugins/TestRunner/Commands/TestsRunOnAws.php
+++ b/plugins/TestRunner/Commands/TestsRunOnAws.php
@@ -16,6 +16,7 @@ use Piwik\Plugins\TestRunner\Aws\Instance;
use Piwik\Plugins\TestRunner\Aws\Ssh;
use Piwik\Plugins\TestRunner\Runner\InstanceLauncher;
use Piwik\Plugins\TestRunner\Runner\Remote;
+use Piwik\SettingsPiwik;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
@@ -143,7 +144,7 @@ This feature is still beta and there might be problems with pictures and/or bina
private function getCurrentGitHash()
{
// we should not use 'git' executable unless we are in a git clone
- if(!file_exists(PIWIK_INCLUDE_PATH . '/.git/')) {
+ if(!SettingsPiwik::isGitDeployment()) {
return 'WARN: it does not look like a Piwik repository clone - you must setup Piwik from git to proceed';
}
return trim(`git rev-parse HEAD`);
diff --git a/tests/PHPUnit/Framework/TestCase/SystemTestCase.php b/tests/PHPUnit/Framework/TestCase/SystemTestCase.php
index 96b60cab0a..879fc915e2 100755
--- a/tests/PHPUnit/Framework/TestCase/SystemTestCase.php
+++ b/tests/PHPUnit/Framework/TestCase/SystemTestCase.php
@@ -432,7 +432,7 @@ abstract class SystemTestCase extends PHPUnit_Framework_TestCase
$this->changeLanguage($testConfig->language);
}
- $testRequests = new Collection($api, $testConfig, $api);
+ $testRequests = $this->getTestRequestsCollection($api, $testConfig, $api);
foreach ($testRequests->getRequestUrls() as $apiId => $requestUrl) {
$this->_testApiUrl($testName . $testConfig->testSuffix, $apiId, $requestUrl, $testConfig->compareAgainst, $testConfig->xmlFieldsToRemove, $params);
@@ -460,6 +460,11 @@ abstract class SystemTestCase extends PHPUnit_Framework_TestCase
return count($this->comparisonFailures) == 0;
}
+ protected function getTestRequestsCollection($api, $testConfig, $api)
+ {
+ return new Collection($api, $testConfig, $api);
+ }
+
private function printComparisonFailures()
{
$messages = '';
diff --git a/tests/PHPUnit/Framework/TestRequest/Collection.php b/tests/PHPUnit/Framework/TestRequest/Collection.php
index 0e9c565d80..e05ef7d5cd 100644
--- a/tests/PHPUnit/Framework/TestRequest/Collection.php
+++ b/tests/PHPUnit/Framework/TestRequest/Collection.php
@@ -288,7 +288,7 @@ class Collection
return $result;
}
- private function shouldSkipApiMethod($moduleName, $methodName) {
+ protected function shouldSkipApiMethod($moduleName, $methodName) {
$apiId = $moduleName . '.' . $methodName;
// If Api to test were set, we only test these
diff --git a/tests/PHPUnit/UI b/tests/PHPUnit/UI
-Subproject c50b2f20931782a8aef10fceb1c5f90f2f547b3
+Subproject 81e01e6c9f0e5c8938a725a416bc6c7c7d26543
diff --git a/tests/PHPUnit/Unit/Translate/Filter/ByParameterCountTest.php b/tests/PHPUnit/Unit/Translate/Filter/ByParameterCountTest.php
index 220e90f9a6..b014b0a9f1 100644
--- a/tests/PHPUnit/Unit/Translate/Filter/ByParameterCountTest.php
+++ b/tests/PHPUnit/Unit/Translate/Filter/ByParameterCountTest.php
@@ -10,6 +10,9 @@ namespace Piwik\Tests\Unit\Translate\Filter;
use Piwik\Translate\Filter\ByParameterCount;
+/**
+ * @group ByParameterCountTest
+ */
class ByParameterCountTest extends \PHPUnit_Framework_TestCase
{
public function getFilterTestData()
@@ -44,11 +47,7 @@ class ByParameterCountTest extends \PHPUnit_Framework_TestCase
'key' => 'value',
)
),
- array(
- 'test' => array(
- 'test' => 'test',
- )
- ),
+ array(),
array(
'test' => array(
'key' => 'val%sue',
@@ -97,9 +96,6 @@ class ByParameterCountTest extends \PHPUnit_Framework_TestCase
'empty' => array(
'test' => 't%1$sest'
),
- 'test' => array(
- 'empty' => ' ',
- )
),
array(
'test' => array(
@@ -118,7 +114,8 @@ class ByParameterCountTest extends \PHPUnit_Framework_TestCase
{
$filter = new ByParameterCount($baseTranslations);
$result = $filter->filter($translations);
- $this->assertEquals($expected, $result);
+ $message = sprintf("got %s but expected %s", var_export($result, true), var_export($expected, true));
+ $this->assertEquals($expected, $result, $message);
$this->assertEquals($filteredData, $filter->getFilteredData());
}
}