diff options
author | mattab <matthieu.aubry@gmail.com> | 2014-01-21 06:48:37 +0400 |
---|---|---|
committer | mattab <matthieu.aubry@gmail.com> | 2014-01-21 06:48:37 +0400 |
commit | 9297b1674d692b7092bd9d26c7b1e26aa85e75d0 (patch) | |
tree | 3f7a20d352b6ca91e1da9e1fd169579f33569de3 | |
parent | 4eb2fe0e46d33a5e56ab794036617b3bcd8b16a6 (diff) |
Removing unused parameter to getEvolutionGraph
-rw-r--r-- | plugins/ExampleUI/Controller.php | 4 | ||||
-rw-r--r-- | plugins/Goals/Controller.php | 6 | ||||
-rw-r--r-- | plugins/MultiSites/Controller.php | 2 | ||||
-rw-r--r-- | plugins/Referrers/Controller.php | 4 | ||||
m--------- | plugins/TasksTimetable | 0 | ||||
-rw-r--r-- | plugins/VisitFrequency/Controller.php | 4 | ||||
-rw-r--r-- | plugins/VisitsSummary/Controller.php | 4 | ||||
m--------- | tests/PHPUnit/UI | 0 |
8 files changed, 12 insertions, 12 deletions
diff --git a/plugins/ExampleUI/Controller.php b/plugins/ExampleUI/Controller.php index bbe6e23b12..555f2f2a88 100644 --- a/plugins/ExampleUI/Controller.php +++ b/plugins/ExampleUI/Controller.php @@ -49,7 +49,7 @@ class Controller extends \Piwik\Plugin\Controller $view = new View('@ExampleUI/evolutiongraph'); $this->setPeriodVariablesView($view); - $view->evolutionGraph = $this->getEvolutionGraph(true, array('server1', 'server2')); + $view->evolutionGraph = $this->getEvolutionGraph(array('server1', 'server2')); return $view->render(); } @@ -81,7 +81,7 @@ class Controller extends \Piwik\Plugin\Controller return $view->render(); } - public function getEvolutionGraph($fetch = false, array $columns = array()) + public function getEvolutionGraph(array $columns = array()) { if (empty($columns)) { $columns = Common::getRequestVar('columns'); diff --git a/plugins/Goals/Controller.php b/plugins/Goals/Controller.php index 6c3a6287b8..e55ea756fb 100644 --- a/plugins/Goals/Controller.php +++ b/plugins/Goals/Controller.php @@ -143,7 +143,7 @@ class Controller extends \Piwik\Plugin\Controller $view->idGoal = $idGoal; $view->goalName = $goalDefinition['name']; $view->goalAllowMultipleConversionsPerVisit = $goalDefinition['allow_multiple']; - $view->graphEvolution = $this->getEvolutionGraph(true, array('nb_conversions'), $idGoal); + $view->graphEvolution = $this->getEvolutionGraph(array('nb_conversions'), $idGoal); $view->nameGraphEvolution = 'Goals.getEvolutionGraph' . $idGoal; $view->topDimensions = $this->getTopDimensions($idGoal); @@ -192,7 +192,7 @@ class Controller extends \Piwik\Plugin\Controller $view = new View('@Goals/getOverviewView'); $this->setGeneralVariablesView($view); - $view->graphEvolution = $this->getEvolutionGraph(true, array('nb_conversions')); + $view->graphEvolution = $this->getEvolutionGraph(array('nb_conversions')); $view->nameGraphEvolution = 'GoalsgetEvolutionGraph'; // sparkline for the historical data of the above values @@ -250,7 +250,7 @@ class Controller extends \Piwik\Plugin\Controller return $view->render(); } - public function getEvolutionGraph($fetch = false, array $columns = array(), $idGoal = false) + public function getEvolutionGraph(array $columns = array(), $idGoal = false) { if (empty($columns)) { $columns = Common::getRequestVar('columns'); diff --git a/plugins/MultiSites/Controller.php b/plugins/MultiSites/Controller.php index ff15758e5d..8870395ef3 100644 --- a/plugins/MultiSites/Controller.php +++ b/plugins/MultiSites/Controller.php @@ -183,7 +183,7 @@ class Controller extends \Piwik\Plugin\Controller } } - public function getEvolutionGraph($fetch = false, $columns = false) + public function getEvolutionGraph($columns = false) { if (empty($columns)) { $columns = Common::getRequestVar('columns'); diff --git a/plugins/Referrers/Controller.php b/plugins/Referrers/Controller.php index e5f1cf6e27..531baf29ed 100644 --- a/plugins/Referrers/Controller.php +++ b/plugins/Referrers/Controller.php @@ -30,7 +30,7 @@ class Controller extends \Piwik\Plugin\Controller { $view = new View('@Referrers/index'); - $view->graphEvolutionReferrers = $this->getEvolutionGraph(true, Common::REFERRER_TYPE_DIRECT_ENTRY, array('nb_visits')); + $view->graphEvolutionReferrers = $this->getEvolutionGraph(Common::REFERRER_TYPE_DIRECT_ENTRY, array('nb_visits')); $view->nameGraphEvolutionReferrers = 'Referrers.getEvolutionGraph'; // building the referrers summary report @@ -256,7 +256,7 @@ class Controller extends \Piwik\Plugin\Controller Common::REFERRER_TYPE_CAMPAIGN => 'Referrers_Campaigns', ); - public function getEvolutionGraph($fetch = false, $typeReferrer = false, array $columns = array()) + public function getEvolutionGraph($typeReferrer = false, array $columns = array()) { $view = $this->getLastUnitGraph($this->pluginName, __FUNCTION__, 'Referrers.getReferrerType'); diff --git a/plugins/TasksTimetable b/plugins/TasksTimetable -Subproject b7f0eb31164be8ce88aa2f99a7f94bdf2d56c7e +Subproject 1bc95298af8f4416f2a9e74a6a1179fd0dbf390 diff --git a/plugins/VisitFrequency/Controller.php b/plugins/VisitFrequency/Controller.php index f746553b3e..ce23d04186 100644 --- a/plugins/VisitFrequency/Controller.php +++ b/plugins/VisitFrequency/Controller.php @@ -24,7 +24,7 @@ class Controller extends \Piwik\Plugin\Controller function index() { $view = new View('@VisitFrequency/index'); - $view->graphEvolutionVisitFrequency = $this->getEvolutionGraph(true, array('nb_visits_returning')); + $view->graphEvolutionVisitFrequency = $this->getEvolutionGraph(array('nb_visits_returning')); $this->setSparklinesAndNumbers($view); return $view->render(); } @@ -36,7 +36,7 @@ class Controller extends \Piwik\Plugin\Controller return $view->render(); } - public function getEvolutionGraph($fetch = false, array $columns = array()) + public function getEvolutionGraph(array $columns = array()) { if (empty($columns)) { $columns = Common::getRequestVar('columns'); diff --git a/plugins/VisitsSummary/Controller.php b/plugins/VisitsSummary/Controller.php index d9e6549b04..bfb4df29ed 100644 --- a/plugins/VisitsSummary/Controller.php +++ b/plugins/VisitsSummary/Controller.php @@ -29,7 +29,7 @@ class Controller extends \Piwik\Plugin\Controller { $view = new View('@VisitsSummary/index'); $this->setPeriodVariablesView($view); - $view->graphEvolutionVisitsSummary = $this->getEvolutionGraph(true, array('nb_visits')); + $view->graphEvolutionVisitsSummary = $this->getEvolutionGraph(array('nb_visits')); $this->setSparklinesAndNumbers($view); return $view->render(); } @@ -42,7 +42,7 @@ class Controller extends \Piwik\Plugin\Controller return $view->render(); } - public function getEvolutionGraph($fetch = false, array $columns = array()) + public function getEvolutionGraph(array $columns = array()) { if (empty($columns)) { $columns = Common::getRequestVar('columns'); diff --git a/tests/PHPUnit/UI b/tests/PHPUnit/UI -Subproject 18b26cf763a9ca443ba792feeab1d5fe0fa6223 +Subproject 620830b7d37c68d1858d1a26bb36df22ce41faa |