require PIWIK_PRINT_ERROR_BACKTRACE for exception backtraces in logs (#16640)

* require PIWIK_PRINT_ERROR_BACKTRACE for exception backtraces in logs

* consolidate uses of getTraceAsString to use single method where possible which always checks if should print stacktrace

* replace sensitive values and add some tests

* apply more review comments

* another tweak

* remove backtrace omitted error

* fix test

* fix test for travis

* fix test

1 files changed, 2 insertions, 4 deletions

diff --git a/core/CronArchive.php b/core/CronArchive.php
index 18da556f1d..358e6bfa78 100644
--- a/core/CronArchive.php
+++ b/core/CronArchive.php
@@ -32,6 +32,7 @@ use Piwik\Period\Factory as PeriodFactory;
 use Piwik\CronArchive\SegmentArchiving;
 use Piwik\Period\Range;
 use Piwik\Plugins\CoreAdminHome\API as CoreAdminHomeAPI;
+use Piwik\Plugins\Monolog\Processor\ExceptionToTextProcessor;
 use Piwik\Plugins\SitesManager\API as APISitesManager;
 use Piwik\Plugins\UsersManager\API as APIUsersManager;
 use Piwik\Plugins\UsersManager\UserPreferences;
@@ -787,10 +788,7 @@ class CronArchive
                 $this->logger->debug('  Will invalidate archived reports for ' . $date . ' for following websites ids: ' . $listSiteIds);
                 $this->getApiToInvalidateArchivedReport()->invalidateArchivedReports($siteIdsToInvalidate, $date);
             } catch (Exception $e) {
-                $message = $e->getMessage();
-                if (\Piwik_ShouldPrintBackTraceWithMessage()) {
-                    $message .= "\n" . $e->getTraceAsString();
-                }
+                $message = ExceptionToTextProcessor::getMessageAndWholeBacktrace($e);
                 $this->logger->info('  Failed to invalidate archived reports: ' . $message);
             }
         }