diff options
| author | Stefan Giehl <stefan@matomo.org> | 2021-08-17 10:58:59 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-08-17 10:58:59 +0300 |
| commit | 0829d6e6ac487bf47e4197123d6683b271db8266 (patch) | |
| tree | 77f8edd0c326b29c50d9fefd174cd45d5ebcbc92 /core/DataTable/Filter/RangeCheck.php | |
| parent | 8c7fa7d8d414b5201c36661fb4828d14e4c33c53 (diff) | |
Run AllTests on PHP8 (#16897)
* Run AllTests on PHP8
* use newer phpunit for tests on PHP8
* fix notices/errors
* handle trace of phpunit 9
* ensure to compare same types for range check
* adjust expected result for php8
* try handling hasDependencies does not exist in PHPUnit 9
* fix: ArgumentCountError: mysqli_stmt::bind_param() does not accept unknown named parameters
* Fix usercountry tests
* remove incorrect date check
* fix expected exception message
* fix referrers api test for php8
* add test hint
* try to fix session related tests
* debug test failure
* try to fix mail tests
* fix filterUser method
* exlucde phpunit from build size calculation
* fix scheduled reports test
* update release checklist test
* unset climode
* improves some tests
Diffstat (limited to 'core/DataTable/Filter/RangeCheck.php')
| -rw-r--r-- | core/DataTable/Filter/RangeCheck.php | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/core/DataTable/Filter/RangeCheck.php b/core/DataTable/Filter/RangeCheck.php index 52127033c2..8d0ad56b4d 100644 --- a/core/DataTable/Filter/RangeCheck.php +++ b/core/DataTable/Filter/RangeCheck.php @@ -51,9 +51,9 @@ class RangeCheck extends BaseFilter if ($value === false) { $value = $row->getMetadata($this->columnToFilter); if ($value !== false) { - if ($value < (float) self::$minimumValue) { + if ((float) $value < (float) self::$minimumValue) { $row->setMetadata($this->columnToFilter, self::$minimumValue); - } elseif ($value > (float) self::$maximumValue) { + } elseif ((float) $value > (float) self::$maximumValue) { $row->setMetadata($this->columnToFilter, self::$maximumValue); } } @@ -61,9 +61,9 @@ class RangeCheck extends BaseFilter } if ($value !== false) { - if ($value < (float) self::$minimumValue) { + if ((float) $value < (float) self::$minimumValue) { $row->setColumn($this->columnToFilter, self::$minimumValue); - } elseif ($value > (float) self::$maximumValue) { + } elseif ((float) $value > (float) self::$maximumValue) { $row->setColumn($this->columnToFilter, self::$maximumValue); } } |