diff options
author | Thomas Steur <thomas.steur@googlemail.com> | 2014-06-06 01:04:41 +0400 |
---|---|---|
committer | Thomas Steur <thomas.steur@googlemail.com> | 2014-06-06 01:04:41 +0400 |
commit | b457fcc96885ae6a33896be4f1e98aec9efaf0fa (patch) | |
tree | e84a22fe8d1fbf56f5544654ed47af04faf3a03d /core/Menu | |
parent | c53dbe71fc5fb16db25386543769e7edc32100fa (diff) |
refs #5301 make sure to pass the instance to ScheduledTasks and not the className. Otherwise it is called statically. The disadvantage of this way is all task will be stored under the name "Tasks.$methodName" which can lead to naming collisions very quickly if it is not already the case. I am wondering why we keep only the last part of the class name and not the full namespaced class name here: https://github.com/piwik/piwik/blob/master/core/ScheduledTask.php#L105 ? Keeping the namespace would fix the naming collision. If we change to full namespace it could be possible a scheduled task is not executed once as the name changes
Diffstat (limited to 'core/Menu')
0 files changed, 0 insertions, 0 deletions