require PIWIK_PRINT_ERROR_BACKTRACE for exception backtraces in logs (#16640)

* require PIWIK_PRINT_ERROR_BACKTRACE for exception backtraces in logs

* consolidate uses of getTraceAsString to use single method where possible which always checks if should print stacktrace

* replace sensitive values and add some tests

* apply more review comments

* another tweak

* remove backtrace omitted error

* fix test

* fix test for travis

* fix test

1 files changed, 2 insertions, 4 deletions

diff --git a/core/Plugin/Visualization.php b/core/Plugin/Visualization.php
index bc484b8fd9..064c012b91 100644
--- a/core/Plugin/Visualization.php
+++ b/core/Plugin/Visualization.php
@@ -27,6 +27,7 @@ use Piwik\Period;
 use Piwik\Piwik;
 use Piwik\Plugins\API\API as ApiApi;
 use Piwik\Plugins\API\Filter\DataComparisonFilter;
+use Piwik\Plugins\Monolog\Processor\ExceptionToTextProcessor;
 use Piwik\Plugins\PrivacyManager\PrivacyManager;
 use Piwik\SettingsPiwik;
 use Piwik\View;
@@ -205,10 +206,7 @@ class Visualization extends ViewDataTable
                 'ignoreInScreenWriter' => true,
             ]);
 
-            $message = $e->getMessage();
-            if (\Piwik_ShouldPrintBackTraceWithMessage()) {
-                $message .= "\n" . $e->getTraceAsString();
-            }
+            $message = ExceptionToTextProcessor::getMessageAndWholeBacktrace($e);
 
             $loadingError = array('message' => $message);
         }