refs https://github.com/piwik/plugin-QueuedTracking/issues/21 allow any plugin setting to be overwritten in the config file

1 files changed, 35 insertions, 0 deletions

diff --git a/core/Settings/SystemSetting.php b/core/Settings/SystemSetting.php
index 94f7416c19..fb0a4d7a2d 100644
--- a/core/Settings/SystemSetting.php
+++ b/core/Settings/SystemSetting.php
@@ -9,6 +9,7 @@
 
 namespace Piwik\Settings;
 
+use Piwik\Config;
 use Piwik\Piwik;
 
 /**
@@ -58,6 +59,10 @@ class SystemSetting extends Setting
      */
     public function isWritableByCurrentUser()
     {
+        if ($this->hasConfigValue()) {
+            return false;
+        }
+
         return $this->writableByCurrentUser;
     }
 
@@ -80,4 +85,34 @@ class SystemSetting extends Setting
     {
         return 30;
     }
+
+    public function getValue()
+    {
+        $defaultValue = parent::getValue(); // we access value first to make sure permissions are checked
+
+        $configValue = $this->getValueFromConfig();
+
+        if (isset($configValue)) {
+            $defaultValue = $configValue;
+            settype($defaultValue, $this->type);
+        }
+
+        return $defaultValue;
+    }
+
+    private function hasConfigValue()
+    {
+        $value = $this->getValueFromConfig();
+        return isset($value);
+    }
+
+    private function getValueFromConfig()
+    {
+        $config = Config::getInstance()->{$this->pluginName};
+
+        if (!empty($config) && array_key_exists($this->name, $config)) {
+            return $config[$this->name];
+        }
+    }
+
 }