display insights icon in its own footer icon section. the footer icon definition is a hack and needs to be refactored... having maybe a look after the next release

1 files changed, 17 insertions, 1 deletions

diff --git a/core/ViewDataTable/Manager.php b/core/ViewDataTable/Manager.php
index aeb666d21c..8f05f8b17f 100644
--- a/core/ViewDataTable/Manager.php
+++ b/core/ViewDataTable/Manager.php
@@ -16,6 +16,7 @@ use Piwik\Plugins\CoreVisualizations\Visualizations\HtmlTable;
 use Piwik\Plugins\CoreVisualizations\Visualizations\JqplotGraph\Bar;
 use Piwik\Plugins\CoreVisualizations\Visualizations\JqplotGraph\Pie;
 use Piwik\Plugins\Goals\Visualizations\Goals;
+use Piwik\Plugins\Insights\Visualizations\Insight;
 
 /**
  * ViewDataTable Manager.
@@ -194,6 +195,12 @@ class Manager
             $result[] = $normalViewIcons;
         }
 
+        // add insight views
+        $insightsViewIcons = array(
+            'class'   => 'tableInsightViews',
+            'buttons' => array(),
+        );
+
         // add graph views
         $graphViewIcons = array(
             'class'   => 'tableGraphViews tableGraphCollapsed',
@@ -218,12 +225,21 @@ class Manager
 
         foreach ($nonCoreVisualizations as $id => $klass) {
             if ($klass::canDisplayViewDataTable($view)) {
-                $graphViewIcons['buttons'][] = static::getFooterIconFor($id);
+                $footerIcon = static::getFooterIconFor($id);
+                if (Insight::ID == $footerIcon['id']) {
+                    $insightsViewIcons['buttons'][] = static::getFooterIconFor($id);
+                } else {
+                    $graphViewIcons['buttons'][] = static::getFooterIconFor($id);
+                }
             }
         }
 
         $graphViewIcons['buttons'] = array_filter($graphViewIcons['buttons']);
 
+        if (!empty($insightsViewIcons['buttons'])) {
+            $result[] = $insightsViewIcons;
+        }
+
         if (!empty($graphViewIcons['buttons'])) {
             $result[] = $graphViewIcons;
         }