diff options
author | Thomas Steur <thomas.steur@googlemail.com> | 2014-08-06 01:08:47 +0400 |
---|---|---|
committer | Thomas Steur <thomas.steur@googlemail.com> | 2014-08-06 11:02:59 +0400 |
commit | 0508e38d7d2247501ee2951e90e01724b79776b6 (patch) | |
tree | 68c2053a96363165728c6a0c429512e2efc92e54 /core | |
parent | 3528547ccf8e7c2a354b31be2b7e0f4c7ebcc093 (diff) |
refs #5896 this fixes some tests
Diffstat (limited to 'core')
-rw-r--r-- | core/DataTable.php | 3 | ||||
-rw-r--r-- | core/DataTable/Filter/ColumnDelete.php | 4 |
2 files changed, 5 insertions, 2 deletions
diff --git a/core/DataTable.php b/core/DataTable.php index 1e594e4e41..7bf7cceef5 100644 --- a/core/DataTable.php +++ b/core/DataTable.php @@ -1634,6 +1634,9 @@ class DataTable implements DataTableInterface, \IteratorAggregate $thisRow->sumRow($row, $copyMeta = true, $this->getMetadata(self::COLUMN_AGGREGATION_OPS_METADATA_NAME)); } + /** + * @return \ArrayIterator|Row[] + */ public function getIterator() { return new \ArrayIterator($this->rows); } diff --git a/core/DataTable/Filter/ColumnDelete.php b/core/DataTable/Filter/ColumnDelete.php index f9f9773af8..532cd5c644 100644 --- a/core/DataTable/Filter/ColumnDelete.php +++ b/core/DataTable/Filter/ColumnDelete.php @@ -100,7 +100,7 @@ class ColumnDelete extends BaseFilter // remove columns specified in $this->columnsToRemove if (!empty($this->columnsToRemove)) { - foreach ($table as $row) { + foreach ($table as &$row) { foreach ($this->columnsToRemove as $column) { if ($this->deleteIfZeroOnly) { $value = $row[$column]; @@ -118,7 +118,7 @@ class ColumnDelete extends BaseFilter // remove columns not specified in $columnsToKeep if (!empty($this->columnsToKeep)) { - foreach ($table as $row) { + foreach ($table as &$row) { foreach ($row as $name => $value) { $keep = false; |