diff options
author | Thomas Steur <thomas.steur@googlemail.com> | 2014-08-11 18:29:58 +0400 |
---|---|---|
committer | Thomas Steur <thomas.steur@googlemail.com> | 2014-08-11 18:29:58 +0400 |
commit | 1fa7995ced5189ecd4dc8787419d72bb591c2653 (patch) | |
tree | f92de23a844942a577f2bb5044ff775f8a3ee68d /core | |
parent | c2a4f86902afd2e5bcdc179d86da718a8af7faba (diff) |
refs #5820 added some tests for reports and columns refactoring
Diffstat (limited to 'core')
-rw-r--r-- | core/Plugin/Dimension/VisitDimension.php | 2 | ||||
-rw-r--r-- | core/Plugin/Report.php | 7 |
2 files changed, 6 insertions, 3 deletions
diff --git a/core/Plugin/Dimension/VisitDimension.php b/core/Plugin/Dimension/VisitDimension.php index d906bd804f..f293271da8 100644 --- a/core/Plugin/Dimension/VisitDimension.php +++ b/core/Plugin/Dimension/VisitDimension.php @@ -71,7 +71,7 @@ abstract class VisitDimension extends Dimension */ public function install() { - if (!$this->columnType) { + if (empty($this->columnType) || empty($this->columnName)) { return array(); } diff --git a/core/Plugin/Report.php b/core/Plugin/Report.php index 60c9af14d4..2dca75a542 100644 --- a/core/Plugin/Report.php +++ b/core/Plugin/Report.php @@ -193,8 +193,11 @@ class Report { $classname = get_class($this); $parts = explode('\\', $classname); - $this->module = $parts[2]; - $this->action = lcfirst($parts[4]); + + if (5 === count($parts)) { + $this->module = $parts[2]; + $this->action = lcfirst($parts[4]); + } $this->init(); } |