Compute row percentages in PHP before metrics are formatted to avoid percentage formatting WARNINGS. (#15304)

* Compute row percentages in PHP before metrics are formatted to avoid percentage formatting WARNINGS.

* do not fail if site summary is not available

* Make sure siteSummary requests total data without segment.

* Make sure proper precision is used.

* try to fix tests

* update expected screenshots

1 files changed, 12 insertions, 0 deletions

diff --git a/core/Twig.php b/core/Twig.php
index b8b92f283e..afb6a1cdc2 100644
--- a/core/Twig.php
+++ b/core/Twig.php
@@ -198,6 +198,7 @@ class Twig
         $this->addTest_false();
         $this->addTest_true();
         $this->addTest_emptyString();
+        $this->addTest_isNumeric();
 
         $this->twig->addExtension(new PiwikTwigFilterExtension());
     }
@@ -575,4 +576,15 @@ class Twig
         });
         $this->twig->addFilter($safelink);
     }
+
+    private function addTest_isNumeric()
+    {
+        $test = new Twig_SimpleTest(
+            'numeric',
+            function ($value) {
+                return is_numeric($value);
+            }
+        );
+        $this->twig->addTest($test);
+    }
 }