diff options
| author | Ben Hayden <hayden767@gmail.com> | 2022-03-11 11:47:56 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-11 11:47:56 +0300 |
| commit | 6ca37dfc23ba7f98ac4060369c230f05e4e8d651 (patch) | |
| tree | c1a0df61b3c1379f117b4ca3e1fddd0e51d6cad1 /core | |
| parent | 62ee7b12769d787c9f46d5bece8d3a8f2f381a1f (diff) | |
Fix PHP8 Trim Error (#18903)
* Fix PHP8 Trim Error
An error happens if sites if names or skus are arrays in PHP 8
> Uncaught exception in core/Tracker/GoalManager.php line 567:
> trim(): Argument #1 ($string) must be of type string, array given
* Add unit test for PHP8 trim fix
Diffstat (limited to 'core')
| -rw-r--r-- | core/Tracker/GoalManager.php | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/core/Tracker/GoalManager.php b/core/Tracker/GoalManager.php index 5c458c28ba..ea37d447b5 100644 --- a/core/Tracker/GoalManager.php +++ b/core/Tracker/GoalManager.php @@ -560,8 +560,10 @@ class GoalManager foreach ($cleanedItems as $item) { $actionsToLookup = array(); - list($sku, $name, $category, $price, $quantity) = $item; + list($sku_check, $name_check, $category, $price, $quantity) = $item; + $sku = is_array($sku_check) ? join(',', $sku_check) : $sku_check; $actionsToLookup[] = array(trim($sku), Action::TYPE_ECOMMERCE_ITEM_SKU); + $name = is_array($name_check) ? join(',', $name_check) : $name_check; $actionsToLookup[] = array(trim($name), Action::TYPE_ECOMMERCE_ITEM_NAME); // Only one category |