diff options
author | vipsoft <vipsoft@59fd770c-687e-43c8-a1e3-f5a4ff64c105> | 2009-06-12 16:22:49 +0400 |
---|---|---|
committer | vipsoft <vipsoft@59fd770c-687e-43c8-a1e3-f5a4ff64c105> | 2009-06-12 16:22:49 +0400 |
commit | f36763f059752750a092713ab6816274f260582f (patch) | |
tree | 0cf9b20688a974ba1156868d1517a96fc6e0819b /js | |
parent | 5e86fe0d261d8d3162f0b574819ecf697a7ab8cb (diff) |
Fixes #785 - omit return value -- default action is implied
(accommodates IE's handling of poorly written JavaScript)
The right way to prevent the default action with multiple click
handlers:
{{{
element.onclick = function (e) {
e = e || window.event;
if (e.preventDefault)
e.preventDefault();
else
e.returnValue = false;
return false;
}
}}}
Diffstat (limited to 'js')
-rw-r--r-- | js/piwik.js | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/js/piwik.js b/js/piwik.js index eda9304f90..402c2da46c 100644 --- a/js/piwik.js +++ b/js/piwik.js @@ -689,7 +689,7 @@ try { } else if (isDefined(clickEvent.srcElement)) { sourceElement = clickEvent.srcElement; } else { - return true; + return; } while ((tag = sourceElement.tagName) != 'A' && tag != 'AREA') { @@ -712,9 +712,6 @@ try { } } } - - // Returns true so href isn't cancelled - return true; } /* |